New issue
Advanced search Search tips

Issue 701522 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocked on:
issue 701518



Sign in to add a comment

SQLite 3.17 defines conflicting _CRT_RAND_S.

Project Member Reported by sh...@chromium.org, Mar 14 2017

Issue description

Chromium defines:
build/config/win/BUILD.gn:175:    "_CRT_RAND_S",

sqliteInt.h has:
#if defined(_MSC_VER) && _MSC_VER>=1400
#  define _CRT_RAND_S
#endif

These conflict.  I'm patching to add an #ifndef before defining, but seems like something which shouldn't conflict (either the #ifndef, or #undef before #define).
 

Comment 1 by sh...@chromium.org, Mar 14 2017

Or remove the item from the flags Chromium builds SQLite with?

Comment 2 by sh...@chromium.org, Jun 21 2017

Labels: ShessReview

Comment 3 by jrobb...@google.com, Sep 21 2017

Owner: pwnall@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582

commit 8a87f7e5ea0fbd62d9ce5e70d9438e709683a582
Author: Victor Costan <pwnall@chromium.org>
Date: Fri Nov 10 01:29:30 2017

sqlite: Upgrade from 3.20.1 to 3.21.0.

Release notes for the new version:
https://sqlite.org/releaselog/3_21_0.html

Patch 0003 (Modify default VFS to support WebDatabase) was updated to
reflect conflicts introduced by the following commits:
* https://www.sqlite.org/src/info/3075cfa07489eaf1
* https://www.sqlite.org/src/info/1a7e0b61c8a6bdd3

The patch was updated to reflect the rename of pUnused to
pPreallocatedUnused and an extra assert added. Both changes were in
src/os_unix.c.

Patch 0004 (Virtual table supporting recovery of corrupted databases)
was updated to reflect the addition of new compile-time flags to
main.mk.

Patch 0005 (Custom shell.c helpers to load Chromium's ICU data) was
updated to reflect conflicts introduced by
https://www.sqlite.org/src/info/36acc0a97fdcc6f5 which replaced
src/shell.c with src/shell.c.in, which is used to generate src/shell.c
via Tcl. The change in the build process also introduced conflicts in
main.mk.

Patch 0009 (Fix _CRT_RAND_S conflict in sqliteInt.h) was removed
completely. It is no longer necessary, because
https://www.sqlite.org/src/info/3a2793aa65727cbb removed the use of
_CRT_RAND_S in src/sqliteInt.h.

Patches 0012 and 0013 were removed, because they were backports for
upstream changes that fixed clusterfuzz issues. Upgrading removed the
need for backports altogether.

The new SQLite release allows ATTACH and DETACH to be used inside
transactions, so sql/connection_unittest.cc was updated to reflect the
new behavior. The test for attaching databases was broken into two
tests, covering the behavior with and without a transaction. The former
test (covering the behavior with a transaction) has separate
implementations for iOS, where we use the system SQLite, which might be
old, and every other platform, where we ship our own SQLite version.

Bug:  780626 ,  701522 
Change-Id: I7a8378cb317966388ebe9903d9e61162d3b3d3c9
Reviewed-on: https://chromium-review.googlesource.com/754522
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515403}
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/sql/connection.h
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/sql/connection_unittest.cc
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/BUILD.gn
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/README.chromium
[rename] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/amalgamation/shell.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/amalgamation/sqlite3.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/amalgamation/sqlite3.h
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/google_generate_amalgamation.sh
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/patches/0001-test-SQLite-tests-compiling-on-Linux.patch
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/patches/0002-Use-seperate-page-cache-pools-for-each-sqlite-connec.patch
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/patches/0003-Modify-default-VFS-to-support-WebDatabase.patch
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/patches/0004-Virtual-table-supporting-recovery-of-corrupted-datab.patch
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/patches/0005-Custom-shell.c-helpers-to-load-Chromium-s-ICU-data.patch
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/patches/0006-fts3-Disable-fts3_tokenizer-and-fts4.patch
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/patches/0007-fts3-Interior-node-corruption-detection.patch
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/patches/0008-fts3-Fix-uninit-variable-in-fts3EvalDeferredPhrase.patch
[rename] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/patches/0009-Allow-auto-vacuum-to-work-with-chunks.patch
[delete] https://crrev.com/85d947a497871e2bec4ab17fddbe8b244a69b89a/third_party/sqlite/patches/0009-build-Fix-_CRT_RAND_S-conflict-in-sqliteInt.h.patch
[rename] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/patches/0010-fuchsia-Use-dot-file-locking-for-sqlite.patch
[delete] https://crrev.com/85d947a497871e2bec4ab17fddbe8b244a69b89a/third_party/sqlite/patches/0012-Fix-EXPLAIN-PRAGMA-integrity_check-output.patch
[delete] https://crrev.com/85d947a497871e2bec4ab17fddbe8b244a69b89a/third_party/sqlite/patches/0013-Fix-undefined-behavior-in-ICU-extension.patch
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/Makefile.in
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/Makefile.msc
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/VERSION
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/autoconf/Makefile.am
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/autoconf/Makefile.msc
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/configure
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/configure.ac
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/doc/lemon.html
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/fts5/fts5_vocab.c
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/fts5/test/fts5connect.test
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/fts5/test/fts5vocab2.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/lsm1/lsm_shared.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/lsm1/lsm_vtab.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/lsm1/test/lsm1_simple.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/misc/csv.c
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/misc/mmapwarm.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/misc/series.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/misc/unionvtab.c
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/misc/vtablog.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/rbu/rbu10.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/rbu/rbufault.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/rbu/rbufault3.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/rbu/rbufts.test
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/rbu/rbutemplimit.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/rbu/sqlite3rbu.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/rbu/sqlite3rbu.h
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/rbu/test_rbu.c
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/repair/README.md
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/repair/checkfreelist.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/rtree/rtree.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/rtree/rtreeA.test
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/rtree/rtreeconnect.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/ext/session/sqlite3session.h
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/main.mk
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/manifest
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/manifest.uuid
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/alter.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/attach.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/auth.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/btree.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/btree.h
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/btreeInt.h
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/build.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/callback.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/ctime.c
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/dbpage.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/delete.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/expr.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/func.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/global.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/insert.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/main.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/malloc.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/memjournal.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/os.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/os.h
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/os_unix.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/os_win.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/pager.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/pager.h
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/parse.y
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/pcache.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/pcache.h
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/pcache1.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/pragma.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/prepare.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/printf.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/resolve.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/select.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/shell.c.in
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/sqlite.h.in
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/sqlite3ext.h
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/sqliteInt.h
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/status.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/tclsqlite.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/test1.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/test6.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/test8.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/test_bestindex.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/test_config.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/test_devsym.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/test_func.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/test_malloc.c
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/test_md5.c
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/test_tclsh.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/test_tclvar.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/trigger.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/update.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/util.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/vacuum.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/vdbe.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/vdbeInt.h
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/vdbeapi.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/vdbeaux.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/vdbeblob.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/vdbemem.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/vdbesort.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/vdbetrace.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/vtab.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/wal.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/wal.h
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/walker.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/where.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/whereInt.h
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/wherecode.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/src/whereexpr.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/analyze9.test
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/atomic.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/attach2.test
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/bestindex5.test
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/bigmmap.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/busy.test
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/checkfreelist.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/colname.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/corruptC.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/corruptK.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/csv01.test
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/dbpage.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/e_expr.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/e_uri.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/eqp.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/fallocate.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/fts3conf.test
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/fts3rank.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/having.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/indexexpr1.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/indexexpr2.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/kvtest.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/like.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/lookaside.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/memsubsys1.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/misc1.test
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/mjournal.test
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/mmapwarm.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/nan.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/ossfuzz.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/permutations.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/pragma.test
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/pragma5.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/releasetest.tcl
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/rollback.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/savepoint.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/scanstatus.test
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/schema6.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/select1.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/snapshot2.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/speedtest1.c
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/swarmvtab.test
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/swarmvtab2.test
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/swarmvtabfault.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/syscall.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/tester.tcl
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/unionvtabfault.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/vtab2.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/vtabE.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/vtabH.test
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/vtabJ.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/wal2.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/whereA.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/whereF.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/win32heap.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/wordcount.c
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/test/writecrash.test
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/tool/addopcodes.tcl
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/tool/lemon.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/tool/lempar.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/tool/mkautoconfamal.sh
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/tool/mkccode.tcl
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/tool/mkopcodeh.tcl
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/tool/mkshellc.tcl
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/tool/mksourceid.c
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/tool/mksqlite3c.tcl
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/tool/mksqlite3h.tcl
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/tool/speed-check.sh
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/tool/split-sqlite3c.tcl
[add] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/tool/sqlite3_analyzer.c.in
[delete] https://crrev.com/85d947a497871e2bec4ab17fddbe8b244a69b89a/third_party/sqlite/src/tool/tostr.tcl
[modify] https://crrev.com/8a87f7e5ea0fbd62d9ce5e70d9438e709683a582/third_party/sqlite/src/tool/warnings-clang.sh

Comment 5 by pwnall@chromium.org, Nov 10 2017

Status: Fixed (was: Started)

Sign in to add a comment