New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701521 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
OOO until Feb 4th
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome , Mac
Pri: 2
Type: Bug
Team-Accessibility

Blocked on: View detail
issue 647437
issue 658513



Sign in to add a comment

Color Enhancer extension breaks Calendar, Gmail and other apps

Project Member Reported by lpalmaro@chromium.org, Mar 14 2017

Issue description

Chrome Version: 54.0.2840.71
OS: All desktop 

What steps will reproduce the problem?
(1) Enable the Color Enhancer Chrome extension
(2) Navigate to Google Calendar and click around 

Observe that you can't actually click anywhere in Calendar - all clicks are stolen. You have to go to chrome://extensions and disable the extension, then reload Calendar in order to be able to click. 
 
Cc: dmazz...@chromium.org mustaq@chromium.org
Owner: wnwen@chromium.org

Comment 2 by wnwen@chromium.org, Mar 20 2017

Cc: -kevers@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c84eb657463e156ccd0937d55d080194d0a94e6

commit 2c84eb657463e156ccd0937d55d080194d0a94e6
Author: wnwen <wnwen@chromium.org>
Date: Mon Mar 20 23:21:27 2017

Accessibility: Add gn file to build colorenhancer

Initial migration of the old accessibility_extensions.gyp file which
was removed during the gyp purge. Starting with the colorenhancer
extension.

BUG= 701521 

Review-Url: https://codereview.chromium.org/2763573003
Cr-Commit-Position: refs/heads/master@{#458230}

[modify] https://crrev.com/2c84eb657463e156ccd0937d55d080194d0a94e6/BUILD.gn
[add] https://crrev.com/2c84eb657463e156ccd0937d55d080194d0a94e6/ui/accessibility/extensions/BUILD.gn
[delete] https://crrev.com/09e0b1fd3049d3cb92f20cd443cb02f6dab1221c/ui/accessibility/extensions/OWNERS

Comment 4 by wnwen@chromium.org, Mar 22 2017

Unable to reproduce in 57.0.2987.110 for Chrome on Linux, seems to be fixed on the last update since I was able to reproduce before I restarted Chrome.

Comment 5 by wnwen@chromium.org, Mar 22 2017

Right, another difference is I was repro'ing it with my chromebook last time.

Comment 6 by wnwen@chromium.org, Mar 22 2017

Was able to repro in 57.0.2987.110 for Chrome on Mac, although one workaround is to just switch to a different tab and back, and the UI will update.
Labels: NewComponent-Accessibility NewComponent-Accessibility-Features
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c84e01bfb9b85b7703d00d9a27a57a792179f215

commit c84e01bfb9b85b7703d00d9a27a57a792179f215
Author: wnwen <wnwen@chromium.org>
Date: Mon Mar 27 20:52:52 2017

Accessibility: Fix color enhancer disable option

Color enhancer extension should be completely disabled when the user
selects the option to disable it. Previously we used the identity matrix
instead, which can cause problems when there is a filter regression, and
users have to completely remove the extension and refresh.

Also align with the way high contrast is using filters and css.

BUG= 701521 

Review-Url: https://codereview.chromium.org/2771613002
Cr-Commit-Position: refs/heads/master@{#459872}

[modify] https://crrev.com/c84e01bfb9b85b7703d00d9a27a57a792179f215/ui/accessibility/extensions/colorenhancer/manifest.json
[modify] https://crrev.com/c84e01bfb9b85b7703d00d9a27a57a792179f215/ui/accessibility/extensions/colorenhancer/res/cvd.css
[modify] https://crrev.com/c84e01bfb9b85b7703d00d9a27a57a792179f215/ui/accessibility/extensions/colorenhancer/src/cvd.js

Comment 10 by wnwen@chromium.org, Mar 29 2017

Status: Fixed (was: Started)
Status: Started (was: Fixed)
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6963d327a85c2a2b75caff9fa647e124556d8ad5

commit 6963d327a85c2a2b75caff9fa647e124556d8ad5
Author: wnwen <wnwen@chromium.org>
Date: Wed Apr 05 16:11:29 2017

Accessibility: Fix color enhancer manifest

Forgot to remove cvd.css from the manifest.

BUG= 701521 

Review-Url: https://codereview.chromium.org/2796363002
Cr-Commit-Position: refs/heads/master@{#462094}

[modify] https://crrev.com/6963d327a85c2a2b75caff9fa647e124556d8ad5/ui/accessibility/extensions/colorenhancer/manifest.json

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
verified on 61.0.3151.0

Sign in to add a comment