All Skia merges report their branch as trunk erroneously |
|||||
Issue descriptionExample: https://chromiumdash.appspot.com/commit/580ffa0fb17bc4e924776eafd941bf1fab397cde This is because Skia merges don't use standard format for merges / reverts on branch with a relevant branch & position, e.g. here's an example from a WebRTC merge: Cr-Original-Commit-Position: refs/branch-heads/58@{#2} Current logic (IIRC) parses for the @ in lines like that and uses it to determine branch / position, so since that's missing in Skia commits we're blind. We could alternatively pass the branch in when evaluating commits in the first place (e.g. most commits are parsed by the cron jobs that automatically scrape trunk plus release branches) but that might leave us blind for builds pushed from non-standard branches.
,
Nov 30 2017
We're not going to block beta on this - we can mark it as a KI and fix for stable. As far as a solution, we reached out to the Skia team, and it was suggested we use the Gerrit API to look up the CL and pull branch data. We should investigate this and use it as a solution for looking up branch data for all CLs most likely (as that'll be more sustainable than trying to parse from commit messages).
,
Jan 31 2018
,
Jan 31 2018
,
Sep 8
No longer on the Chrome team, e-mail me @google.com if any attention still required from me here, otherwise good luck! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by amineer@chromium.org
, May 20 2017