New issue
Advanced search Search tips

Issue 701499 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocked on:
issue 701457

Blocking:
issue 674593


Show other hotlists

Hotlists containing this issue:
Non-Standard-IDL


Sign in to add a comment

Merge WindowTimers into WindowOrWorkerGlobalScope

Project Member Reported by lunalu@chromium.org, Mar 14 2017

Issue description

There is a link in the idl file but it doesn't really describe WindowTimers. Neither Gecko or WebKit has it. Should we standardize or remove it?
 
Summary: Merge WindowTimers into WindowOrWorkerGlobalScope (was: Standardize or remove WindowTimers)
This used to exist in the spec but it was refactored into WindowOrWorkerGlobalScope. There should be no observable behavior change in moving things there.

Comment 2 by tkent@chromium.org, Mar 24 2017

Components: -Blink>HTML>Frame Blink>HTML
Labels: -Type-Bug Type-Task
Status: Available (was: Untriaged)
Blockedon: 701457
Cc: foolip@chromium.org
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 11 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by tkent@chromium.org, Apr 13 2018

Labels: -Hotlist-Recharge-Cold Hotlist-GoodFirstBug
Status: Available (was: Untriaged)
Owner: tkent@chromium.org
Status: Started (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1adac3e75765e869599a4fe2de0e6409eb9414f2

commit 1adac3e75765e869599a4fe2de0e6409eb9414f2
Author: Kent Tamura <tkent@chromium.org>
Date: Thu Nov 22 10:53:55 2018

Rename WindowTimers to WindowOrWorkerGlobalScope

 * window_tiemrs.idl -> window_or_worker_global_scope.idl
 * dom_window_timers.{cc,h} -> window_or_worker_global_scope.{cc,h}
 * blink::DOMWindowTimers -> blink::WindowOrWorkerGlobalScope

in order to match to the HTML standard.

This CL has no behavior changes.

Bug:  701499 
Change-Id: Iec6fd1cca6d62d4292f6067047c97440d1d31a33
Reviewed-on: https://chromium-review.googlesource.com/c/1347968
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610371}
[modify] https://crrev.com/1adac3e75765e869599a4fe2de0e6409eb9414f2/third_party/blink/renderer/core/core_idl_files.gni
[modify] https://crrev.com/1adac3e75765e869599a4fe2de0e6409eb9414f2/third_party/blink/renderer/core/frame/BUILD.gn
[modify] https://crrev.com/1adac3e75765e869599a4fe2de0e6409eb9414f2/third_party/blink/renderer/core/frame/window.idl
[rename] https://crrev.com/1adac3e75765e869599a4fe2de0e6409eb9414f2/third_party/blink/renderer/core/frame/window_or_worker_global_scope.cc
[rename] https://crrev.com/1adac3e75765e869599a4fe2de0e6409eb9414f2/third_party/blink/renderer/core/frame/window_or_worker_global_scope.h
[rename] https://crrev.com/1adac3e75765e869599a4fe2de0e6409eb9414f2/third_party/blink/renderer/core/frame/window_or_worker_global_scope.idl
[modify] https://crrev.com/1adac3e75765e869599a4fe2de0e6409eb9414f2/third_party/blink/renderer/core/workers/worker_global_scope.idl

Status: Fixed (was: Started)

Sign in to add a comment