New issue
Advanced search Search tips

Issue 701498 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocked on:
issue 701457

Blocking:
issue 674593


Show other hotlists

Hotlists containing this issue:
Non-Standard-IDL


Sign in to add a comment

Merge WindowBase64 into WindowOrWorkerGlobalScope

Project Member Reported by lunalu@chromium.org, Mar 14 2017

Issue description

There is a link in the idl file but it doesn't really describe WindowBase64. Neither Gecko or WebKit has it. Should we standardize or remove it?
 
Summary: Merge WindowBase64 into WindowOrWorkerGlobalScope (was: Standardize or remove WindowBase64)
This used to exist in the spec but it was refactored into WindowOrWorkerGlobalScope. There should be no observable behavior change in moving things there.

Comment 2 by tkent@chromium.org, Mar 24 2017

Components: -Blink>HTML>Frame Blink>HTML
Labels: -Type-Bug Type-Task
Status: Available (was: Untriaged)
Blockedon: 701457
Cc: foolip@chromium.org
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 11 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by tkent@chromium.org, Apr 13 2018

Labels: -Hotlist-Recharge-Cold Hotlist-GoodFirstBug
Status: Available (was: Untriaged)
Owner: acomminos@fb.com
Status: Started (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93b8d80ed987603ed0d5851400f6d30d4d9806da

commit 93b8d80ed987603ed0d5851400f6d30d4d9806da
Author: Andrew Comminos <acomminos@fb.com>
Date: Thu Nov 29 03:43:11 2018

Unify WindowBase64 into WindowOrWorkerGlobalScope.

The HTML5 spec recently refactored WindowBase64 into
WindowOrWorkerGlobalScope, removing the need to reflect this in our IDL.
{btoa,atob} implementations have been merged into
window_or_worker_global_scope.{cc,h}.

This CL has no behavior changes.

Bug:  701498 
Change-Id: Ib40b30e166ef3e4c0c92791f3ffecbb7bd1bed0b
Reviewed-on: https://chromium-review.googlesource.com/c/1351141
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Andrew Comminos <acomminos@fb.com>
Cr-Commit-Position: refs/heads/master@{#612020}
[modify] https://crrev.com/93b8d80ed987603ed0d5851400f6d30d4d9806da/third_party/blink/renderer/core/core_idl_files.gni
[modify] https://crrev.com/93b8d80ed987603ed0d5851400f6d30d4d9806da/third_party/blink/renderer/core/frame/BUILD.gn
[modify] https://crrev.com/93b8d80ed987603ed0d5851400f6d30d4d9806da/third_party/blink/renderer/core/frame/dom_window.h
[delete] https://crrev.com/1b39ce73c483efc6792ed5b2dbfcf3fc6649be36/third_party/blink/renderer/core/frame/dom_window_base64.cc
[delete] https://crrev.com/1b39ce73c483efc6792ed5b2dbfcf3fc6649be36/third_party/blink/renderer/core/frame/dom_window_base64.h
[modify] https://crrev.com/93b8d80ed987603ed0d5851400f6d30d4d9806da/third_party/blink/renderer/core/frame/window.idl
[delete] https://crrev.com/1b39ce73c483efc6792ed5b2dbfcf3fc6649be36/third_party/blink/renderer/core/frame/window_base64.idl
[modify] https://crrev.com/93b8d80ed987603ed0d5851400f6d30d4d9806da/third_party/blink/renderer/core/frame/window_or_worker_global_scope.cc
[modify] https://crrev.com/93b8d80ed987603ed0d5851400f6d30d4d9806da/third_party/blink/renderer/core/frame/window_or_worker_global_scope.h
[modify] https://crrev.com/93b8d80ed987603ed0d5851400f6d30d4d9806da/third_party/blink/renderer/core/frame/window_or_worker_global_scope.idl
[modify] https://crrev.com/93b8d80ed987603ed0d5851400f6d30d4d9806da/third_party/blink/renderer/core/workers/worker_global_scope.h
[modify] https://crrev.com/93b8d80ed987603ed0d5851400f6d30d4d9806da/third_party/blink/renderer/core/workers/worker_global_scope.idl

Status: Fixed (was: Started)

Sign in to add a comment