Convert use of VoidCallback to what is used by the relevant specs |
||||||||
Issue descriptionThis callback interface was added for HTMLMediaElement's addCuePoint() and removeCuePoint(), which briefly existed in 2007. It is no longer used in HTML and should be moved to where it is used.
,
Mar 20 2017
https://w3c.github.io/webrtc-pc/#legacy-interface-extensions uses VoidFunction and https://www.w3.org/TR/webdatabase/#asynchronous-database-api has a SQLVoidCallback type. https://w3c.github.io/filesystem-api/#directory-webidl has a promise-based API. If there's no usage left in any spec, we should instead transition to other types. Renaming to reflect that.
,
Mar 20 2017
Affected IDL files: Source/modules/filesystem/DirectoryEntry.idl Source/modules/filesystem/Entry.idl Source/modules/peerconnection/RTCPeerConnection.idl Source/modules/webdatabase/Database.idl
,
Mar 20 2017
,
Mar 22 2017
https://w3c.github.io/filesystem-api/#directory-webidl is not implemented by anyone, let alone Chrome. The relevant snapshot of the earlier spec we implement in Chrome is: https://dev.w3.org/2009/dap/file-system/file-dir-sys.html#the-voidcallback-interface We can make up a FileSystemVoidCallback if we want.
,
Mar 22 2017
https://heycam.github.io/webidl/#VoidFunction might be a suitable type for most or all of these cases.
,
Mar 23 2017
VoidFunction sgtm (If anyone is depending on 'callback interface' behavior for these I'll eat my hat. Well, no, because it's a nice hat. I'll eat someone's hat.)
,
Mar 28 2017
Funny enough, lots of things that look like callback interfaces don't actually have that behavior, only EventListener and NodeFilter do, see issue 630986 and issue 658073 . So the chance of hat for dinner is very, very low.
,
Mar 28 2017
And FYI, both the WebSQL and FileSystem ones were decorated with an obsolete extended attribute implying this behavior anyway:
[Callback=FunctionOnly, NoInterfaceObject]
interface SQLVoidCallback {
void handleEvent();
};
[Callback=FunctionOnly]
interface VoidCallback {
void handleEvent ();
};
,
Mar 28 2017
(in the spec I mean)
,
Mar 30 2017
That's funny, I guess there was a time when callback functions didn't exist and that was the only way?
,
Apr 3 2017
,
May 19 2017
Making this non-trivial in the WebSQL case: InspectorDatabaseAgent subclasses VoidCallback, overriding handleEvent(). We don't currently allow the a generated VoidFunction::call() to be overridden.
,
May 21 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 15 2018
,
Jun 15 2018
,
Jun 18 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dtapu...@chromium.org
, Mar 20 2017