New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 701490 link

Starred by 4 users
Status: Fixed
Owner:
fs...@chromium.org
Closed: Apr 2017
Cc:
elawrence@chromium.org
█ junov@chromium.org
█ zakerinasab@chromium.org
fs...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Upcoming changes to CanvasContext2D getImageData()

Project Member Reported by fs...@chromium.org, Mar 14 2017 
This is a heads up that we are considering changing the spec of getImageData() to improve interoperability.

The gist of it is we are changing the IDL signature of the function from double to long, removing edge cases (dimensions in (0,1) range) and adding web platform tests.

This is the relevant issue: https://github.com/whatwg/html/issues/2433

I'll update this with the spec and web-platform change when appropriate.

Comment 1 by fs...@chromium.org, Mar 14 2017

Cc: junov@chromium.org zakerinasab@chromium.org fs...@chromium.org
 Issue 700130  has been merged into this issue.

Comment 3 by fs...@chromium.org, Mar 31 2017

Cc: elawrence@chromium.org
 Issue 700633  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5aae822c218a67b706125e9620290026d523d629

commit 5aae822c218a67b706125e9620290026d523d629
Author: fserb <fserb@chromium.org>
Date: Mon Apr 03 16:50:23 2017

Update createImageData/getImageData/putImageData from float to long

On both CanvasRenderingContext2D and OffscreenCanvas.

BUG= 701490 

Review-Url: https://codereview.chromium.org/2771933002
Cr-Commit-Position: refs/heads/master@{#461455}

[modify] https://crrev.com/5aae822c218a67b706125e9620290026d523d629/third_party/WebKit/LayoutTests/canvas/philip/tests/2d.imageData.create2.tiny-expected.txt
[modify] https://crrev.com/5aae822c218a67b706125e9620290026d523d629/third_party/WebKit/LayoutTests/canvas/philip/tests/2d.imageData.get.tiny-expected.txt
[modify] https://crrev.com/5aae822c218a67b706125e9620290026d523d629/third_party/WebKit/LayoutTests/fast/canvas/canvas-getImageData-invalid.html
[modify] https://crrev.com/5aae822c218a67b706125e9620290026d523d629/third_party/WebKit/LayoutTests/fast/canvas/canvas-getImageData-large-crash.html
[modify] https://crrev.com/5aae822c218a67b706125e9620290026d523d629/third_party/WebKit/LayoutTests/fast/canvas/canvas-getImageData-rounding.html
[modify] https://crrev.com/5aae822c218a67b706125e9620290026d523d629/third_party/WebKit/LayoutTests/fast/canvas/canvas-putImageData.html
[modify] https://crrev.com/5aae822c218a67b706125e9620290026d523d629/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/5aae822c218a67b706125e9620290026d523d629/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
[modify] https://crrev.com/5aae822c218a67b706125e9620290026d523d629/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl
[modify] https://crrev.com/5aae822c218a67b706125e9620290026d523d629/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl

Comment 5 by fs...@chromium.org, Apr 3 2017

Status: Fixed (was: Assigned)
\o/
►

Sign in to add a comment