Issue metadata
Sign in to add a comment
|
Logdog does not works in safari.
Reported by
alex...@yandex-team.ru,
Mar 14 2017
|
||||||||||||||||||||||
Issue descriptionSteps to reproduce: 1. Open in safary a gerrit codereview page (e.g. https://codereview.chromium.org/2638763004 ); 2. Navigate to tryjob; 3. Try to view logs of any step. Expected: Full log in any interface. Got: Complete logs are available only in the logdog. Logdog emmits some errors into javascript console and doesn't show any text. Same issue on ios safari and chrome for ios.
,
Mar 14 2017
Oh actually, in the meantime, if you wouldn't mind: 1) Posting the version of Safari that you used. 2) Posting the JavaScript errors that you observed. 3) Posting a screenshot of the page (if you can). That would be useful to collect. Thanks!
,
Mar 14 2017
I can repo on Safari Version 10.0.3 (12602.4.8) OSX Sierra 10.12.3 (16D32) The console says: ReferenceError: Can't find variable: logdog
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/d11c001579e3145d6431fcf80f4985623b3bfee7 commit d11c001579e3145d6431fcf80f4985623b3bfee7 Author: dnj <dnj@chromium.org> Date: Tue Mar 14 22:19:26 2017 LogDog: index.html determines app parameters. Load app parameters in "index.html", rather than indirectly through a linked script. Using the linked script introduced a load race condition that was notable on Safari. BUG= chromium:701488 TEST=local - Tested locally in Chrome and Safari. Review-Url: https://codereview.chromium.org/2748973004 [modify] https://crrev.com/d11c001579e3145d6431fcf80f4985623b3bfee7/web/apps/logdog-app/index.html [modify] https://crrev.com/d11c001579e3145d6431fcf80f4985623b3bfee7/web/apps/logdog-view/index.html [modify] https://crrev.com/d11c001579e3145d6431fcf80f4985623b3bfee7/web/inc/logdog-app-base/logdog-app-base.html
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/d11c001579e3145d6431fcf80f4985623b3bfee7 commit d11c001579e3145d6431fcf80f4985623b3bfee7 Author: dnj <dnj@chromium.org> Date: Tue Mar 14 22:19:26 2017 LogDog: index.html determines app parameters. Load app parameters in "index.html", rather than indirectly through a linked script. Using the linked script introduced a load race condition that was notable on Safari. BUG= chromium:701488 TEST=local - Tested locally in Chrome and Safari. Review-Url: https://codereview.chromium.org/2748973004 [modify] https://crrev.com/d11c001579e3145d6431fcf80f4985623b3bfee7/web/apps/logdog-app/index.html [modify] https://crrev.com/d11c001579e3145d6431fcf80f4985623b3bfee7/web/apps/logdog-view/index.html [modify] https://crrev.com/d11c001579e3145d6431fcf80f4985623b3bfee7/web/inc/logdog-app-base/logdog-app-base.html
,
Mar 14 2017
A fix has landed and been deployed, so this should be working again now! Thanks again for reporting. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by d...@chromium.org
, Mar 14 2017