On Swarming UI, sort by natural sorting |
||
Issue descriptionhttps://screenshot.googleplex.com/bprPOU2WTdW Bot names are sorted purely based on lexographic order, not naturally (i.e. accounting for numbers) This was done server-side with https://github.com/luci/luci-py/blob/master/client/third_party/chromium/natsort.py
,
Mar 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/264c666a260c581a14b69084f1040e633e369eb7 commit 264c666a260c581a14b69084f1040e633e369eb7 Author: megjablon <megjablon@chromium.org> Date: Wed Mar 22 18:31:07 2017 Check WebContentsObservers before showing Previews InfoBars Check that PreviewsInfoBarTabHelper and InfoBarService are not null before showing a Previews InfoBar. Don't show the InfoBar if one of them is null. BUG=703572 Review-Url: https://codereview.chromium.org/2762853004 Cr-Commit-Position: refs/heads/master@{#458813} [modify] https://crrev.com/264c666a260c581a14b69084f1040e633e369eb7/chrome/browser/previews/previews_infobar_delegate.cc
,
Mar 23 2017
This is live in chromium-swarm, the proper CL was https://codereview.chromium.org/2765313002 |
||
►
Sign in to add a comment |
||
Comment 1 by kjlubick@google.com
, Mar 22 2017