Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 701466 Launch non-constant values for Screen.colorDepth and Screen.pixelDepth
Starred by 3 users Project Member Reported by mlamouri@chromium.org, Mar 14 Back to list
Status: Fixed
Owner:
Closed: May 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: 59-Dev, 59-Beta, 59-Stable
Launch-Privacy: Yes
Launch-Security: ----
Launch-Status: ----
Launch-Test: ----
Launch-UI: ----

Blocking:
issue 703798



Sign in to add a comment
Change description:
The Screen object is no longer required to return 24 for colorDepth and pixelDepth. It enables websites to have a better idea of the number of bits being used to display a color on the screen.

Spec: https://drafts.csswg.org/cssom-view/#screen 
Issue: https://github.com/w3c/csswg-drafts/issues/993
PR: https://github.com/w3c/csswg-drafts/pull/994

Support in other browsers:
Internet Explorer: No signal
Firefox: Public Support
Safari: No signal
 
Labels: Update-Monthly
Cc: yitingc@chromium.org
Labels: Launch-Privacy-Started
+yitingc@ for privacy check. As said in the intent to ship, expectation is that the privacy cost is very low and the added entropy insignificant as high color depth would correlate with other information.
Cc: chrishtr@chromium.org
+chrishtr@
Cc: hbengali@chromium.org
Blocking: 703798
We just discussed this today.

We don't see the fingerprinting concern as blocking. But we'd like to know any known use cases for this capability? And also if the team has any insight of display models distribution, so we known the likelihood of some super rare display devices being linked to either a very small group of users or individuals.
Our implementation will only report 48 when --enable-hdr is toggled and 24 otherwise. We have no plans to do something different at the moment. Websites need to know that HDR is on and this information will not be the only one giving up that HDR is available.
Labels: -Launch-Privacy-Started Launch-Privacy-Yes
Project Member Comment 9 by bugdroid1@chromium.org, Mar 24
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c149655e1546c3bb4478f4dca931e5ad35d4073

commit 7c149655e1546c3bb4478f4dca931e5ad35d4073
Author: mlamouri <mlamouri@chromium.org>
Date: Fri Mar 24 00:00:09 2017

Display: set color_depth and depth_per_component value based on kEnableHDROutput

This is also update the aura code creating the ScreenInfo to use the
value reported by display::Display instead of hardcoding it as
display::Display was doing the same thing. It is more consistent too as
the Mac implementation was already doing this.

This is also moving the kEnableHDROutput from ui/base/ to ui/display/
because ui/display/ can't depend on ui/base/ and it only moves the
dependency of ui/compositor/ from ui/base/ to ui/display/.

In the future, we should set the values on display::Display instead of
hardcoding too values.

Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/c-b866DUg10/MxS1WTWfBgAJ

BUG= 701466 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2742383006
Cr-Commit-Position: refs/heads/master@{#459288}

[modify] https://crrev.com/7c149655e1546c3bb4478f4dca931e5ad35d4073/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/7c149655e1546c3bb4478f4dca931e5ad35d4073/content/browser/media/media_canplaytype_browsertest.cc
[modify] https://crrev.com/7c149655e1546c3bb4478f4dca931e5ad35d4073/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/7c149655e1546c3bb4478f4dca931e5ad35d4073/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/7c149655e1546c3bb4478f4dca931e5ad35d4073/content/browser/web_contents/web_contents_view_aura.cc
[modify] https://crrev.com/7c149655e1546c3bb4478f4dca931e5ad35d4073/content/browser/web_contents/web_contents_view_aura_unittest.cc
[modify] https://crrev.com/7c149655e1546c3bb4478f4dca931e5ad35d4073/content/renderer/media/render_media_client.cc
[modify] https://crrev.com/7c149655e1546c3bb4478f4dca931e5ad35d4073/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/7c149655e1546c3bb4478f4dca931e5ad35d4073/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/7c149655e1546c3bb4478f4dca931e5ad35d4073/gpu/ipc/service/DEPS
[modify] https://crrev.com/7c149655e1546c3bb4478f4dca931e5ad35d4073/gpu/ipc/service/child_window_surface_win.cc
[modify] https://crrev.com/7c149655e1546c3bb4478f4dca931e5ad35d4073/gpu/ipc/service/direct_composition_surface_win.cc
[modify] https://crrev.com/7c149655e1546c3bb4478f4dca931e5ad35d4073/media/gpu/BUILD.gn
[modify] https://crrev.com/7c149655e1546c3bb4478f4dca931e5ad35d4073/media/gpu/DEPS
[modify] https://crrev.com/7c149655e1546c3bb4478f4dca931e5ad35d4073/media/gpu/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/7c149655e1546c3bb4478f4dca931e5ad35d4073/ui/base/ui_base_switches.cc
[modify] https://crrev.com/7c149655e1546c3bb4478f4dca931e5ad35d4073/ui/base/ui_base_switches.h
[modify] https://crrev.com/7c149655e1546c3bb4478f4dca931e5ad35d4073/ui/compositor/BUILD.gn
[modify] https://crrev.com/7c149655e1546c3bb4478f4dca931e5ad35d4073/ui/compositor/DEPS
[modify] https://crrev.com/7c149655e1546c3bb4478f4dca931e5ad35d4073/ui/compositor/compositor.cc
[modify] https://crrev.com/7c149655e1546c3bb4478f4dca931e5ad35d4073/ui/display/display.cc
[modify] https://crrev.com/7c149655e1546c3bb4478f4dca931e5ad35d4073/ui/display/display_switches.cc
[modify] https://crrev.com/7c149655e1546c3bb4478f4dca931e5ad35d4073/ui/display/display_switches.h
[modify] https://crrev.com/7c149655e1546c3bb4478f4dca931e5ad35d4073/ui/display/display_unittest.cc

Cc: -yitingc@chromium.org
Status: Fixed
Sign in to add a comment