New issue
Advanced search Search tips

Issue 701457 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 29
Cc:
Components:
EstimatedDays: 5
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Task

Blocked on:
issue 716007

Blocking:
issue 674593
issue 697147
issue 701498
issue 701499


Show other hotlists

Hotlists containing this issue:
Non-Standard-IDL


Sign in to add a comment

Merge ImageBitmapFactories into WindowOrWorkerGlobalScope mix-in

Project Member Reported by lunalu@chromium.org, Mar 14 2017

Issue description

Neither Gecko or WebKit has it, nor the spec link describes it.
Should we be standardizing it by adding it to the spec?
 
EstimatedDays: 5
Labels: -Type-Bug OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows Type-Compat
Status: Available (was: Untriaged)
Gecko has moved the functionality to a different mixin, so does still support it. https://developer.mozilla.org/en-US/docs/Web/API/ImageBitmapFactories

The question then is whether we should support the WindowOrWorkerGlobalScope mixin: https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope
Components: Blink>ServiceWorker
Components: -Blink>ServiceWorker Blink>Workers
The current HTML doesn't define ImageBitmapFactories on the WindowOrWorkerGlobalScope mixin:
https://html.spec.whatwg.org/multipage/webappapis.html#windoworworkerglobalscope-mixin

Was it deprecated in favor of createImageBitmap? Who knows the current status of the ImageBitmap spec?

Comment 4 by f...@opera.com, Mar 16 2017

Components: -Blink>Image Blink>Canvas
The createImageBitmap methods were moved from the ImageBitmapFactories mix-in to the (newly formed) WindowOrWorkerGlobalScope mix-in by:

https://github.com/whatwg/html/commit/cdd48e1f570c817402bf62108847c4a9f4b00b1e

we're currently missing the latter ("newer") though. The situation should be similar for btoa/atob and other things that got relocated in the commit above.

Comment 5 by junov@chromium.org, Mar 20 2017

Is the change in mix-in observable in JS?  AFAICT, either way createImageBitmap is a member of Window and of WorkerGlobalScope.


Comment 6 by f...@opera.com, Mar 20 2017

The current situation shouldn't be a problem I think. Not having WindowOrWorkerGlobalScope is probably more so (from a development PoV.)

Comment 7 by junov@chromium.org, Mar 20 2017

Owner: zakerinasab@chromium.org
Status: Assigned (was: Available)
Summary: Move ImageBitmapFactories into new WindowOrWorkerGlobalScope mix-in (was: Standardize or remove ImageBitmapFactories?)
Blocking: 701498
Blocking: 701499
Blocking: 697147
Since https://codereview.chromium.org/2798433003/ links to this bug, I've treated it as the "add WindowOrWorkerGlobalScope mix-in" bug and blocked some other things on it.
Cc: foolip@chromium.org
Blockedon: 716007
Owner: ----
Status: Available (was: Assigned)
Labels: -Type-Compat Hotlist-GoodFirstBug Type-Task
Summary: Merge ImageBitmapFactories into WindowOrWorkerGlobalScope mix-in (was: Move ImageBitmapFactories into new WindowOrWorkerGlobalScope mix-in)
Now we have core/frame/window_or_worker_global_scope.idl

I'd like to work on it.
Owner: eui-sang.lim@samsung.com
Status: Started (was: Available)
Project Member

Comment 18 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b2bc0cdfb3a2736bbc573f15009d4ee4ab969cf

commit 0b2bc0cdfb3a2736bbc573f15009d4ee4ab969cf
Author: Amos Lim <eui-sang.lim@samsung.com>
Date: Thu Nov 29 08:11:08 2018

Merge ImageBitmapFactories into WindowOrWorkerGlobalScope mix-in

According to the spec, the createImageBitmap should be moved
to WindowOrWorkerGlobalScope mix-in.

They were moved from the ImageBitmapFactories mix-in
to the WindowOrWorkerGlobalScope mix-in[1].

[1]: https://github.com/whatwg/html/commit/cdd48e1f570c817402bf62108847c4a9f4b00b1e
[2]: https://html.spec.whatwg.org/multipage/webappapis.html#windoworworkerglobalscope-mixin

This CL has no behavior changes.

Bug:  701457 
Change-Id: Idbf0cf3e22019cc24384ab3c409e202343eb1d5a
Reviewed-on: https://chromium-review.googlesource.com/c/1349160
Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612095}
[modify] https://crrev.com/0b2bc0cdfb3a2736bbc573f15009d4ee4ab969cf/third_party/blink/renderer/bindings/scripts/utilities.py
[modify] https://crrev.com/0b2bc0cdfb3a2736bbc573f15009d4ee4ab969cf/third_party/blink/renderer/core/core_idl_files.gni
[modify] https://crrev.com/0b2bc0cdfb3a2736bbc573f15009d4ee4ab969cf/third_party/blink/renderer/core/frame/window_or_worker_global_scope.cc
[modify] https://crrev.com/0b2bc0cdfb3a2736bbc573f15009d4ee4ab969cf/third_party/blink/renderer/core/frame/window_or_worker_global_scope.h
[modify] https://crrev.com/0b2bc0cdfb3a2736bbc573f15009d4ee4ab969cf/third_party/blink/renderer/core/frame/window_or_worker_global_scope.idl
[modify] https://crrev.com/0b2bc0cdfb3a2736bbc573f15009d4ee4ab969cf/third_party/blink/renderer/core/imagebitmap/image_bitmap_factories.cc
[modify] https://crrev.com/0b2bc0cdfb3a2736bbc573f15009d4ee4ab969cf/third_party/blink/renderer/core/imagebitmap/image_bitmap_factories.h
[delete] https://crrev.com/32be36c36cb3f33b01e4ad2a8d7f786b77ebcdba/third_party/blink/renderer/core/imagebitmap/image_bitmap_factories.idl
[modify] https://crrev.com/0b2bc0cdfb3a2736bbc573f15009d4ee4ab969cf/third_party/blink/renderer/modules/shapedetection/shape_detector.h

Status: Fixed (was: Started)

Sign in to add a comment