New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701455 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Default to 1.5x scale factor on devices that need it

Project Member Reported by abodenha@chromium.org, Mar 14 2017

Issue description

Modify the default scale selection code to automatically enable 1.5x on devices between 1.25x and 2x scales.

 
sgabriel@ what DPI levels do you think we should trigger this at? 180-210dpi?
What is the range that needs to be clamped to 1.5x?

Status: Started (was: Assigned)
Let's start 1.5 at 180. Ends at 220 where 2 starts.
sgtm
Updating bug with the new threshold for future record:
1x = ... to 150
1.25x = 151 to 180
1.5x = 181 to 220
2x = 221 to ... 
mdhayter and I calculated sizes based on ideal 9-10mm tap targets, with fringe allowance for down to 8.5mm or up to 10.5mm

https://docs.google.com/spreadsheets/d/1XEzTRrMWqWAHN9L_0Top0gaL8ph5g5YyAFSEh0w-_f4/edit#gid=1151942333
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc59a7a79efc1149ecb849cb6427d61045383298

commit bc59a7a79efc1149ecb849cb6427d61045383298
Author: malaykeshav <malaykeshav@chromium.org>
Date: Thu Mar 16 21:33:54 2017

Updates the device scale factor clamping intervals to

1x = ... to 150
1.25x = 151 to 180
1.5x = 181 to 220
2x = 221 to ...

BUG= 701455 
COMPONENT=DisplayChangeObserver, Device Scale Factor

Review-Url: https://codereview.chromium.org/2745173004
Cr-Commit-Position: refs/heads/master@{#457562}

[modify] https://crrev.com/bc59a7a79efc1149ecb849cb6427d61045383298/ui/display/manager/chromeos/display_change_observer.cc
[modify] https://crrev.com/bc59a7a79efc1149ecb849cb6427d61045383298/ui/display/manager/chromeos/display_change_observer_unittest.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment