New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701452 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task
Team-Security-UX

Blocking:
issue 701454



Sign in to add a comment

Add TEAM email to Page Info OWNERS files

Project Member Reported by lgar...@chromium.org, Mar 14 2017

Issue description

emilyschechter@, meacer@, estark@: Thoughts on security-dev@chromium.org vs. security-enamel@chromium.org?
 
Components: UI>Browser>Bubbles>PageInfo
Blocking: 701454

Comment 3 by mea...@chromium.org, Mar 14 2017

What does TEAM email do? Does it grant all members ownership of the code? If so, you should avoid security-dev as it's a public list.
In particular: no, it does not grant ownership.
* does it have to be a chromium email?

* does security-enamel@chromium already exist?
> * does it have to be a chromium email?

No idea (the doc doesn't explicitly say so), but all the examples are. [1]

> * does security-enamel@chromium already exist?

Yes, that's what we use for Enamel security reviews.

[1] https://cs.chromium.org/search/?q=file:OWNERS+TEAM&type=cs
ok, seems reasonable to use security-enamel then
Cc: sshruthi@chromium.org
I'm still a bit uncertain.

sshruthi@, could you give us some advice?
The Enamel (Security UX) team [1] is one of three teams under the Chrome Security [2].
We have two chromium.org mailing lists:

- security-dev@: General security team. Public mailing list
- security-enamel@: Contains a *subset* of Enamel team, because it is currently used only for certain security reviews (we don't expect all team members to be on it at the moment). Private mailing list.

security-enamel@ is more accurate, but it might prevent both team members and external people from getting any emails related to the code that they should be able to see.

[1] https://www.chromium.org/Home/chromium-security/enamel
[2] https://www.chromium.org/Home/chromium-security/
> security-enamel@ is more accurate, but it might prevent both team members and external people from getting any emails related to the code that they should be able to see.

(And I think we should strongly fight against anything that leads to decisions and explanations in unintentionally unreachable places.)
Thanks for reaching out, lgarron@
The mailing list should be a public one (the doc mentions this in a couple places, but perhaps not very visibly), since as you rightly point out, folks won't be able to reach it otherwise. Does security-enamel@ have to be a private mailing list? It does sound like the right list, if it can be opened up and expanded. But, I obviously don't have enough context to know if that is a possibility.
Owner: lgar...@chromium.org
Status: Assigned (was: Untriaged)
@lucas, is this something you can add?
I can, if security-dev@ is okay.
Labels: -Type-Bug Type-Task

Comment 15 by f...@chromium.org, Jul 12 2017

i think security-dev is fine
Labels: Proj-DirectoryOwnership
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/#/c/592161/
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62eca6ddfdd72d93152b48ee434afda1d6550e12

commit 62eca6ddfdd72d93152b48ee434afda1d6550e12
Author: Lucas Garron <lgarron@chromium.org>
Date: Mon Jul 31 13:46:27 2017

Add team to page_info OWNERS files.

Bug:  701452 
Change-Id: I678802b5c69729b6c9422b8fffd1c3df7354760c
Reviewed-on: https://chromium-review.googlesource.com/592161
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Lucas Garron <lgarron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490754}
[modify] https://crrev.com/62eca6ddfdd72d93152b48ee434afda1d6550e12/chrome/browser/ui/cocoa/page_info/OWNERS
[modify] https://crrev.com/62eca6ddfdd72d93152b48ee434afda1d6550e12/chrome/browser/ui/page_info/OWNERS
[modify] https://crrev.com/62eca6ddfdd72d93152b48ee434afda1d6550e12/chrome/browser/ui/views/page_info/OWNERS

Status: Fixed (was: Started)

Sign in to add a comment