Media controls auto-hide despite keyboard events |
||
Issue descriptionWhat steps will reproduce the problem? (1) Go to https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html (2) Play the video (3) Give keyboard focus to the timeline slider (click video, then press tab twice such that timeline has a focus outline) (4) Hold down the right arrow key for ~7 seconds. What is the expected result? Media controls don't auto-hide because the user is actively interacting with them. What happens instead? Media controls auto-hide and stop accepting keyboard input Tested on 56.0.2924.87 / Ubuntu, but likely applies to all platforms.
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12df228997d26f76483eb438602b22897c24d094 commit 12df228997d26f76483eb438602b22897c24d094 Author: steimel <steimel@chromium.org> Date: Fri Apr 07 20:35:52 2017 Prevent Media Controls from hiding when the user is interacting via the keyboard This CL prevents the controls from hiding by resetting the hide timer on events in two places: 1) Listening for focusin and input events on the MediaControls via defaultEventHandler, which get fired as the user tabs through the controls and as the user changes the timeline/volume sliders respectively. 2) Listening for keypress events on the media panel via adding an event listener to the panel element in MediaControlsMediaEventListener, which gets fired when the user mutes/unmutes, turns CC on/off, etc. BUG= 701440 Review-Url: https://codereview.chromium.org/2757323002 Cr-Commit-Position: refs/heads/master@{#462990} [modify] https://crrev.com/12df228997d26f76483eb438602b22897c24d094/third_party/WebKit/Source/core/html/media/MediaControls.h [modify] https://crrev.com/12df228997d26f76483eb438602b22897c24d094/third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp [modify] https://crrev.com/12df228997d26f76483eb438602b22897c24d094/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp [modify] https://crrev.com/12df228997d26f76483eb438602b22897c24d094/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h [modify] https://crrev.com/12df228997d26f76483eb438602b22897c24d094/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
,
Apr 9 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by steimel@chromium.org
, Mar 16 2017Status: Started (was: Untriaged)