New issue
Advanced search Search tips

Issue 701430 link

Starred by 1 user
Status: Fixed
Merged: issue gerrit:5392
Owner: ----
Closed: Aug 2017
Cc:
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----


Previous locations:
gerrit:5769


Sign in to add a comment

Question: Has there been a change in ACLs/permissions since migration to poly gerrit?

Project Member Reported by erikc...@chromium.org, Mar 14 2017 
I occasionally write CLs for the tools/build repository. e.g.
https://chromium-review.googlesource.com/c/454160/

After the migration to poly-gerrit, after I get a CL reviewed, I need to ask the reviewer to +2 CQ the CL. In the past, I used to be able to hit the "CQ and land" button. Could we make this functionality available again?

Comment 1 by logan@google.com, Mar 14 2017

Mergedinto: 5392
Status: Duplicate (was: New)
I believe CQ+1 is functionally equivalent to what was formerly "CQ dry run", while CQ+2 is equivalent to "CQ and land".

See the issue I duped this with for thoughts about making the label values more meaningful.

Comment 2 by erikc...@chromium.org, Mar 14 2017 

Sorry, but this request is different.

I used to be able to click the CQ and land button for changes in the tools/build repository. Now I can no longer do so in the polygerrit UI.

Comment 3 by erikc...@chromium.org, Mar 14 2017 

I don't have access to CQ+1 or CQ+2

Comment 4 by logan@google.com, Mar 14 2017

Components: -PolyGerrit
Labels: Proj-Gerrit-Migration
Status: New (was: Duplicate)
Ah, sorry for misinterpreting. Let me send this over to chrome-infra.

Comment 5 by logan@google.com, Mar 14 2017

Project: chromium
Moved issue gerrit:5769 to now be  issue chromium:701430 .

Comment 6 by dtapu...@chromium.org, Aug 25 2017

Components: Infra>Codereview>Gerrit
Labels: -Proj=Gerrit-Migration Proj-Gerrit-Migration

Comment 7 by aga...@chromium.org, Aug 28 2017

Status: Fixed (was: New)
This was fixed ages ago. erikchen has access: https://chromium-review.googlesource.com/c/chromium/tools/build/+/616241
►

Sign in to add a comment