Remove gesture token from vrdisplayactivate event |
|||||||||||
Issue descriptionWe should not be allowing generic gesture-based actions on vrdisplayactivate. We should explicitly only allow presentation requests in this case.
,
Mar 14 2017
,
Mar 14 2017
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bcba8c8b526a9476f40f3830b3daabac7812bbcc commit bcba8c8b526a9476f40f3830b3daabac7812bbcc Author: mthiesse <mthiesse@chromium.org> Date: Tue Mar 14 19:54:01 2017 Remove gesture token from vrdisplayactivate Adds a specific exception to the user gesture requirement for presentation when presenting during a vrdisplayactivate event, and removes the generic user gesture from vrdisplayactivate. BUG= 701429 Review-Url: https://codereview.chromium.org/2751753003 Cr-Commit-Position: refs/heads/master@{#456797} [modify] https://crrev.com/bcba8c8b526a9476f40f3830b3daabac7812bbcc/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp [modify] https://crrev.com/bcba8c8b526a9476f40f3830b3daabac7812bbcc/third_party/WebKit/Source/modules/vr/NavigatorVR.h [modify] https://crrev.com/bcba8c8b526a9476f40f3830b3daabac7812bbcc/third_party/WebKit/Source/modules/vr/VRDisplay.cpp [modify] https://crrev.com/bcba8c8b526a9476f40f3830b3daabac7812bbcc/third_party/WebKit/Source/modules/vr/VRDisplay.h
,
Mar 16 2017
,
Mar 16 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57bfb0bcbbc513726876f0bb55692d168aa662bc commit 57bfb0bcbbc513726876f0bb55692d168aa662bc Author: Michael Thiessen <mthiesse@chromium.org> Date: Thu Mar 16 18:39:50 2017 Remove gesture token from vrdisplayactivate Adds a specific exception to the user gesture requirement for presentation when presenting during a vrdisplayactivate event, and removes the generic user gesture from vrdisplayactivate. BUG= 701429 Review-Url: https://codereview.chromium.org/2751753003 Cr-Commit-Position: refs/heads/master@{#456797} (cherry picked from commit bcba8c8b526a9476f40f3830b3daabac7812bbcc) Review-Url: https://codereview.chromium.org/2754133002 . Cr-Commit-Position: refs/branch-heads/3029@{#246} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/57bfb0bcbbc513726876f0bb55692d168aa662bc/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp [modify] https://crrev.com/57bfb0bcbbc513726876f0bb55692d168aa662bc/third_party/WebKit/Source/modules/vr/NavigatorVR.h [modify] https://crrev.com/57bfb0bcbbc513726876f0bb55692d168aa662bc/third_party/WebKit/Source/modules/vr/VRDisplay.cpp [modify] https://crrev.com/57bfb0bcbbc513726876f0bb55692d168aa662bc/third_party/WebKit/Source/modules/vr/VRDisplay.h
,
Mar 16 2017
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf7253a19d61e880f964233caec61b4df6fab647 commit cf7253a19d61e880f964233caec61b4df6fab647 Author: mthiesse <mthiesse@chromium.org> Date: Thu Mar 16 21:57:49 2017 Revert of Remove gesture token from vrdisplayactivate (patchset #1 id:1 of https://codereview.chromium.org/2754133002/ ) Reason for revert: Fails to compile on M58 due to removing a header that was still used. Original issue's description: > Remove gesture token from vrdisplayactivate > > Adds a specific exception to the user gesture requirement for presentation when presenting during a vrdisplayactivate event, and removes the generic user gesture from vrdisplayactivate. > > BUG= 701429 > > Review-Url: https://codereview.chromium.org/2751753003 > Cr-Commit-Position: refs/heads/master@{#456797} > (cherry picked from commit bcba8c8b526a9476f40f3830b3daabac7812bbcc) > > Review-Url: https://codereview.chromium.org/2754133002 . > Cr-Commit-Position: refs/branch-heads/3029@{#246} > Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} > Committed: https://chromium.googlesource.com/chromium/src/+/57bfb0bcbbc513726876f0bb55692d168aa662bc TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 701429 Review-Url: https://codereview.chromium.org/2756033002 Cr-Commit-Position: refs/branch-heads/3029@{#248} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/cf7253a19d61e880f964233caec61b4df6fab647/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp [modify] https://crrev.com/cf7253a19d61e880f964233caec61b4df6fab647/third_party/WebKit/Source/modules/vr/NavigatorVR.h [modify] https://crrev.com/cf7253a19d61e880f964233caec61b4df6fab647/third_party/WebKit/Source/modules/vr/VRDisplay.cpp [modify] https://crrev.com/cf7253a19d61e880f964233caec61b4df6fab647/third_party/WebKit/Source/modules/vr/VRDisplay.h
,
Mar 17 2017
Fixed in M59 bust not in M58.
,
Mar 17 2017
Not sure this is really worth trying to land again, given that it's not *that* bad that we send a gesture event on headset insertion. We really just want to make sure pages don't start relying on that. Feel free to re-open if you disagree.
,
Mar 27 2017
,
Jul 4
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by mthiesse@chromium.org
, Mar 14 2017