New issue
Advanced search Search tips

Issue 701414 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 689403

Blocking:
issue 612346


Show other hotlists

Hotlists containing this issue:
WakeLock


Sign in to add a comment

Rationalize WakeLock naming conventions

Project Member Reported by blundell@chromium.org, Mar 14 2017

Issue description

All occurrences of "WakeLockService" should become "WakeLock" (and related ivars, accessors, etc as necessary). In addition, the "Impl" should be dropped from "WakeLockServiceImpl".
 

Comment 1 by dougt@chromium.org, Apr 11 2017

Components: Blink>WakeLock
Owner: juncai@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46

commit 8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46
Author: juncai <juncai@chromium.org>
Date: Tue Jun 06 20:48:18 2017

Rationalize WakeLock naming conventions

This CL makes some changes of the WakeLock naming conventions.
WakeLockService -> WakeLock
Drop the "Impl" from "WakeLockServiceImpl"

BUG= 701414 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2921823002
Cr-Commit-Position: refs/heads/master@{#477400}

[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/chrome/browser/media/cast_transport_host_filter.cc
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/chrome/browser/media/cast_transport_host_filter.h
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/content/browser/download/download_request_core.h
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/content/browser/frame_host/render_frame_host_delegate.cc
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/content/browser/loader/wake_lock_resource_throttle.h
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/content/browser/media/capture/aura_window_capture_machine.h
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/content/browser/media/capture/desktop_capture_device.cc
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/content/browser/media/media_web_contents_observer.cc
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/content/browser/media/media_web_contents_observer.h
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/content/browser/wake_lock/wake_lock_browsertest.cc
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/content/browser/webrtc/webrtc_internals.cc
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/content/browser/webrtc/webrtc_internals.h
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/content/browser/webrtc/webrtc_internals_unittest.cc
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/device/wake_lock/BUILD.gn
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/device/wake_lock/public/interfaces/BUILD.gn
[add] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/device/wake_lock/public/interfaces/wake_lock.mojom
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/device/wake_lock/public/interfaces/wake_lock_context.mojom
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/device/wake_lock/public/interfaces/wake_lock_provider.mojom
[delete] https://crrev.com/3b05369516bd12ef0c06f1646240bf60abe6c28f/device/wake_lock/public/interfaces/wake_lock_service.mojom
[rename] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/device/wake_lock/wake_lock.cc
[rename] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/device/wake_lock/wake_lock.h
[add] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/device/wake_lock/wake_lock_context.cc
[rename] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/device/wake_lock/wake_lock_context.h
[add] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/device/wake_lock/wake_lock_for_testing.cc
[add] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/device/wake_lock/wake_lock_for_testing.h
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/device/wake_lock/wake_lock_provider.cc
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/device/wake_lock/wake_lock_provider.h
[delete] https://crrev.com/3b05369516bd12ef0c06f1646240bf60abe6c28f/device/wake_lock/wake_lock_service_context.cc
[delete] https://crrev.com/3b05369516bd12ef0c06f1646240bf60abe6c28f/device/wake_lock/wake_lock_service_impl_for_testing.cc
[delete] https://crrev.com/3b05369516bd12ef0c06f1646240bf60abe6c28f/device/wake_lock/wake_lock_service_impl_for_testing.h
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/services/device/BUILD.gn
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/services/device/device_service.h
[rename] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/services/device/wake_lock/wake_lock_unittest.cc
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.h
[modify] https://crrev.com/8e8d6ec0bfba48ff738203afe3d2e96d5dac7f46/third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp

Status: Fixed (was: Started)
Components: Internals>Services>Device

Sign in to add a comment