New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 701408 link

Starred by 1 user
Status: Fixed
Owner:
█ shrike@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

MemoryPressureMonitorMac should return cached value in GetCurrentPressureLevel()

Project Member Reported by shrike@chromium.org, Mar 14 2017 
Chrome Version: 

Now that the memory pressure level is checked regularly, there is no need for GetCurrentPressureLevel() to also update the pressure level. This is important because code like GetMaxNumberOfSavedFrames() in renderer_frame_manager.cc can call GetCurrentPressureLevel() very frequently.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f53f979ccc20eac06865022a612910ae510e796c

commit f53f979ccc20eac06865022a612910ae510e796c
Author: shrike <shrike@chromium.org>
Date: Tue Mar 14 23:31:34 2017

[Mac] Return cached pressure level in GetCurrentPressureLevel().

MemoryPressureMonitor clients call GetCurrentPressureLevel(), sometimes
frequently, to get the current memory pressure reading. Up until
recently the cached memory pressure level could be very stale, so we
updated it on every call to GetCurrentPressureLevel(). Now that the
memory pressure level is updated regularly, we can just return the
cached value (and avoid the extra syscalls).

R=lgrey@chromium.org,mark@chromium.org
BUG= 701408 

Review-Url: https://codereview.chromium.org/2743253006
Cr-Commit-Position: refs/heads/master@{#456890}

[modify] https://crrev.com/f53f979ccc20eac06865022a612910ae510e796c/base/memory/memory_pressure_monitor_mac.cc
[modify] https://crrev.com/f53f979ccc20eac06865022a612910ae510e796c/base/memory/memory_pressure_monitor_mac_unittest.cc

Comment 2 by shrike@chromium.org, Mar 14 2017

Status: Fixed (was: Started)
►

Sign in to add a comment