New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701387 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 730000
issue 731694



Sign in to add a comment

Run "net_perftests" on bots and report result to perf dashboard

Project Member Reported by xunji...@chromium.org, Mar 14 2017

Issue description

It seems that net_perftests in net/BUILD.gn is not run anywhere. We should enable it on the perf bots and make the target report results to the perf dashboard.

With regressions like  Issue 700617 , I think we should invest in some perf tests to measure the amount of memory that net/ is using. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81035a93c651f680b1bf0d6c8241128d947d8ac7

commit 81035a93c651f680b1bf0d6c8241128d947d8ac7
Author: eroman <eroman@chromium.org>
Date: Thu Mar 16 01:20:06 2017

Delete proxy_resolver_perftest.cc

There is little value in running this test continuously, as it is not very relevant anymore.

BUG= 701387 

Review-Url: https://codereview.chromium.org/2752713002
Cr-Commit-Position: refs/heads/master@{#457298}

[modify] https://crrev.com/81035a93c651f680b1bf0d6c8241128d947d8ac7/net/BUILD.gn
[delete] https://crrev.com/fe785a58e31217e1ef0e1c8946a4e853829371f8/net/proxy/proxy_resolver_perftest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc6b1d0925c81c56615211252251707a25214a6c

commit cc6b1d0925c81c56615211252251707a25214a6c
Author: xunjieli <xunjieli@chromium.org>
Date: Mon Jun 05 16:51:40 2017

Add url_request_quic_perftest.cc

This CL adds a simple perf test that checks the finish time of running
1000 requests against a HTTP/1.1 server that advertises QUIC support on
an alternative host. This test also checks the end state of //net
MemoryDumpProvider to make sure that there are no leftover
HttpStreamFactoryImpl::Jobs or Quic Jobs.

Follow-up CLs will add more complex tests cases.

BUG= 701387 

Review-Url: https://codereview.chromium.org/2875083002
Cr-Commit-Position: refs/heads/master@{#477001}

[modify] https://crrev.com/cc6b1d0925c81c56615211252251707a25214a6c/net/BUILD.gn
[add] https://crrev.com/cc6b1d0925c81c56615211252251707a25214a6c/net/url_request/url_request_quic_perftest.cc

Blockedon: 730000
Blockedon: 731694
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06a62c12314c7d283c707c1949901665d715b716

commit 06a62c12314c7d283c707c1949901665d715b716
Author: xunjieli <xunjieli@chromium.org>
Date: Fri Jun 09 12:53:58 2017

Renable CookieMonsterTest.TestAddCookieOnManyHosts

With crrev.com/f4721d99f41f62c860b20f1cd53911bdd069d338, this test is fixed.
This CL renables this test.

TBR=mmenke@chromium.org

BUG= 701387 ,  730000 

Review-Url: https://codereview.chromium.org/2930033002
Cr-Commit-Position: refs/heads/master@{#478256}

[modify] https://crrev.com/06a62c12314c7d283c707c1949901665d715b716/net/cookies/cookie_monster_perftest.cc

Status: Fixed (was: Assigned)
Cc: csharrison@chromium.org
 Issue 662165  has been merged into this issue.

Sign in to add a comment