log additional core page information in UKM |
|||||||
Issue descriptionWe should log some additional core page load information in UKM: * page transition type * net error code, for failed provisional loads * time to failed provisional load
,
Mar 15 2017
,
Mar 15 2017
For some reason this bug didn't get updated, but the fix for this landed yesterday: https://codereview.chromium.org/2747173003 https://chromium.googlesource.com/chromium/src/+/bdf4447c2b53c291b12eed74bad3bc0aa3c63eff
,
Mar 15 2017
,
Mar 16 2017
Please add applicable OSs. Thanks.
,
Mar 16 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 16 2017
,
Mar 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5dce6b31d87645a8dd64696b1a4f1b9f9152712 commit d5dce6b31d87645a8dd64696b1a4f1b9f9152712 Author: bmcquade <bmcquade@chromium.org> Date: Fri Mar 17 17:22:56 2017 UKM: log PageTransition and failed provisional load info BUG= 701372 NOTRY=true NOPRESUBMIT=true TBR=bengr Review-Url: https://codereview.chromium.org/2747173003 Cr-Commit-Position: refs/heads/master@{#456863} (cherry picked from commit bdf4447c2b53c291b12eed74bad3bc0aa3c63eff) Review-Url: https://codereview.chromium.org/2754323002 Cr-Commit-Position: refs/branch-heads/3029@{#268} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/d5dce6b31d87645a8dd64696b1a4f1b9f9152712/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc [modify] https://crrev.com/d5dce6b31d87645a8dd64696b1a4f1b9f9152712/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h [modify] https://crrev.com/d5dce6b31d87645a8dd64696b1a4f1b9f9152712/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
,
Mar 17 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bmcquade@chromium.org
, Mar 14 2017