New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701369 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Reading list context menu entries should be limited in size

Project Member Reported by olivierrobin@chromium.org, Mar 14 2017

Issue description

Screenshot included.
 
Screen Shot 2017-03-14 at 15.55.21.png
106 KB View Download
There is one at 50. This is bigger.
Cc: mard...@chromium.org
mardini: This string is 56 characters and the limit is 50. But should we go with "Open offline version in a new tab" (our current string) or something smaller?
I can see with shimi for a shorter string like "Open offline version" (but still opening it in a new tab).
WDYT?
Cc: cma...@chromium.org
I would like the English string to remain "Open offline version in a new tab" and see if we can do something about the translations.
Claude, is there a way to enforce the string length in translation?

Comment 5 by cma...@chromium.org, Mar 27 2017

Sorry I was OOO last week. Yes, you can definitely increase the length of the string and I think in this case, that is what needs to be done.
I am sorry I am not sure we understood each other.
There is a current limitation at 50 characters in the translation instructions. The translation did not respect this limit. I think the right fix is to ask for the translation to respect the limit.
Friendly ping on this bug.
Is there anything we could do to fix this?
Sounds like we should ensure that gambard@'s note in #6 is passed to the translation folks and is enforced. Right?

Comment 9 by cma...@chromium.org, Apr 10 2017

What is the string ID? I will reach out to the translation team regarding the limit and use this string as a use case.
I think it is IDS_IOS_READING_LIST_CONTENT_CONTEXT_OFFLINE
I have reached out the chrome localization team regarding the unit of translated strings. I have asked them whether CHAR-LIMIT should be a better limit to use than "em" which does not seem to work for us. I noticed Android only uses CHAR-LIMIT.
Please confirm this is now fixed!
It respects the char limit (by dropping the articles).
For the new fields, should we use CHAR-LIMIT instead of Length?
Status: Fixed (was: Assigned)

Sign in to add a comment