Reading list context menu entries should be limited in size |
||||
Issue descriptionScreenshot included.
,
Mar 23 2017
mardini: This string is 56 characters and the limit is 50. But should we go with "Open offline version in a new tab" (our current string) or something smaller? I can see with shimi for a shorter string like "Open offline version" (but still opening it in a new tab). WDYT?
,
Mar 23 2017
I would like the English string to remain "Open offline version in a new tab" and see if we can do something about the translations.
,
Mar 23 2017
Claude, is there a way to enforce the string length in translation?
,
Mar 27 2017
Sorry I was OOO last week. Yes, you can definitely increase the length of the string and I think in this case, that is what needs to be done.
,
Mar 29 2017
I am sorry I am not sure we understood each other. There is a current limitation at 50 characters in the translation instructions. The translation did not respect this limit. I think the right fix is to ask for the translation to respect the limit.
,
Apr 10 2017
Friendly ping on this bug. Is there anything we could do to fix this?
,
Apr 10 2017
Sounds like we should ensure that gambard@'s note in #6 is passed to the translation folks and is enforced. Right?
,
Apr 10 2017
What is the string ID? I will reach out to the translation team regarding the limit and use this string as a use case.
,
Apr 10 2017
I think it is IDS_IOS_READING_LIST_CONTENT_CONTEXT_OFFLINE
,
May 12 2017
I have reached out the chrome localization team regarding the unit of translated strings. I have asked them whether CHAR-LIMIT should be a better limit to use than "em" which does not seem to work for us. I noticed Android only uses CHAR-LIMIT.
,
Jun 7 2017
Please confirm this is now fixed!
,
Jun 8 2017
It respects the char limit (by dropping the articles). For the new fields, should we use CHAR-LIMIT instead of Length?
,
Jul 27 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by gambard@chromium.org
, Mar 14 2017