Issue metadata
Sign in to add a comment
|
Page info title is truncated in French |
||||||||||||||||||||||
Issue descriptionSnapshot included
,
Mar 14 2017
The truncation is because Page Info on iOS normally shows a URL there. The security summary and description should go below 1) Are there desktop and mobile mocks? 2) Repo steps plz?
,
Mar 14 2017
* 2) repro steps
,
Mar 14 2017
Repro steps: On iPhone 5S: 1. Add an item to reading list 2. Wait 10 seconds 3. Turn on airplane mode. 4. Visit the page (offline version) 5. Tap on the badge in omnibox.
,
Mar 14 2017
All this in an iPhone set to French language.
,
Mar 22 2017
lgarron suggested to have the URL origin in the title (like for the security page). This would be something like that (must be reworked of course). WDYT?
,
Mar 22 2017
I recommend separate paragraphs to match online pages. -------------------------------- [large, bold URL heading] Offline Page This page has been saved to your reading list. -------------------------------- *Ideally*, we should also be showing cached security information, but that's out of the scope of this bug.
,
Mar 22 2017
Something like this?
,
Mar 22 2017
Yep! The string should only be capitalized at the beginning ("Viewing offline version" – like a sentence, but without a period), but looks good apart from that!
I'd also suggest confirming with maxwalker@ whether "Viewing offline version" is an appropriate substitute for the security summary, since we're slowly expanding the set of those strings at the moment.
Also, what's the source of the "Reload" link? Is it also on Android? Does it replace the "Learn more" string on purpose? I haven't seen mocks, so I don't know much of about the design of this feature.
,
Mar 23 2017
Yes, this is adapted from the Android info. The link in Android is "View online version" but we decided to just say "Reload" as if you are still offline, it will just reload the offline page. Any other opinion on the strings? mardini@, amyroberts@?
,
Mar 23 2017
+ srahim@ who should sign off on the strings + amyroberts who designed this UI I am personally fine with these changes.
,
Mar 23 2017
Ideally, the title would contain the most important info. Is the URL the most important info in this alert? Or is it the fact that the loaded page is the offline version? My guess is the latter, so my recommendation is to keep "Viewing offline version" as the title. I like the suggestion in #7-8 to have separate lines. The URL could be in plain text on the 2nd line. Another riff is: Viewing offline version http://wikipedia.org is saved in your reading list
,
Mar 23 2017
I agree with srahim@ on #12
,
Mar 23 2017
You should match online pages unless maxwalker@ specifically approves an alternative.
,
Mar 24 2017
lgarron@: Shimi makes a good point that the important piece of information here is that it's offline. I also understand the desire for consistency with the other security pop ups while online. But the user is not online. So my preference is to go with: ================= Title: Viewing offline version [URL] This page has been saved to your reading list. Reload ======================== UX folks: Please let us know the outcome of your discussion. Thanks.
,
Mar 25 2017
Hi - Discussed w/Amy to get clarification. We think we should not match the online pages experience because it is also broken in French (and presumably other languages). See attached screenshot. We should fix online pages, too: Title: Secure connection <- highlight the important info [URL] Your information (for example...) is private when it is sent to this site. ... WRT #9 if "Viewing offline version" is an appropriate substitute for the security summary...Max, please confirm, but if user is offline, there is no security info to display, there is only connection info...
,
Mar 27 2017
> I also understand the desire for consistency with the other security pop ups while online. But the user is not online. However, you are showing them a page for a particular URL. On Android, we also show the URL first, although it's better there because we can wrap lines to show the full URL (since the omnibox is usually too small to show all of it). > if user is offline, there is no security info to display, there is only connection info... I believe the plan was to save that information and display it. Is that not the case?
,
Mar 28 2017
>> if user is offline, there is no security info to display, there is only connection info... > I believe the plan was to save that information and display it. Is that not the case? This was a possibility, and may be nice to have. But as Android does not display anything, we decided not to add it at the moment.
,
Mar 30 2017
How can we move forward? Should we put the URL as title or truncate the string?
,
Mar 30 2017
I strongly feel you should put the URL as the first bolded string for consistency, unless you talk to Max and get guidance (and permission) on doing it another way.
,
Mar 30 2017
@maxwalker: Could you please agree with Shimi and Amy on the final decision for the offline case ? My preference is stated in #15 but I'm happy with any outcome. Thank you.
,
Apr 5 2017
Still no consensus on this issue?
,
Apr 5 2017
I think Shimi is out until tomorrow.
,
Apr 7 2017
Max: Could you please comment on the proposal in # 16 ? Thank you.
,
Apr 10 2017
Shimi's proposal (putting the most important info first) sounds good to me. I agree with Lucas that consistency with Android would be nice to have, however ultimately communicating the information in the most effective way seems more important. Regarding URLs and origins: I think for saved pages the URL (including the path) is more useful than showing the origin only. A message like "viewing offline version of nytimes.com" could be misinterpreted. Since the whole URL wouldn't fit in the title line this is another argument for the "Viewing Offline Version" title. WDYT about this? - "Viewing Offline Version" - URL (no scheme, including path, like on Android) - This page is saved to your Reading List.
,
Apr 11 2017
That is fine with me. Thanks, Max.
,
Apr 11 2017
> Since the whole URL wouldn't fit in the title line this is another argument for the "Viewing Offline Version" title. Alright, if Max is fine with it I'm okay with shipping for now. Note that neither the URL nor any other title we put there will not wrap – but I can easily fix that if we want feature parity with Android.
,
Apr 14 2017
Marking this as available since olivierrobin@ is going to be OOO for a bit.
,
Jul 19 2017
,
Nov 10 2017
,
Feb 18 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rohitrao@chromium.org
, Mar 14 2017