New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701315 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug



Sign in to add a comment

crash in shill::ChromeosManagerDBusAdaptor::ConfigureServiceForProfile

Project Member Reported by kotah@chromium.org, Mar 14 2017

Issue description

Chrome Version: 56.0.2924.110 (9000.91.0), 57.0.2987.85 (9202.43.0)

Enterprise customer rentokil-initial.com reported mulitple users start to observe repreated crashes in the past few weeks, both with latest Stable and Beta versions. Issue description by customer:

"The device gradually starts to become less and less responsive to the point where I can no longer move the cursor, after a while screen goes black and reboots. Sometimes I can just be working and then open another tab and the device reboots. Sometimes it happens while at home on my own network and sometimes it happens when i'm at work."

All of recent crash reports show the same stack as  crbug.com/687214#c2  :

Chrome 56.0.2924.110 (9000.91.0)
crash/8f3eb0e2a0000000
crash/9b4e3e6820000000
crash/07323e6820000000
crash/d665da2d80000000

Chrome 57.0.2987.85 (9202.43.0)
crash/9b63012d80000000

0x00007fe525523b82	(libc-2.19.so + 0x00034b82 )	
0x00007fe52626f104	(libbase-core-395517.so -debugger_posix.cc:249 )	base::debug::BreakDebugger()
0x00007fe526286977	(libbase-core-395517.so -logging.cc:755 )	logging::LogMessage::~LogMessage()
0x00007fe526430ef8	(libbrillo-core-395517.so -utils.cc:27 )	brillo::dbus_utils::GetDBusError(dbus::MethodCall*, brillo::Error const*)
0x00007fe526423600	(libbrillo-core-395517.so -dbus_method_response.cc:26 )	brillo::dbus_utils::DBusMethodResponseBase::ReplyWithError(brillo::Error const*)
0x00007fe5265bda5d	(shill -dbus_object_internal_impl.h:165 )	brillo::dbus_utils::SimpleDBusInterfaceMethodHandlerWithError<dbus::ObjectPath const&, std::map<std::string, brillo::Any, std::less<std::string>, std::allocator<std::pair<std::string const, brillo::Any> > > const&, dbus::ObjectPath*>::HandleMethod(dbus::MethodCall*, base::Callback<void (std::unique_ptr<dbus::Response, std::default_delete<dbus::Response> >), (base::internal::CopyMode)1>)::{lambda(dbus::ObjectPath const&, std::map<std::string, brillo::Any, std::less<std::string>, std::allocator<std::pair<std::string const, brillo::Any> > > const&, dbus::ObjectPath* const&)#1}::operator()(dbus::ObjectPath const&, std::map<std::string, brillo::Any, std::less<std::string>, std::allocator<std::pair<std::string const, brillo::Any> > > const&, dbus::ObjectPath* const&) const
0x00007fe5265bd79f	(shill -dbus_param_reader.h:157 )	bool brillo::dbus_utils::DBusParamReader<true>::Invoke<brillo::dbus_utils::SimpleDBusInterfaceMethodHandlerWithError<dbus::ObjectPath const&, std::map<std::string, brillo::Any, std::less<std::string>, std::allocator<std::pair<std::string const, brillo::Any> > > const&, dbus::ObjectPath*>::HandleMethod(dbus::MethodCall*, base::Callback<void (std::unique_ptr<dbus::Response, std::default_delete<dbus::Response> >), (base::internal::CopyMode)1>)::{lambda(dbus::ObjectPath const&, std::map<std::string, brillo::Any, std::less<std::string>, std::allocator<std::pair<std::string const, brillo::Any> > > const&, dbus::ObjectPath* const&)#1}, dbus::ObjectPath, std::map<std::string, brillo::Any, std::less<std::string>, std::allocator<std::pair<std::string const, brillo::Any> > >, dbus::ObjectPath*>(brillo::dbus_utils::SimpleDBusInterfaceMethodHandlerWithError<dbus::ObjectPath const&, std::map<std::string, brillo::Any, std::less<std::string>, std::allocator<std::pair<std::string const, brillo::Any> > > const&, dbus::ObjectPath*>::HandleMethod(dbus::MethodCall*, base::Callback<void (std::unique_ptr<dbus::Response, std::default_delete<dbus::Response> >), (base::internal::CopyMode)1>)::{lambda(dbus::ObjectPath const&, std::map<std::string, brillo::Any, std::less<std::string>, std::allocator<std::pair<std::string const, brillo::Any> > > const&, dbus::ObjectPath* const&)#1} const&, dbus::MessageReader*, std::unique_ptr<brillo::Error, std::default_delete<dbus::MessageReader*> >*, dbus::ObjectPath const&, std::map<std::string, brillo::Any, std::less<std::string>, std::allocator<std::pair<std::string const, brillo::Any> > > const&, dbus::ObjectPath* const&)

 

Comment 1 by kotah@chromium.org, Mar 14 2017

Labels: Restrict-View-Google

Comment 2 by kotah@chromium.org, Mar 14 2017

Owner: dskaram@chromium.org
@dskaram, Can you review and route this bug?
I believe this is on their CN60's which I'm getting similar issues with (slowdown, freezing and then crashing multiple times a day).

Here is my last 2 days:

Crash ID ChromeOS (Server ID: ed9672e480000000)

Crash report uploaded on Tuesday, 14 March 2017 at 13:41:22

Provide additional details.

Crash ID ChromeOS (Server ID: df4d6036a0000000)

Crash report uploaded on Tuesday, 14 March 2017 at 12:29:22

Provide additional details.

Crash ID ChromeOS (Server ID: be034036a0000000)

Crash report uploaded on Tuesday, 14 March 2017 at 12:24:22

Provide additional details.

Crash ID ChromeOS (Server ID: 4dd0a12d80000000)

Crash report uploaded on Tuesday, 14 March 2017 at 12:21:03

Provide additional details.

Crash ID ChromeOS (Server ID: a943212d80000000)

Crash report uploaded on Tuesday, 14 March 2017 at 12:13:06

Provide additional details.

Crash ID ChromeOS (Server ID: 3268f9d6a0000000)

Crash report uploaded on Tuesday, 14 March 2017 at 12:10:46

Provide additional details.

Crash ID ChromeOS (Server ID: 793b26d6a0000000)

Crash report uploaded on Tuesday, 14 March 2017 at 12:02:07

Provide additional details.

Crash ID ChromeOS (Server ID: 8ee60ad6a0000000)

Crash report uploaded on Tuesday, 14 March 2017 at 11:57:13

Provide additional details.

Crash ID ChromeOS (Server ID: 0e64212d80000000)

Crash report uploaded on Tuesday, 14 March 2017 at 11:48:26

Provide additional details.

Crash ID ChromeOS (Server ID: 4b1d8f56a0000000)

Crash report uploaded on Tuesday, 14 March 2017 at 11:41:41

Provide additional details.

Crash ID ChromeOS (Server ID: 84a0d2e480000000)

Crash report uploaded on Tuesday, 14 March 2017 at 11:34:53

Provide additional details.

Crash ID ChromeOS (Server ID: e8c752e480000000)

Crash report uploaded on Tuesday, 14 March 2017 at 11:30:03

Provide additional details.

Crash ID ChromeOS (Server ID: 1019c12d80000000)

Crash report uploaded on Tuesday, 14 March 2017 at 11:21:44

Provide additional details.

Crash ID ChromeOS (Server ID: 6e9df256a0000000)

Crash report uploaded on Tuesday, 14 March 2017 at 11:14:05

Provide additional details.

Crash ID ChromeOS (Server ID: d9b4c12d80000000)

Crash report uploaded on Tuesday, 14 March 2017 at 11:08:39

Provide additional details.

Crash ID ChromeOS (Server ID: 0bdd656820000000)

Crash report uploaded on Tuesday, 14 March 2017 at 11:04:22

Provide additional details.

Crash ID ChromeOS (Server ID: 25deef96a0000000)

Crash report uploaded on Tuesday, 14 March 2017 at 10:57:45

Provide additional details.

Crash ID ChromeOS (Server ID: 157f92e480000000)

Crash report uploaded on Tuesday, 14 March 2017 at 10:49:50

Provide additional details.

Crash ID ChromeOS (Server ID: 934d412d80000000)

Crash report uploaded on Tuesday, 14 March 2017 at 10:40:41

Provide additional details.

Crash ID ChromeOS (Server ID: 6c50656820000000)

Crash report uploaded on Tuesday, 14 March 2017 at 10:34:29

Provide additional details.

Crash ID ChromeOS (Server ID: b72c962d80000000)

Crash report uploaded on Monday, 13 March 2017 at 17:29:09

Provide additional details.

Crash ID ChromeOS (Server ID: 1d20b16820000000)

Crash report uploaded on Monday, 13 March 2017 at 17:23:56

Provide additional details.

Crash ID ChromeOS (Server ID: 2860962d80000000)

Crash report uploaded on Monday, 13 March 2017 at 17:22:58

Provide additional details.

Crash ID ChromeOS (Server ID: ca33162d80000000)

Crash report uploaded on Monday, 13 March 2017 at 17:13:21

Provide additional details.

Crash ID ChromeOS (Server ID: a499162d80000000)

Crash report uploaded on Monday, 13 March 2017 at 17:10:19

Provide additional details.

Crash ID ChromeOS (Server ID: b3c58ce480000000)

Crash report uploaded on Monday, 13 March 2017 at 17:01:57

Provide additional details.

Crash ID ChromeOS (Server ID: 4c4a8ce480000000)

Crash report uploaded on Monday, 13 March 2017 at 16:48:49

Provide additional details.

Crash ID ChromeOS (Server ID: eb248ce480000000)

Crash report uploaded on Monday, 13 March 2017 at 16:45:49

Provide additional details.

Crash ID ChromeOS (Server ID: 066e494aa0000000)

Crash report uploaded on Monday, 13 March 2017 at 16:42:32

Provide additional details.

Crash ID Chrome (Server ID: 6605fab2a0000000)

Crash report uploaded on Monday, 13 March 2017 at 13:20:11

Provide additional details.

Crash ID Chrome (Server ID: 9260e2b2a0000000)

Crash report uploaded on Monday, 13 March 2017 at 13:16:00

Provide additional details.

Crash ID Chrome (Server ID: 1262f0b2a0000000)

Crash report uploaded on Monday, 13 March 2017 at 13:09:21

Provide additional details.

Crash ID Chrome (Server ID: d30dc16820000000)

Crash report uploaded on Monday, 13 March 2017 at 13:07:24

Provide additional details.

Crash ID Chrome (Server ID: 82d707d2a0000000)

Crash report uploaded on Monday, 13 March 2017 at 12:22:05

Provide additional details.

Crash ID Chrome (Server ID: 916123d2a0000000)

Crash report uploaded on Monday, 13 March 2017 at 12:14:39

Provide additional details.

Crash ID ChromeOS (Server ID: 4b3da252a0000000)

Crash report uploaded on Monday, 13 March 2017 at 11:11:28

Provide additional details.

Comment 4 by roy...@google.com, Mar 14 2017

Cc: josa...@chromium.org
Owner: abodenha@chromium.org
Albert this is from a high profile customer. Can you please help us find an engineer to look at this ?

Comment 5 by roy...@google.com, Mar 14 2017

Labels: -Pri-1 Pri-0
Most of these are shill crashes.

Issues in comment #3 appear to be  Bug 686928 
Owner: kirtika@chromium.org
Status: Assigned (was: Unconfirmed)
There are a few shill crash signatures.

For crash/9b63012d80000000, it looks like issue 674823. The location at which shill crashes is shifted and thus generates a new signature. It looks like there is still one error path that shill::Manager::ConfigureServiceForProfile doesn't handle properly.
Spun off cras signatures to  bug 701542 
Cc: kirtika@chromium.org
Owner: benchan@chromium.org
Status: Started (was: Assigned)
Summary: crash in shill::ChromeosManagerDBusAdaptor::ConfigureServiceForProfile (was: Crash: base::debug::BreakDebugger())
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/b2d0677c761fdaa7a6d72b61e8a1833c9d1cb593

commit b2d0677c761fdaa7a6d72b61e8a1833c9d1cb593
Author: Ben Chan <benchan@chromium.org>
Date: Thu Mar 16 21:23:51 2017

shill: populate a missing error in Manager::ConfigureServiceForProfile

When Manager::ConfigureServiceForProfile() creates and configures a
temporary service, it decides not to return the unusable service but
forgets to populate an error, which will eventually trigger a assertion
in ChromeosManagerDBusAdaptor::ConfigureServiceForProfile(). This CL
ensures that Manager::ConfigureServiceForProfile populates an error
under such condition.

BUG= chromium:701315 
TEST=Run unit tests.

Change-Id: Id990de604982cffcc68dff2899ac9859935625bb
Reviewed-on: https://chromium-review.googlesource.com/455256
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>

[modify] https://crrev.com/b2d0677c761fdaa7a6d72b61e8a1833c9d1cb593/manager.cc
[modify] https://crrev.com/b2d0677c761fdaa7a6d72b61e8a1833c9d1cb593/manager_unittest.cc

Status: Fixed (was: Started)
For other crashes, please open separate bugs

Comment 14 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 16 Deleted

Cc: hugobenichi@google.com
Labels: -Restrict-View-Google -Restrict-View-EditIssue
Status: Fixed (was: Archived)

Sign in to add a comment