Issue metadata
Sign in to add a comment
|
Regression: On changing browser language to Hindi, text in autofill overlay is chopped. [Win only?]
Reported by
lpa...@etouch.net,
Mar 14 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 59.0.3041.0 (Official Build) 0192171168e7afc337edc13c150eca4152185cd5-refs/heads/master@{#456562} (32/64-bit) OS: Windows (7,8,10) What steps will reproduce the problem? 1) Launch chrome, from chrome://md-settings change the browser language to Hindi and relaunch browser. 2) Navigate to chrome://md-settings/autofill and observe the text for 'Pin code'. Top side of text is chopped. Top side of text should not be chopped. This is a Regression issue broken in M-59, will soon update other info Manual bisect: Good build: 59.0.3032.0 Bad build: 59.0.3034.0 Note: Issue is not seen on Mac and Linux OS.
,
Mar 15 2017
Narrow Bisect Info: https://chromium.googlesource.com/chromium/src/+log/ebeb36a0ed4b69c72ce8f2c803bf4233d1cea9f1..266c9a16c8af6638fd43307a4aac5df5077f1c88?pretty=fuller&n=10000 Suspecting: r454958 from Narrow Bisect. @xiaochengh: Kindly help to re-assign if your change is not the cause for this issue.
,
Mar 15 2017
r454958 is not relevant. It doesn't introduce any behavior change, but only changes some layout test related files.
,
Mar 15 2017
,
Mar 16 2017
With response to comment #4: Rebisected on a different machine and getting the same Narrow bisect. Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/ebeb36a0ed4b69c72ce8f2c803bf4233d1cea9f1..266c9a16c8af6638fd43307a4aac5df5077f1c88?pretty=fuller&n=10000 Suspecting: r454940
,
Mar 16 2017
,
Mar 16 2017
lpanse@, seems like repro is missing a step - there's no such text on chrome://md-settings/autofill. Should I click on something after getting to that page? Also if you could attach a screenshot of the whole webpage that would be helpful for me to locate the mentioned text.
,
Mar 16 2017
,
Mar 17 2017
With response to comment #7: Correction in steps: In step to after navigating to chrome://md-settings/autofill, click on ADD button under 'Addresses' and observe the Pin code option. Please refer the attached screenshot.
,
Mar 17 2017
I don't have a Windows machine, marking as available for someone else to pick up.
,
Mar 24 2017
Scott points out (in Issue 666186 ) that the two bugs may be related (or dupe, not sure).
,
Mar 24 2017
Taking this on as well to try to repro on Windows.
,
Mar 27 2017
I can confirm that this is a real bug. Removing this style with inspector fixes it: --paper-font-common-nowrap_-_overflow: hidden;
,
Mar 27 2017
Dug deeper. Root cause is the --paper-input-container-label-floating font-size and line-height definitions introduced here: https://codereview.chromium.org/2726113003/diff/40001/chrome/browser/resources/settings/settings_vars_css.html Reverting both these changes fixes it. Also, changing line-height to 1.5rem, for instance, fixes it. Bouncing this bug back to scott as he must have better insight on the purpose of the original changes. Happy to help you test / iterate on whichever new CSS settings you choose. Tommy
,
Apr 3 2017
,
Apr 4 2017
,
Apr 12 2017
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01290e8c82c71cec17fc4c15773aa21d0ee26306 commit 01290e8c82c71cec17fc4c15773aa21d0ee26306 Author: scottchen <scottchen@chromium.org> Date: Thu Apr 13 21:28:25 2017 MD Settings: fix paper-input label line-height BUG= 701284 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2813963003 Cr-Commit-Position: refs/heads/master@{#464550} [modify] https://crrev.com/01290e8c82c71cec17fc4c15773aa21d0ee26306/chrome/browser/resources/settings/settings_vars_css.html
,
Apr 13 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Mar 14 2017Status: Untriaged (was: Unconfirmed)