New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701283 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove AUTOSIZING_DOM_DEBUG_INFO sections

Project Member Reported by yuryu@chromium.org, Mar 14 2017

Issue description

AUTOSIZING_DOM_DEBUG_INFO macro is used within core/layout/TextAutosizer.c, but it doesn't compile when defined, and it seems not used anymore.

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/TextAutosizer.cpp

This code uses deprecated ExecutionContextTask, so we are going to remove the ifdef'd sections entirely.
 

Comment 1 by yuryu@chromium.org, Mar 14 2017

Description: Show this description

Comment 2 by yuryu@chromium.org, Mar 14 2017

Summary: Remove AUTOSIZING_DOM_DEBUG_INFO sections (was: Remove AUTOSIZING_DOM_DEBUG_INFO)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b231885a172263ba6e862e22819a3221140656eb

commit b231885a172263ba6e862e22819a3221140656eb
Author: yuryu <yuryu@chromium.org>
Date: Wed Mar 15 06:25:17 2017

Remove AUTOSIZING_DOM_DEBUG_INFO sections from TextAutosizer

TextAutosizer has AUTOSIZING_DOM_DEBUG_INFO macros to conditionally compile, but it doesn't compile when defined. The macro is not documented or integrated to the build system. It uses deprecated ExecutionContextTask there so this patch removes this conditional macro.

BUG= 625927 , 701283 

Review-Url: https://codereview.chromium.org/2749773002
Cr-Commit-Position: refs/heads/master@{#457012}

[modify] https://crrev.com/b231885a172263ba6e862e22819a3221140656eb/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[modify] https://crrev.com/b231885a172263ba6e862e22819a3221140656eb/third_party/WebKit/Source/core/layout/TextAutosizer.h

Comment 4 by yuryu@chromium.org, Mar 15 2017

Status: Verified (was: Untriaged)

Sign in to add a comment