New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 701282 link

Starred by 0 users
Status: Verified
Owner:
yamaguchi@chromium.org
Closed: Mar 2017
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ durga.behera@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Text on the error window is seen loading slowly in Files.app

Project Member Reported by sandeepkumars@chromium.org, Mar 14 2017 
Chrome Version:  58.0.3029.18/9334.10.0 dev channel Daisy,Candy,Minnie, Jerry
OS: Chrome

What steps will reproduce the problem?
(1) Sign in to user>> go to Files.app>> go to my drive tab>> create one folder>> try to share>> give wrong email I'd in people edit box>> click on send observe

Expected: Text on the error message should not be seen loaded slowly (Refer video)
Actual: Instead Text on the error message is seen loading slowly (Refer video)

This is a Regression issue as issue is not seen in M56: 56.0.2924.110/900.91.0 Stable-Channel Daisy

Issue is not applicable to Linux and Windows

Issue is seen in M59 too
Actual_share.webm
777 KB View Download
Expected_share.webm
1019 KB View Download

Comment 1 by yamaguchi@chromium.org, Mar 14 2017

Status: Started (was: Assigned)
This starts to be visible by the side effect of fixing  Issue 693416 .
https://codereview.chromium.org/2702423002
- before the fix, the dialog would have been blank.
- the fix introduced a bit long delay (200ms at max.) before showing the message. (we can adjust it though)

In addition to it, I found that the overlay window's zoom (resize transition) animation causes flickering of the message because the message is once dragged down and then appears again. This is relatively hard to fix, and it's been happening M55 or even before.

As a short term solution, I will fix this issue by speeding up the animation, as well as reducing the introduced delay.
https://codereview.chromium.org/2748983002/
share-dialog-revised.mp4
193 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d2c054aa276113ab85d0493b58d1f33250df1e0

commit 9d2c054aa276113ab85d0493b58d1f33250df1e0
Author: yamaguchi <yamaguchi@chromium.org>
Date: Wed Mar 29 06:49:56 2017

Make window resizing animation of share dialog faster to mitigate UI glitch.

This is a quick fix for mitigating the slow loading of the error message.

The share dialog will show resizing animation when the inner content
size changes, however, the inner content is not aligned to the container
while transition is ongoing. This change mitigates that bad effect by
shortening the animation time, as well as shortening the delay after
animation finished.

TEST=manually tested as noted in the bug.
BUG= 701282 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2748983002
Cr-Commit-Position: refs/heads/master@{#460305}

[modify] https://crrev.com/9d2c054aa276113ab85d0493b58d1f33250df1e0/ui/file_manager/file_manager/foreground/css/share_dialog.css
[modify] https://crrev.com/9d2c054aa276113ab85d0493b58d1f33250df1e0/ui/file_manager/file_manager/foreground/js/ui/share_dialog.js

Comment 3 by yamaguchi@chromium.org, Mar 30 2017

Status: Fixed (was: Started)

Comment 4 by rookrishna@chromium.org, Apr 7 2017

Status: Verified (was: Fixed)
Verified on  9438.0.0/ 59.0.3064.0 Caroline
►

Sign in to add a comment