For now base::BindBlock only supports a copy semantics for its arguments. base::Bind supports a move semantics, allowing the elements to be moved instead of copied. base::BindBlock should have the features.
Feel free to assign it to someone else or mark it available.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a2babeb82b88d78f4c47efac8078496ab50fbc3 commit 3a2babeb82b88d78f4c47efac8078496ab50fbc3 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue May 22 16:19:46 2018 Add supports for Objective-C blocks to base::Bind* Add template specifialization allowing to use base::Bind* with Objective-C block. To avoid breaking ODR, it is necessary to use base::WrapBlock() when ARC support is disabled, but when it is enabled, the block can be directly bound by base::Bind*. This also allow to use base::BindOnce() with blocks and thus pass them move-only objects, allowing the following: __weak Foo* weakSelf = self; std::unique_ptr<Bar> bar = ...; base::OnceClosure closure = base::BindOnce( ^(std::unique_ptr<Bar> bar) { [weakSelf adoptBar:std::move(bar)]; }, std::move(bar)); The base::BindBlock and base::BindBlockArc templates are kept for compatibility but are now just wrapper for base::BindRepeating. Bug: 701275 Change-Id: I6e5d5309bcae768b2d1e8425b27ca295098e30b1 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/977912 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#560634} [modify] https://crrev.com/3a2babeb82b88d78f4c47efac8078496ab50fbc3/base/bind.h [modify] https://crrev.com/3a2babeb82b88d78f4c47efac8078496ab50fbc3/base/bind_internal.h [modify] https://crrev.com/3a2babeb82b88d78f4c47efac8078496ab50fbc3/base/mac/bind_objc_block.h [modify] https://crrev.com/3a2babeb82b88d78f4c47efac8078496ab50fbc3/base/mac/bind_objc_block_unittest.mm [modify] https://crrev.com/3a2babeb82b88d78f4c47efac8078496ab50fbc3/base/mac/bind_objc_block_unittest_arc.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b1b5aece9caaaf35614c15082e1753ffefac96e commit 1b1b5aece9caaaf35614c15082e1753ffefac96e Author: Yuta Kitamura <yutak@chromium.org> Date: Wed May 23 05:23:59 2018 Revert "Add supports for Objective-C blocks to base::Bind*" This reverts commit 3a2babeb82b88d78f4c47efac8078496ab50fbc3. Reason for revert: Suspected cause of ASAN failure ( bug 845687 ) and Mac-only flakiness ( bug 845760 , but 845759, bug 845690 ). Original change's description: > Add supports for Objective-C blocks to base::Bind* > > Add template specifialization allowing to use base::Bind* with > Objective-C block. To avoid breaking ODR, it is necessary to > use base::WrapBlock() when ARC support is disabled, but when > it is enabled, the block can be directly bound by base::Bind*. > > This also allow to use base::BindOnce() with blocks and thus > pass them move-only objects, allowing the following: > > __weak Foo* weakSelf = self; > std::unique_ptr<Bar> bar = ...; > base::OnceClosure closure = base::BindOnce( > ^(std::unique_ptr<Bar> bar) { > [weakSelf adoptBar:std::move(bar)]; > }, std::move(bar)); > > The base::BindBlock and base::BindBlockArc templates are kept for > compatibility but are now just wrapper for base::BindRepeating. > > Bug: 701275 > Change-Id: I6e5d5309bcae768b2d1e8425b27ca295098e30b1 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Reviewed-on: https://chromium-review.googlesource.com/977912 > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Taiju Tsuiki <tzik@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560634} TBR=thakis@chromium.org,sdefresne@chromium.org,tzik@chromium.org Change-Id: Id72a1806176f830a1887243fcd2795a927e7d638 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 701275 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1068588 Reviewed-by: Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#560951} [modify] https://crrev.com/1b1b5aece9caaaf35614c15082e1753ffefac96e/base/bind.h [modify] https://crrev.com/1b1b5aece9caaaf35614c15082e1753ffefac96e/base/bind_internal.h [modify] https://crrev.com/1b1b5aece9caaaf35614c15082e1753ffefac96e/base/mac/bind_objc_block.h [modify] https://crrev.com/1b1b5aece9caaaf35614c15082e1753ffefac96e/base/mac/bind_objc_block_unittest.mm [modify] https://crrev.com/1b1b5aece9caaaf35614c15082e1753ffefac96e/base/mac/bind_objc_block_unittest_arc.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec3270cd3b8ca114c1ced98446ab915d6c1e59e4 commit ec3270cd3b8ca114c1ced98446ab915d6c1e59e4 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu May 31 17:19:15 2018 Add supports for Objective-C blocks to base::Bind* Add template specifialization allowing to use base::Bind* with Objective-C block. To avoid breaking ODR, it is necessary to use base::WrapBlock() when ARC support is disabled, but when it is enabled, the block can be directly bound by base::Bind*. This also allow to use base::BindOnce() with blocks and thus pass them move-only objects, allowing the following: __weak Foo* weakSelf = self; std::unique_ptr<Bar> bar = ...; base::OnceClosure closure = base::BindOnce( ^(std::unique_ptr<Bar> bar) { [weakSelf adoptBar:std::move(bar)]; }, std::move(bar)); The base::BindBlock and base::BindBlockArc templates are kept for compatibility but are now just wrapper for base::BindRepeating. This is a reland of http://crrev.com/c/977912 with a change to fix the ASan failure. The failure were due to the Objective-C block being deallocated as soon as the base::RepeatingCallback<> was destroyed. However some code path destroy the callback while the block executes, leading to use-after-free error (resulting in undefined behaviour, caught by ASan). The fix is to explicitly copy the block to a local variable with a known lifetime to ensure the Objective-C block is not deallocated until the block execution is complete. Bug: 701275 Change-Id: I2ce65f86d8eb3939005ff19c18b679b69e83f6ec Reviewed-on: https://chromium-review.googlesource.com/1070158 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#563292} [modify] https://crrev.com/ec3270cd3b8ca114c1ced98446ab915d6c1e59e4/base/bind.h [modify] https://crrev.com/ec3270cd3b8ca114c1ced98446ab915d6c1e59e4/base/bind_internal.h [modify] https://crrev.com/ec3270cd3b8ca114c1ced98446ab915d6c1e59e4/base/mac/bind_objc_block.h [modify] https://crrev.com/ec3270cd3b8ca114c1ced98446ab915d6c1e59e4/base/mac/bind_objc_block_unittest.mm [modify] https://crrev.com/ec3270cd3b8ca114c1ced98446ab915d6c1e59e4/base/mac/bind_objc_block_unittest_arc.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/bfd31f68a8813e84d0680ff85755a8e40ae44936 commit bfd31f68a8813e84d0680ff85755a8e40ae44936 Author: Sylvain Defresne <sdefresne@google.com> Date: Fri Jun 01 15:24:35 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4fd561aca262ba8d61f0a5351aa5dc54fd64a72 commit b4fd561aca262ba8d61f0a5351aa5dc54fd64a72 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Jun 04 17:28:23 2018 Remove obsolete helper BindWrapper. The helper function BindWrapper was an adaptor to use BindBlock() for a block taking a moveable object when BindBlock() did not support move semantic. Since move semantic is now supported with base::Bind() support for blocks, the wrapper is no longer necessary and can be removed by using base::Bind() directly. Bug: 701275 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I919f670a9bb2c193866ed62e823a09aad4bbd28e Reviewed-on: https://chromium-review.googlesource.com/1084483 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#564136} [modify] https://crrev.com/b4fd561aca262ba8d61f0a5351aa5dc54fd64a72/ios/chrome/browser/ui/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/b4fd561aca262ba8d61f0a5351aa5dc54fd64a72/ios/chrome/browser/ui/content_suggestions/mediator_util.h [modify] https://crrev.com/b4fd561aca262ba8d61f0a5351aa5dc54fd64a72/ios/chrome/browser/ui/content_suggestions/mediator_util.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba054928d72a33c7693fc26f3bd01b5add5a0226 commit ba054928d72a33c7693fc26f3bd01b5add5a0226 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Jun 05 09:46:15 2018 Convert SnapshotCallback to a base::OnceCallback. As base::BindOnce() accepts block, it is possible to convert SnapshotCallback to be a base::OnceCallback<>. This has better semantic and give clearer information on the lifetime of the bound objects. Bug: 701275 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia4f432f56271a666f407e1d3e173b6d0362fc511 Reviewed-on: https://chromium-review.googlesource.com/1084488 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#564424} [modify] https://crrev.com/ba054928d72a33c7693fc26f3bd01b5add5a0226/ios/web/public/test/fakes/test_web_state.h [modify] https://crrev.com/ba054928d72a33c7693fc26f3bd01b5add5a0226/ios/web/public/test/fakes/test_web_state.mm [modify] https://crrev.com/ba054928d72a33c7693fc26f3bd01b5add5a0226/ios/web/public/web_state/web_state.h [modify] https://crrev.com/ba054928d72a33c7693fc26f3bd01b5add5a0226/ios/web/web_state/web_state_impl.h [modify] https://crrev.com/ba054928d72a33c7693fc26f3bd01b5add5a0226/ios/web/web_state/web_state_impl.mm [modify] https://crrev.com/ba054928d72a33c7693fc26f3bd01b5add5a0226/ios/web/web_state/web_state_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0dca2c3c5856698dce482a1733ef68beb44f74b2 commit 0dca2c3c5856698dce482a1733ef68beb44f74b2 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Jun 05 10:13:33 2018 Convert DialogClosedCallback to a base::OnceCallback As base::BindOnce() accepts block, it is possible to convert DialogClosedCallback to be a base::OnceCallback<>. This has better semantic and give clearer information on the lifetime of the bound objects. Bug: 701275 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ifa5535ee538d02c89a528a4336d5fb93a7d821f0 Reviewed-on: https://chromium-review.googlesource.com/1084598 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#564432} [modify] https://crrev.com/0dca2c3c5856698dce482a1733ef68beb44f74b2/ios/chrome/browser/ui/dialogs/java_script_dialog_presenter_impl.h [modify] https://crrev.com/0dca2c3c5856698dce482a1733ef68beb44f74b2/ios/chrome/browser/ui/dialogs/java_script_dialog_presenter_impl.mm [modify] https://crrev.com/0dca2c3c5856698dce482a1733ef68beb44f74b2/ios/web/public/java_script_dialog_callback.h [modify] https://crrev.com/0dca2c3c5856698dce482a1733ef68beb44f74b2/ios/web/public/java_script_dialog_presenter.h [modify] https://crrev.com/0dca2c3c5856698dce482a1733ef68beb44f74b2/ios/web/public/test/fakes/test_java_script_dialog_presenter.h [modify] https://crrev.com/0dca2c3c5856698dce482a1733ef68beb44f74b2/ios/web/public/test/fakes/test_java_script_dialog_presenter.mm [modify] https://crrev.com/0dca2c3c5856698dce482a1733ef68beb44f74b2/ios/web/web_state/web_state_impl.h [modify] https://crrev.com/0dca2c3c5856698dce482a1733ef68beb44f74b2/ios/web/web_state/web_state_impl.mm [modify] https://crrev.com/0dca2c3c5856698dce482a1733ef68beb44f74b2/ios/web_view/internal/web_view_java_script_dialog_presenter.h [modify] https://crrev.com/0dca2c3c5856698dce482a1733ef68beb44f74b2/ios/web_view/internal/web_view_java_script_dialog_presenter.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ff26c9534477e8f985be1dbf1118ef94489f046 commit 0ff26c9534477e8f985be1dbf1118ef94489f046 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Jun 05 11:29:35 2018 Convert ShowRepostFormWarningDialog parameter to OnceCallback As base::BindOnce() accepts block, it is possible to convert ShowRepostFormWarningDialog parameter to be a OnceCallback<>. This has better semantic and give clearer information on the lifetime of the bound objects. Bug: 701275 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8cdd09b1eb530a1dbb3ed59461102538c961dd81 Reviewed-on: https://chromium-review.googlesource.com/1084929 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#564444} [modify] https://crrev.com/0ff26c9534477e8f985be1dbf1118ef94489f046/ios/web/public/test/fakes/test_web_state_delegate.h [modify] https://crrev.com/0ff26c9534477e8f985be1dbf1118ef94489f046/ios/web/public/test/fakes/test_web_state_delegate.mm [modify] https://crrev.com/0ff26c9534477e8f985be1dbf1118ef94489f046/ios/web/public/web_state/web_state_delegate.h [modify] https://crrev.com/0ff26c9534477e8f985be1dbf1118ef94489f046/ios/web/public/web_state/web_state_delegate_bridge.h [modify] https://crrev.com/0ff26c9534477e8f985be1dbf1118ef94489f046/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/0ff26c9534477e8f985be1dbf1118ef94489f046/ios/web/web_state/web_state_delegate.mm [modify] https://crrev.com/0ff26c9534477e8f985be1dbf1118ef94489f046/ios/web/web_state/web_state_delegate_bridge.mm [modify] https://crrev.com/0ff26c9534477e8f985be1dbf1118ef94489f046/ios/web/web_state/web_state_delegate_bridge_unittest.mm [modify] https://crrev.com/0ff26c9534477e8f985be1dbf1118ef94489f046/ios/web/web_state/web_state_impl.h [modify] https://crrev.com/0ff26c9534477e8f985be1dbf1118ef94489f046/ios/web/web_state/web_state_impl.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6165e134682b13c8ccb148482b149affce6696ee commit 6165e134682b13c8ccb148482b149affce6696ee Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Jun 05 11:35:46 2018 Convert PresentDialog parameter to OnceCallback As base::BindOnce() accepts block, it is possible to convert PresentDialog parameter to be a OnceCallback<>. This has better semantic and give clearer information on the lifetime of the bound objects. Bug: 701275 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I43b47a2982a2ac1501eb665adaf20343f6bcc8ff Reviewed-on: https://chromium-review.googlesource.com/1085297 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#564447} [modify] https://crrev.com/6165e134682b13c8ccb148482b149affce6696ee/ios/chrome/browser/web/repost_form_tab_helper.h [modify] https://crrev.com/6165e134682b13c8ccb148482b149affce6696ee/ios/chrome/browser/web/repost_form_tab_helper.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7b24f68d71c89d3678542aaa5d37eab16549b22 commit f7b24f68d71c89d3678542aaa5d37eab16549b22 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Jun 05 11:39:35 2018 Convert SSL error pages' callbacks to OnceCallback As base::BindOnce() accepts block, it is possible to convert SSL error pages' callbacks to be a OnceCallback<>. This has better semantic and give clearer information on the lifetime of the bound objects. Bug: 701275 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7c57e1d78065b76f7d80e52492394652fe4f61dc Reviewed-on: https://chromium-review.googlesource.com/1085300 Reviewed-by: Emily Stark <estark@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#564449} [modify] https://crrev.com/f7b24f68d71c89d3678542aaa5d37eab16549b22/ios/chrome/browser/ssl/ios_captive_portal_blocking_page.h [modify] https://crrev.com/f7b24f68d71c89d3678542aaa5d37eab16549b22/ios/chrome/browser/ssl/ios_captive_portal_blocking_page.mm [modify] https://crrev.com/f7b24f68d71c89d3678542aaa5d37eab16549b22/ios/chrome/browser/ssl/ios_ssl_blocking_page.h [modify] https://crrev.com/f7b24f68d71c89d3678542aaa5d37eab16549b22/ios/chrome/browser/ssl/ios_ssl_blocking_page.mm [modify] https://crrev.com/f7b24f68d71c89d3678542aaa5d37eab16549b22/ios/chrome/browser/ssl/ios_ssl_error_handler.h [modify] https://crrev.com/f7b24f68d71c89d3678542aaa5d37eab16549b22/ios/chrome/browser/ssl/ios_ssl_error_handler.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7f6eb0e856cc997f76318d44b3433c1295df626 commit d7f6eb0e856cc997f76318d44b3433c1295df626 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Jun 05 11:51:40 2018 Convert ios/chrome/app to use Bind() for blocks With https://crrev.com/c/1070158, base::Bind() supports block so convert uses of base::BindBlockArc() to instead use base::BindOnce() or base::BindRepeating(). Bug: 701275 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I663f6ba5d9c5cd6ab60c6c8ae19f3fcce68c9aed Reviewed-on: https://chromium-review.googlesource.com/1085458 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#564452} [modify] https://crrev.com/d7f6eb0e856cc997f76318d44b3433c1295df626/ios/chrome/app/application_delegate/app_state.mm [modify] https://crrev.com/d7f6eb0e856cc997f76318d44b3433c1295df626/ios/chrome/app/application_delegate/metrics_mediator.mm [modify] https://crrev.com/d7f6eb0e856cc997f76318d44b3433c1295df626/ios/chrome/app/main_controller.mm [modify] https://crrev.com/d7f6eb0e856cc997f76318d44b3433c1295df626/ios/chrome/app/spotlight/base_spotlight_manager.mm [modify] https://crrev.com/d7f6eb0e856cc997f76318d44b3433c1295df626/ios/chrome/app/startup_tasks.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9df11d0131f69cf08654fa0b2e5513e46b499e8c commit 9df11d0131f69cf08654fa0b2e5513e46b499e8c Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Jun 05 11:52:13 2018 Convert ios/chrome/test to use Bind() for blocks With https://crrev.com/c/1070158, base::Bind() supports block so convert uses of base::BindBlockArc() to instead use base::BindOnce() or base::BindRepeating(). Bug: 701275 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibdc8196a03024b81202a009c4cd9c8df621739a9 Reviewed-on: https://chromium-review.googlesource.com/1085456 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#564453} [modify] https://crrev.com/9df11d0131f69cf08654fa0b2e5513e46b499e8c/ios/chrome/test/app/sync_test_util.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/231846082b861b035e6921dfef54384a566189e4 commit 231846082b861b035e6921dfef54384a566189e4 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Jun 05 11:53:00 2018 Convert ios/web_view to use Bind() for blocks With https://crrev.com/c/1070158, base::Bind() supports block so convert uses of base::BindBlockArc() to instead use base::BindOnce() or base::BindRepeating(). Bug: 701275 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I23f23d7dc5f54d41ebff9ed8e2d7f77e3d01854b Reviewed-on: https://chromium-review.googlesource.com/1085452 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#564454} [modify] https://crrev.com/231846082b861b035e6921dfef54384a566189e4/ios/web_view/internal/autofill/cwv_autofill_data_manager.mm [modify] https://crrev.com/231846082b861b035e6921dfef54384a566189e4/ios/web_view/internal/autofill/cwv_credit_card_verifier_unittest.mm [modify] https://crrev.com/231846082b861b035e6921dfef54384a566189e4/ios/web_view/internal/cwv_web_view.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f316f573f188c3adc98651c4c83a2d07af3b179 commit 3f316f573f188c3adc98651c4c83a2d07af3b179 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Jun 05 13:04:42 2018 Convert ios/web to use Bind() for blocks With https://crrev.com/c/1070158, base::Bind() supports block so convert uses of base::BindBlockArc() to instead use base::BindOnce() or base::BindRepeating(). Bug: 701275 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2be111f993f8ec35468a2bebd6ff7666cbfd0b90 Reviewed-on: https://chromium-review.googlesource.com/1085453 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#564468} [modify] https://crrev.com/3f316f573f188c3adc98651c4c83a2d07af3b179/ios/web/download/download_task_impl.mm [modify] https://crrev.com/3f316f573f188c3adc98651c4c83a2d07af3b179/ios/web/download/download_task_impl_unittest.mm [modify] https://crrev.com/3f316f573f188c3adc98651c4c83a2d07af3b179/ios/web/net/cookies/system_cookie_store_util_unittest.mm [modify] https://crrev.com/3f316f573f188c3adc98651c4c83a2d07af3b179/ios/web/net/cookies/wk_http_system_cookie_store.mm [modify] https://crrev.com/3f316f573f188c3adc98651c4c83a2d07af3b179/ios/web/net/crw_cert_verification_controller.mm [modify] https://crrev.com/3f316f573f188c3adc98651c4c83a2d07af3b179/ios/web/net/request_tracker_impl.mm [modify] https://crrev.com/3f316f573f188c3adc98651c4c83a2d07af3b179/ios/web/public/test/earl_grey/web_view_actions.mm [modify] https://crrev.com/3f316f573f188c3adc98651c4c83a2d07af3b179/ios/web/public/test/web_view_interaction_test_util.mm [modify] https://crrev.com/3f316f573f188c3adc98651c4c83a2d07af3b179/ios/web/web_state/session_certificate_policy_cache_impl.mm [modify] https://crrev.com/3f316f573f188c3adc98651c4c83a2d07af3b179/ios/web/web_state/session_certificate_policy_cache_impl_unittest.mm [modify] https://crrev.com/3f316f573f188c3adc98651c4c83a2d07af3b179/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/3f316f573f188c3adc98651c4c83a2d07af3b179/ios/web/web_state/ui/web_view_js_utils_unittest.mm [modify] https://crrev.com/3f316f573f188c3adc98651c4c83a2d07af3b179/ios/web/web_state/web_state_impl_unittest.mm [modify] https://crrev.com/3f316f573f188c3adc98651c4c83a2d07af3b179/ios/web/web_state/web_state_unittest.mm [modify] https://crrev.com/3f316f573f188c3adc98651c4c83a2d07af3b179/ios/web/webui/crw_web_ui_manager.mm [modify] https://crrev.com/3f316f573f188c3adc98651c4c83a2d07af3b179/ios/web/webui/mojo_facade.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7963dca6a9903ab439c89d102463b0268c5997e commit b7963dca6a9903ab439c89d102463b0268c5997e Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Jun 05 13:05:14 2018 Convert ios/chrome/browser/ui to use Bind() for blocks With https://crrev.com/c/1070158, base::Bind() supports block so convert uses of base::BindBlockArc() to instead use base::BindOnce() or base::BindRepeating(). Bug: 701275 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I419c6a457d174ef21131cbfe30fd7b7b1d6a8dd6 Reviewed-on: https://chromium-review.googlesource.com/1085455 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#564469} [modify] https://crrev.com/b7963dca6a9903ab439c89d102463b0268c5997e/ios/chrome/browser/ui/activity_services/canonical_url_retriever.mm [modify] https://crrev.com/b7963dca6a9903ab439c89d102463b0268c5997e/ios/chrome/browser/ui/authentication/authentication_flow_performer.mm [modify] https://crrev.com/b7963dca6a9903ab439c89d102463b0268c5997e/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm [modify] https://crrev.com/b7963dca6a9903ab439c89d102463b0268c5997e/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm [modify] https://crrev.com/b7963dca6a9903ab439c89d102463b0268c5997e/ios/chrome/browser/ui/browser_list/browser_list_session_service_impl.mm [modify] https://crrev.com/b7963dca6a9903ab439c89d102463b0268c5997e/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/b7963dca6a9903ab439c89d102463b0268c5997e/ios/chrome/browser/ui/bubble/bubble_presenter.mm [modify] https://crrev.com/b7963dca6a9903ab439c89d102463b0268c5997e/ios/chrome/browser/ui/content_suggestions/content_suggestions_favicon_mediator.mm [modify] https://crrev.com/b7963dca6a9903ab439c89d102463b0268c5997e/ios/chrome/browser/ui/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/b7963dca6a9903ab439c89d102463b0268c5997e/ios/chrome/browser/ui/contextual_search/contextual_search_controller.mm [modify] https://crrev.com/b7963dca6a9903ab439c89d102463b0268c5997e/ios/chrome/browser/ui/download/legacy_download_manager_controller.mm [modify] https://crrev.com/b7963dca6a9903ab439c89d102463b0268c5997e/ios/chrome/browser/ui/external_file_remover_impl.mm [modify] https://crrev.com/b7963dca6a9903ab439c89d102463b0268c5997e/ios/chrome/browser/ui/favicon/favicon_attributes_provider.mm [modify] https://crrev.com/b7963dca6a9903ab439c89d102463b0268c5997e/ios/chrome/browser/ui/fullscreen/fullscreen_egtest.mm [modify] https://crrev.com/b7963dca6a9903ab439c89d102463b0268c5997e/ios/chrome/browser/ui/history/favicon_view_provider.mm [modify] https://crrev.com/b7963dca6a9903ab439c89d102463b0268c5997e/ios/chrome/browser/ui/image_util/image_saver.mm [modify] https://crrev.com/b7963dca6a9903ab439c89d102463b0268c5997e/ios/chrome/browser/ui/ntp/ntp_tile_saver.mm [modify] https://crrev.com/b7963dca6a9903ab439c89d102463b0268c5997e/ios/chrome/browser/ui/open_in_controller.mm [modify] https://crrev.com/b7963dca6a9903ab439c89d102463b0268c5997e/ios/chrome/browser/ui/payments/payment_request_manager.mm [modify] https://crrev.com/b7963dca6a9903ab439c89d102463b0268c5997e/ios/chrome/browser/ui/print/print_controller.mm [modify] https://crrev.com/b7963dca6a9903ab439c89d102463b0268c5997e/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm [modify] https://crrev.com/b7963dca6a9903ab439c89d102463b0268c5997e/ios/chrome/browser/ui/settings/password_exporter.mm [modify] https://crrev.com/b7963dca6a9903ab439c89d102463b0268c5997e/ios/chrome/browser/ui/settings/settings_egtest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/482af64532b567efff42e13bb0dc46bc4181f00e commit 482af64532b567efff42e13bb0dc46bc4181f00e Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Jun 05 15:05:27 2018 Convert ios/chrome/browser to use Bind() for blocks With https://crrev.com/c/1070158, base::Bind() supports block so convert uses of base::BindBlockArc() to instead use base::BindOnce() or base::BindRepeating(). This converts everyting in ios/chrome/browser, except for ios/chrome/browser/ui that is taken care of in parent CL http://crrev.com/1085455. Bug: 701275 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5543c217a67900d39c7fd17caadb15d6bb1d79b3 Reviewed-on: https://chromium-review.googlesource.com/1085459 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#564501} [modify] https://crrev.com/482af64532b567efff42e13bb0dc46bc4181f00e/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm [modify] https://crrev.com/482af64532b567efff42e13bb0dc46bc4181f00e/ios/chrome/browser/browsing_data/browsing_data_remover_impl_unittest.mm [modify] https://crrev.com/482af64532b567efff42e13bb0dc46bc4181f00e/ios/chrome/browser/favicon/favicon_loader.mm [modify] https://crrev.com/482af64532b567efff42e13bb0dc46bc4181f00e/ios/chrome/browser/memory/memory_debugger_manager.mm [modify] https://crrev.com/482af64532b567efff42e13bb0dc46bc4181f00e/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm [modify] https://crrev.com/482af64532b567efff42e13bb0dc46bc4181f00e/ios/chrome/browser/net/cookie_util.mm [modify] https://crrev.com/482af64532b567efff42e13bb0dc46bc4181f00e/ios/chrome/browser/net/cookie_util_unittest.mm [modify] https://crrev.com/482af64532b567efff42e13bb0dc46bc4181f00e/ios/chrome/browser/passwords/notify_auto_signin_view_controller.mm [modify] https://crrev.com/482af64532b567efff42e13bb0dc46bc4181f00e/ios/chrome/browser/passwords/password_controller.mm [modify] https://crrev.com/482af64532b567efff42e13bb0dc46bc4181f00e/ios/chrome/browser/sessions/session_service_ios.mm [modify] https://crrev.com/482af64532b567efff42e13bb0dc46bc4181f00e/ios/chrome/browser/share_extension/share_extension_item_receiver.mm [modify] https://crrev.com/482af64532b567efff42e13bb0dc46bc4181f00e/ios/chrome/browser/snapshots/snapshot_cache.mm [modify] https://crrev.com/482af64532b567efff42e13bb0dc46bc4181f00e/ios/chrome/browser/ssl/ios_captive_portal_blocking_page_unittest.mm [modify] https://crrev.com/482af64532b567efff42e13bb0dc46bc4181f00e/ios/chrome/browser/ssl/ios_ssl_error_handler.mm [modify] https://crrev.com/482af64532b567efff42e13bb0dc46bc4181f00e/ios/chrome/browser/ssl/ios_ssl_error_handler_unittest.mm [modify] https://crrev.com/482af64532b567efff42e13bb0dc46bc4181f00e/ios/chrome/browser/translate/translate_egtest.mm [modify] https://crrev.com/482af64532b567efff42e13bb0dc46bc4181f00e/ios/chrome/browser/web/repost_form_tab_helper_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a44edf4e436fe52869fd305f2d6e2c34cb12f093 commit a44edf4e436fe52869fd305f2d6e2c34cb12f093 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Jun 05 15:08:34 2018 Convert ios/net to use Bind() for blocks With https://crrev.com/c/1070158, base::Bind() supports block so convert uses of base::BindBlockArc() to instead use base::BindOnce() or base::BindRepeating(). Bug: 701275 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic2c1504b97f090a2bd9e55f33e454e7a2b2428e3 Reviewed-on: https://chromium-review.googlesource.com/1085454 Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#564502} [modify] https://crrev.com/a44edf4e436fe52869fd305f2d6e2c34cb12f093/ios/net/cookies/cookie_store_ios.mm [modify] https://crrev.com/a44edf4e436fe52869fd305f2d6e2c34cb12f093/ios/net/cookies/cookie_store_ios_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d298d152ba803a2b23c11d4e49d517f09e1f128 commit 0d298d152ba803a2b23c11d4e49d517f09e1f128 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Jun 06 09:23:33 2018 Convert remoting/ios to use Bind() for blocks With https://crrev.com/c/1070158, base::Bind() supports block so convert uses of base::BindBlockArc() to instead use base::BindOnce() or base::BindRepeating(). Bug: 701275 Change-Id: Ib251d93328858adfee6ccaddafebaa91124a8a24 Reviewed-on: https://chromium-review.googlesource.com/1087060 Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#564833} [modify] https://crrev.com/0d298d152ba803a2b23c11d4e49d517f09e1f128/remoting/ios/app/remoting_view_controller.mm [modify] https://crrev.com/0d298d152ba803a2b23c11d4e49d517f09e1f128/remoting/ios/display/gl_display_handler.mm [modify] https://crrev.com/0d298d152ba803a2b23c11d4e49d517f09e1f128/remoting/ios/facade/remoting_oauth_authentication.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aeeda219fdf76b02c77d1627d75ffd66e8150eca commit aeeda219fdf76b02c77d1627d75ffd66e8150eca Author: Javier Ernesto Flores Robles <javierrobles@google.com> Date: Wed Jun 06 10:20:31 2018 Change BindOnce to BindRepeating to fix iOS Chrome Build Initial change done in crrev.com/c/1085458 OmahaService takes a repeating callback as parameter. Bug: 701275 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic2e1729b80ca13fca4650384f958f2b4aa83f58c Reviewed-on: https://chromium-review.googlesource.com/1088610 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#564845} [modify] https://crrev.com/aeeda219fdf76b02c77d1627d75ffd66e8150eca/ios/chrome/app/startup_tasks.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7052b23c75fa7cebab3ba13bcc6f83f39c53f40a commit 7052b23c75fa7cebab3ba13bcc6f83f39c53f40a Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Jun 06 13:17:56 2018 Convert components/image_fetcher to use Bind() for blocks With https://crrev.com/c/1070158, base::Bind() supports block so convert uses of base::BindBlockArc() to instead use base::BindOnce() or base::BindRepeating(). Bug: 701275 Change-Id: I0a10526bd47c8c52b2cfc980bdc9d43e4883c18e Reviewed-on: https://chromium-review.googlesource.com/1087061 Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#564869} [modify] https://crrev.com/7052b23c75fa7cebab3ba13bcc6f83f39c53f40a/components/image_fetcher/ios/ios_image_data_fetcher_wrapper.mm [modify] https://crrev.com/7052b23c75fa7cebab3ba13bcc6f83f39c53f40a/components/image_fetcher/ios/ios_image_decoder_impl.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/928501938ec5605118d4338f9c9addfa215e9df9 commit 928501938ec5605118d4338f9c9addfa215e9df9 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Jun 07 13:34:08 2018 Convert components/autofill to use Bind() for blocks With https://crrev.com/c/1070158, base::Bind() supports block so convert uses of base::BindBlockArc() to instead use base::BindOnce() or base::BindRepeating(). Bug: 701275 Change-Id: I5fe41637fe8029be0bfe36b0cb002711be9f9ddc Reviewed-on: https://chromium-review.googlesource.com/1087064 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#565250} [modify] https://crrev.com/928501938ec5605118d4338f9c9addfa215e9df9/components/autofill/ios/browser/fake_autofill_agent.mm [modify] https://crrev.com/928501938ec5605118d4338f9c9addfa215e9df9/components/autofill/ios/browser/fake_js_autofill_manager.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ecde41db06774d2c2d0b9bf41f5ed6f0d2883e9 commit 9ecde41db06774d2c2d0b9bf41f5ed6f0d2883e9 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Jun 08 09:28:24 2018 Convert media/ to use Bind() for blocks With https://crrev.com/c/1070158, base::Bind() supports block via base::RetainBlock(). Converts uses of the now deprecated base::BindBlock(). Bug: 701275 Change-Id: I29af785c8768b5d738ed80aff0724f0d71df5434 Reviewed-on: https://chromium-review.googlesource.com/1090913 Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#565592} [modify] https://crrev.com/9ecde41db06774d2c2d0b9bf41f5ed6f0d2883e9/media/device_monitors/device_monitor_mac.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/160cf019b78bbec15658c2ebfb476ddd4e44eb92 commit 160cf019b78bbec15658c2ebfb476ddd4e44eb92 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Jun 08 09:30:32 2018 Convert ios/chrome to use Bind() for blocks With https://crrev.com/c/1070158, base::Bind() supports block so convert uses of base::BindBlockArc() to instead use base::BindOnce() or base::BindRepeating(). Fix new usages introduced after https://crrev.com/c/1085459. Bug: 701275 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I39d3cb4d63a2df8918fe5640231209916544ec31 Reviewed-on: https://chromium-review.googlesource.com/1090911 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#565593} [modify] https://crrev.com/160cf019b78bbec15658c2ebfb476ddd4e44eb92/ios/chrome/browser/ui/settings/cells/clear_browsing_data_item_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/073e1952c8d1e39900db06d0f7cb0f51d26a6607 commit 073e1952c8d1e39900db06d0f7cb0f51d26a6607 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Jun 08 13:47:57 2018 Convert content/ to use Bind() for blocks With https://crrev.com/c/1070158, base::Bind() supports block via base::RetainBlock(). Converts uses of the now deprecated base::BindBlock(). Bug: 701275 Change-Id: I759e9bc6d62b933463602ccc3b574be3b47c918b Reviewed-on: https://chromium-review.googlesource.com/1092572 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#565621} [modify] https://crrev.com/073e1952c8d1e39900db06d0f7cb0f51d26a6607/content/public/test/content_browser_test_utils_mac.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59ac3030578501aed5c2d2e6f2aefc637fda17d4 commit 59ac3030578501aed5c2d2e6f2aefc637fda17d4 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Jun 11 08:49:57 2018 Convert chrome/ to use Bind() for blocks With https://crrev.com/c/1070158, base::Bind() supports block via base::RetainBlock(). Converts uses of the now deprecated base::BindBlock(). Bug: 701275 Change-Id: I1c0111c6b073c83c3e2638717b0cec1ade13731e Reviewed-on: https://chromium-review.googlesource.com/1092690 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#565948} [modify] https://crrev.com/59ac3030578501aed5c2d2e6f2aefc637fda17d4/chrome/browser/ui/cocoa/base_bubble_controller.mm [modify] https://crrev.com/59ac3030578501aed5c2d2e6f2aefc637fda17d4/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm [modify] https://crrev.com/59ac3030578501aed5c2d2e6f2aefc637fda17d4/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffa615b3f900e6aaea9c5c5e2651468082637229 commit ffa615b3f900e6aaea9c5c5e2651468082637229 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Jun 11 10:36:29 2018 Convert ui/ to use Bind() for blocks With https://crrev.com/c/1070158, base::Bind() supports block via base::RetainBlock(). Converts uses of the now deprecated base::BindBlock(). Bug: 701275 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I103584b54f656f10e17c8e2439e0520c7690dbfe Reviewed-on: https://chromium-review.googlesource.com/1090912 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#565956} [modify] https://crrev.com/ffa615b3f900e6aaea9c5c5e2651468082637229/ui/base/cocoa/menu_controller.mm [modify] https://crrev.com/ffa615b3f900e6aaea9c5c5e2651468082637229/ui/gl/gl_image_io_surface.mm [modify] https://crrev.com/ffa615b3f900e6aaea9c5c5e2651468082637229/ui/gl/gl_image_io_surface_egl.mm [modify] https://crrev.com/ffa615b3f900e6aaea9c5c5e2651468082637229/ui/views/cocoa/views_nswindow_delegate.mm [modify] https://crrev.com/ffa615b3f900e6aaea9c5c5e2651468082637229/ui/views/widget/native_widget_mac.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/286b552cc0de364e8d2ceed2ae1495d6c452d29f commit 286b552cc0de364e8d2ceed2ae1495d6c452d29f Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Jun 11 13:47:41 2018 Convert ios/chrome to use Bind() for blocks With https://crrev.com/c/1070158, base::Bind() supports block so convert uses of base::BindBlockArc() to instead use base::BindOnce() or base::BindRepeating(). Fix new usages introduced after https://crrev.com/c/1090911. Bug: 701275 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If6eb2eeed72d4540ccb3e3a8fc49a8a03d72085c Reviewed-on: https://chromium-review.googlesource.com/1095297 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#565986} [modify] https://crrev.com/286b552cc0de364e8d2ceed2ae1495d6c452d29f/ios/chrome/browser/ui/settings/clear_browsing_data_manager.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb291e0c35c7e29cb2e09813ddf703d4e85e0fea commit bb291e0c35c7e29cb2e09813ddf703d4e85e0fea Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Jun 12 10:03:13 2018 Remove deprecated functions base::BindBlock(Arc)? All the code has been converted to use base::BindOnce or base::BindRepeating, so remove the old deprecated functions. Bug: 701275 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I42b9e3ee5446c6d7fab43572d7fbb29f78b798e2 Reviewed-on: https://chromium-review.googlesource.com/1095259 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#566369} [modify] https://crrev.com/bb291e0c35c7e29cb2e09813ddf703d4e85e0fea/base/BUILD.gn [delete] https://crrev.com/a947f626e8400d52cf797556b949ee23eb8494a3/base/mac/bind_objc_block.h [modify] https://crrev.com/bb291e0c35c7e29cb2e09813ddf703d4e85e0fea/base/mac/bind_objc_block_unittest.mm [modify] https://crrev.com/bb291e0c35c7e29cb2e09813ddf703d4e85e0fea/base/mac/bind_objc_block_unittest_arc.mm [modify] https://crrev.com/bb291e0c35c7e29cb2e09813ddf703d4e85e0fea/chrome/browser/ui/cocoa/browser_window_controller_private.mm [modify] https://crrev.com/bb291e0c35c7e29cb2e09813ddf703d4e85e0fea/ios/chrome/browser/ui/bubble/bubble_presenter.mm [modify] https://crrev.com/bb291e0c35c7e29cb2e09813ddf703d4e85e0fea/ios/chrome/browser/ui/settings/cells/clear_browsing_data_item_unittest.mm
Comment 1 by gambard@chromium.org
, Mar 14 2017Owner: sdefresne@chromium.org
Status: Assigned (was: Untriaged)