Bring up views::Typography "change detector" tests |
||
Issue descriptionChrome Version : 58.0.3026.3 Note these are not "Change detector" tests in the common sense - we actually want to detect changes that aren't under our control -- e.g. those that happen with OS version upgrades. The Harmony spec ( Issue 691891 ) relies on being able to pick a suite of gfx::Fonts with desired properties "by default". Here, "by default" means a default OS configuration with a "typical" screen for that OS. Users must be able to override default font sizes (and more), and we derive fonts based on a "template". We need a mechanism to detect when the OS decides to change its default configuration, since that will affect what "templates" we must provide for that OS + version combination. Unfortunately, not all of our trybots are in a "default" configuration, so attempting to detect this without making a flaky test is problematic. We also need a profile of the suite of OS versions and default configurations that Chrome supports in order to determine the initial set of "templates", and this is tricky to do all at once. So these tests will initially be landed disabled and I'll try to "smoke out" all the bots / templates with small enable/disable changes rather than trying to reland an entire test suite each time. https://codereview.chromium.org/2734113006/
,
Nov 1 2017
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d170f40c01329d7a1ad4b4e0fcba69b445f9cbd9 commit d170f40c01329d7a1ad4b4e0fcba69b445f9cbd9 Author: Peter Kasting <pkasting@chromium.org> Date: Wed Nov 21 19:31:18 2018 Enable disabled tests in ui/gfx/. These pass on Windows. Bug: 320050 , 327287 , 406574 , 427184 , 624513 , 701241, 865527 Change-Id: I51db36ebd63ca17b60eff0bf999ed3aae9ddd958 Reviewed-on: https://chromium-review.googlesource.com/c/1338955 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#610157} [modify] https://crrev.com/d170f40c01329d7a1ad4b4e0fcba69b445f9cbd9/ui/gfx/color_transform_unittest.cc [modify] https://crrev.com/d170f40c01329d7a1ad4b4e0fcba69b445f9cbd9/ui/gfx/font_names_testing.cc [modify] https://crrev.com/d170f40c01329d7a1ad4b4e0fcba69b445f9cbd9/ui/gfx/font_unittest.cc [modify] https://crrev.com/d170f40c01329d7a1ad4b4e0fcba69b445f9cbd9/ui/gfx/render_text_unittest.cc [modify] https://crrev.com/d170f40c01329d7a1ad4b4e0fcba69b445f9cbd9/ui/gfx/text_utils_unittest.cc [modify] https://crrev.com/d170f40c01329d7a1ad4b4e0fcba69b445f9cbd9/ui/gfx/transform_unittest.cc |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Mar 21 2017