New issue
Advanced search Search tips

Issue 701232 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

video_VideoDecodeAccelerator failing on kepler devices

Project Member Reported by wuchengli@chromium.org, Mar 14 2017

Issue description

video_VideoDecodeAccelerator failed on Rikku, Guado and Buddy. Something wrong with the thumbnail md5?

Note: Google Test filter = Thumbnail/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from Thumbnail/VideoDecodeAcceleratorParamTest
[ RUN      ] Thumbnail/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0
../../../../../../../home/chrome-bot/chrome_root/src/media/gpu/video_decode_accelerator_unittest.cc:1520: Failure
Value of: static_cast<int>(png.size())
  Actual: 288145
Expected: num_bytes
Which is: -1
../../../../../../../home/chrome-bot/chrome_root/src/media/gpu/video_decode_accelerator_unittest.cc:1522: Failure
Expected: (match) != (golden_md5s.end()), actual: 8-byte object <90-DD C1-F0 C5-35 00-00> vs 8-byte object <90-DD C1-F0 C5-35 00-00>
[  FAILED  ] Thumbnail/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0, where GetParam() = (1, 1, 1, -1, 6, false, true) (1838 ms)
[----------] 1 test from Thumbnail/VideoDecodeAcceleratorParamTest (1838 ms total)
 
I have a guado on my desk.
The md5sum of vp8 thumbnail test of buddy, guado, rikku is not matched to existed md5sum.

All of them have the same md5sum: 5e06153339e8f83f4d8f76331f54423d
Attached image is bad_thumbnail.png generated by guado, which looks quite good.

Since only vp8 is failed, I checked h264 and vp9 thumbnail tests on guado and both of their md5sum match with "Intel - VA_FILTER_SCALING_DEFAULT" which is provided by Intel's recent patch.
https://codereview.chromium.org/2656073003/

Hi Pawel,
Do you know what is the hardware driver for vp8 decode of buddy, guado, and rikku?
test-25fps.vp8.bad_thumbnails.png
281 KB View Download
This issue should be fixed after updating the following 2 CLs:
1. Update VP8 md5 for Kepler
(https://codereview.chromium.org/2766083002)
2. Fix the issue of "failed to write PNG file" (https://codereview.chromium.org/2753773002)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58af2e5f92c3c5706d7aba46169001c618684169

commit 58af2e5f92c3c5706d7aba46169001c618684169
Author: johnylin <johnylin@chromium.org>
Date: Wed Mar 22 10:14:04 2017

Fix failed to write thumbnail png issue

In https://codereview.chromium.org/2594243002/, filepath of png output is
wrapped to GetTestDataFile(), which will use base::MakeAbsoluteFilePath() to
get absolute path. However, since the output file doesn't exist (yet), this
function will return an empty FilePath instead and makes write file failed.

BUG= 701232 
TEST=Run Thumbnail/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0 of VDA
unittest and make the test matches no md5sum. The test will generate
bad_thumbnails.png successfully.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2753773002
Cr-Commit-Position: refs/heads/master@{#458706}

[modify] https://crrev.com/58af2e5f92c3c5706d7aba46169001c618684169/media/gpu/video_decode_accelerator_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9db40fe3d91bbaada5857d7360976d59bba943cc

commit 9db40fe3d91bbaada5857d7360976d59bba943cc
Author: johnylin <johnylin@chromium.org>
Date: Mon Mar 27 08:18:37 2017

Update VP8 MD5 for go2001

For Kepler devices, we only use its VP8. We disable its VP9 and use Intel GPU instead.

BUG= 701232 
TEST=Run Thumbnail/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0 of VDA
unittest for Guado.

Review-Url: https://codereview.chromium.org/2766083002
Cr-Commit-Position: refs/heads/master@{#459720}

[modify] https://crrev.com/9db40fe3d91bbaada5857d7360976d59bba943cc/media/test/data/test-25fps.vp8.md5

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f0103e37f01de05670a37382f8bbf689104b9a83

commit f0103e37f01de05670a37382f8bbf689104b9a83
Author: Pin-chih Lin <johnylin@google.com>
Date: Thu Apr 06 10:29:39 2017

video_VideoDecodeAccelerator: set resultsdir for writing thumbnail image

While thumbnail test fails, write thumbnail image to results directory
so that it will be accessible to host and packed along with test logs.

BUG= chromium:701232 
TEST=run autotest video_VideoDecodeAccelerator.

Change-Id: Icb6c896da7c51d9086af44abeed59f2a62f039e5
Reviewed-on: https://chromium-review.googlesource.com/461702
Commit-Ready: Pin-chih Lin <johnylin@chromium.org>
Tested-by: Pin-chih Lin <johnylin@chromium.org>
Reviewed-by: Owen Lin <owenlin@chromium.org>

[modify] https://crrev.com/f0103e37f01de05670a37382f8bbf689104b9a83/client/site_tests/video_VideoDecodeAccelerator/video_VideoDecodeAccelerator.py

Status: Verified (was: Fixed)
this test is passing on recent builds. 

Sign in to add a comment