New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701229 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 674593


Show other hotlists

Hotlists containing this issue:
Non-Standard-IDL


Sign in to add a comment

Remove unfinished "Speech Recognition with WebRTC" feature [RuntimeEnabled=MediaStreamSpeech]

Project Member Reported by foolip@chromium.org, Mar 14 2017

Issue description

 Issue 408940  began adding support for speech recognition from other sources than microphones, but was never finished.

This issue is to track removing whatever still remains of that implementation, to make it clear it's no longer being pursued.
 

Comment 1 by guidou@chromium.org, Mar 16 2017

Owner: guidou@chromium.org
Status: Assigned (was: Untriaged)
Any plan to pursue the implementation of this feature in the near future? May I know why this implementation is no longer pursued? And, is there a way I could help?

I think this feature could enable developers to more easily build interesting pieces of software especially in the field of accessibility. Think of real-time and automatic closed-captioning of live video conferencing. It could be a life changer for the Deaf and Hard-of-Hearing. That's only one of the many applications it could have.
Cc: guidou@chromium.org
Owner: maxmorin@chromium.org
I started working on this without knowing about the bug. A CL is in progress.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f93cebdc920d48612d7ec612c7c7724d715d7af

commit 5f93cebdc920d48612d7ec612c7c7724d715d7af
Author: Max Morin <maxmorin@chromium.org>
Date: Mon Nov 06 18:51:49 2017

Remove dead class SpeechRecognitionAudioSink.

It is only ever created when receiving a certain IPC message, which is never sent form the browser.
Also removed that IPC message and some supporting blink code

Bug:  701229 
Change-Id: I5be6957a411f2527b8f109161d887a6d200f2afd
Reviewed-on: https://chromium-review.googlesource.com/749181
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514196}
[modify] https://crrev.com/5f93cebdc920d48612d7ec612c7c7724d715d7af/content/common/speech_recognition_messages.h
[modify] https://crrev.com/5f93cebdc920d48612d7ec612c7c7724d715d7af/content/renderer/BUILD.gn
[delete] https://crrev.com/b995530b1d8cebcba74e7db87a6837cfd5e219c4/content/renderer/media/speech_recognition_audio_sink.cc
[delete] https://crrev.com/b995530b1d8cebcba74e7db87a6837cfd5e219c4/content/renderer/media/speech_recognition_audio_sink.h
[delete] https://crrev.com/b995530b1d8cebcba74e7db87a6837cfd5e219c4/content/renderer/media/speech_recognition_audio_sink_unittest.cc
[modify] https://crrev.com/5f93cebdc920d48612d7ec612c7c7724d715d7af/content/renderer/speech_recognition_dispatcher.cc
[modify] https://crrev.com/5f93cebdc920d48612d7ec612c7c7724d715d7af/content/renderer/speech_recognition_dispatcher.h
[modify] https://crrev.com/5f93cebdc920d48612d7ec612c7c7724d715d7af/content/test/BUILD.gn
[delete] https://crrev.com/b995530b1d8cebcba74e7db87a6837cfd5e219c4/third_party/WebKit/LayoutTests/fast/speech/scripted/speechrecognition-audiotrack.html
[modify] https://crrev.com/5f93cebdc920d48612d7ec612c7c7724d715d7af/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/5f93cebdc920d48612d7ec612c7c7724d715d7af/third_party/WebKit/Source/modules/speech/SpeechRecognition.cpp
[modify] https://crrev.com/5f93cebdc920d48612d7ec612c7c7724d715d7af/third_party/WebKit/Source/modules/speech/SpeechRecognition.h
[modify] https://crrev.com/5f93cebdc920d48612d7ec612c7c7724d715d7af/third_party/WebKit/Source/modules/speech/SpeechRecognition.idl
[modify] https://crrev.com/5f93cebdc920d48612d7ec612c7c7724d715d7af/third_party/WebKit/Source/modules/speech/SpeechRecognitionClient.h
[modify] https://crrev.com/5f93cebdc920d48612d7ec612c7c7724d715d7af/third_party/WebKit/Source/modules/speech/SpeechRecognitionClientProxy.cpp
[modify] https://crrev.com/5f93cebdc920d48612d7ec612c7c7724d715d7af/third_party/WebKit/Source/modules/speech/SpeechRecognitionClientProxy.h
[modify] https://crrev.com/5f93cebdc920d48612d7ec612c7c7724d715d7af/third_party/WebKit/Source/modules/speech/SpeechRecognitionController.h
[modify] https://crrev.com/5f93cebdc920d48612d7ec612c7c7724d715d7af/third_party/WebKit/Source/platform/runtime_enabled_features.json5
[modify] https://crrev.com/5f93cebdc920d48612d7ec612c7c7724d715d7af/third_party/WebKit/public/web/WebSpeechRecognitionParams.h

Status: Fixed (was: Assigned)

Sign in to add a comment