New issue
Advanced search Search tips

Issue 701225 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 697057



Sign in to add a comment

Wrong column splitter placement in cr.ui.Table when having a solid vertical scrollbar

Project Member Reported by yamaguchi@chromium.org, Mar 14 2017

Issue description

Chrome Version: 59.0.3041.0

See the first screenshot in  Issue 684695 .
The layout of table header cells by cr.ui.Table can get broken under this condition:
- Use solid (non-overlay) scrollbars.
- The vertical scroll bar is shown (by having more items than fit in the window).
It's caused because the client width of the list is smaller than that of the table itself. The list table (text) is laid out out based on the former, but the table header splitters are placed based on the latter.

So far I confirmed that the class is used by the Files app. Here is the repro steps, after patching 2724303003. Also see the attached movie.
1. Open a directory that has about 8 to 10 files.
2. Switch to the list mode. (not thumbnail mode)
3. Resize the window so that all items fits in the window, and the vertical scroll bar disappears.
4. Resize to shrink the window vertically so that not all items fits in the window. Observe the table header row.
5. Resize to expand the window. Do same as 4. Observe the table header row.
6. Switch to another directory that has more files than fit in the window. Observe the table header row.

 
column-width-change-by-scrollbar.mp4
195 KB View Download
Summary: Wrong column splitter placement in cr.ui.Table when having a solid vertical scrollbar (was: cr.ui.Table fails to layout table header when having a solid vertical scrollbar)
Blocking: 697057
Cc: weifangsun@chromium.org fukino@chromium.org michae...@chromium.org
Components: -Platform>Apps>FileManager UI>Browser>WebUI
I have split this issue from 697057, because I found this is a potential bug in cr.ui.Table outside the Files app component.
Here is a proposed changelist to fix this: https://codereview.chromium.org/2745593003/

To Michael:
Can you review the change, and double check if the change only affects the Files app.?
AFAIK the Files app. is the only component that uses cr.ui.Table and relevant classes, from code search:
https://cs.chromium.org/search/?q=%22cr.ui.Table%22&type=cs
Labels: -Pri-3 Pri-2
Status: Assigned (was: Unconfirmed)
Labels: -Pri-2 Pri-3
AFAIK, the view has been only used by the Files app. and the task manager, but  the task manager doesn't show the solid scroll bar.
Therefore this bug only affects the Files app., and is limited to the non-default flag configuration (about://flags, overlay_scrollbars=false).

Therefore I think this can be Pri. 3.

Sign in to add a comment