New issue
Advanced search Search tips

Issue 701222 link

Starred by 1 user
Status: Fixed
Owner:
mattm@chromium.org
Closed: Mar 2017
Cc:
eroman@chromium.org
erikc...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug-Regression

Blocking:
issue 701148



Sign in to add a comment

8 CertVerifyProcInspectSignatureAlgorithmsTest tests fail on Sierra

Project Member Reported by lgar...@chromium.org, Mar 14 2017 
Chrome Version: ToT (fdda6d5acfde5d7083995597ddddeb08588728cd)
OS: OSX 10.12.3
XCode version: 8.2.1 (8C1002)

What steps will reproduce the problem?
(1) Check out fdda6d5acfde5d7083995597ddddeb08588728cd and `gclient sync`.
(2) Build and run net_unittests on Mac.

What is the expected result?
Unit tests pass

What happens instead?
8 of 10 CertVerifyProcInspectSignatureAlgorithmsTest unit tests fail:

8 tests failed:
    CertVerifyProcInspectSignatureAlgorithmsTest.IntermediateSha1Sha256 (../../net/cert/cert_verify_proc_unittest.cc:940)
    CertVerifyProcInspectSignatureAlgorithmsTest.IntermediateSha256Sha1 (../../net/cert/cert_verify_proc_unittest.cc:952)
    CertVerifyProcInspectSignatureAlgorithmsTest.LeafSha1Sha256 (../../net/cert/cert_verify_proc_unittest.cc:892)
    CertVerifyProcInspectSignatureAlgorithmsTest.LeafSha256Sha1 (../../net/cert/cert_verify_proc_unittest.cc:904)
    CertVerifyProcInspectSignatureAlgorithmsTest.LeafSha256Unknown (../../net/cert/cert_verify_proc_unittest.cc:916)
    CertVerifyProcInspectSignatureAlgorithmsTest.LeafUnknownSha256 (../../net/cert/cert_verify_proc_unittest.cc:928)
    CertVerifyProcInspectSignatureAlgorithmsTest.RootSha256Sha1 (../../net/cert/cert_verify_proc_unittest.cc:964)
    CertVerifyProcInspectSignatureAlgorithmsTest.RootUnknownSha256 (../../net/cert/cert_verify_proc_unittest.cc:976)

See attachment for the log.
retries.log
15.1 KB View Download

Comment 1 by lgar...@chromium.org, Mar 14 2017 

Thought: this may be because I'm not currently using the hermetic build version of XCode (selected by default for Googlers, but not for public checkouts?)

Comment 2 by lgar...@chromium.org, Mar 14 2017

Cc: erikc...@chromium.org
Summary: 8 CertVerifyProcInspectSignatureAlgorithmsTest tests fail with XCode 8.2.1 (was: 8 CertVerifyProcInspectSignatureAlgorithmsTest tests fail on Mac.)
I don't have time to do a full re-compile using the "hermetic" XCode version, but I'm re-titling with speculative specifics.

I haven't found documentation on how to figure out what SDK I'm building with.

Comment 3 by mattm@chromium.org, Mar 14 2017

Cc: eroman@chromium.org
Owner: mattm@chromium.org
Status: Started (was: Untriaged)
I'm guessing it's a Sierra thing. (We don't run any sierra bots yet right?)

I can have a look.

Comment 4 by mattm@chromium.org, Mar 14 2017

Labels: -OS-All OS-Mac
Summary: 8 CertVerifyProcInspectSignatureAlgorithmsTest tests fail on Sierra (was: 8 CertVerifyProcInspectSignatureAlgorithmsTest tests fail with XCode 8.2.1)
Yep.  Fix uploaded: https://codereview.chromium.org/2751673002/
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1b118ac1850cac95fa820722e227d7f7063cfdc

commit d1b118ac1850cac95fa820722e227d7f7063cfdc
Author: mattm <mattm@chromium.org>
Date: Tue Mar 14 06:39:55 2017

Don't run certificate algorithm mismatch tests on Sierra or later.

BUG= 701222 

Review-Url: https://codereview.chromium.org/2751673002
Cr-Commit-Position: refs/heads/master@{#456637}

[modify] https://crrev.com/d1b118ac1850cac95fa820722e227d7f7063cfdc/net/cert/cert_verify_proc_unittest.cc

Comment 6 by mattm@chromium.org, Mar 14 2017

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14d0a2201d6e9ca49843de49c68936a525dfed85

commit 14d0a2201d6e9ca49843de49c68936a525dfed85
Author: mattm <mattm@chromium.org>
Date: Tue Mar 14 20:14:24 2017

Update comment for SupportsImportingMismatchedAlgorithms in cert_verify_proc_unittest.cc

(followup to https://codereview.chromium.org/2751673002)

BUG= 701222 

Review-Url: https://codereview.chromium.org/2755493002
Cr-Commit-Position: refs/heads/master@{#456807}

[modify] https://crrev.com/14d0a2201d6e9ca49843de49c68936a525dfed85/net/cert/cert_verify_proc_unittest.cc
►

Sign in to add a comment