Update the log links in the /buildstatus page to point to LogDog |
|||
Issue descriptionSee, e.g.: https://build.chromium.org/p/chromium.webkit/buildstatus?builder=WebKit%20Win%20x64%20Builder&number=109674 where it looks like we're still using the old links. Or better, figure out where this buildstatus page came from and make it go away, and just point to the build page :).
,
Mar 14 2017
That's a good question. How did you get to that page? I didn't know that existed.
,
Mar 14 2017
So to be clear, the *only* template I've updated for LogDog-only mode alias preference was the "build.html" template. There are many others, including: - waterfall.html - builder.html - console.html ... and probably more that need this logic embedded. I did it all within "build.html" as a P0 ask from dpranke@, but there is surely a more comprehensive way to update all of the templates. I will try and hit this up tomorrow, but I am on vacation after that, so I might not have enough time. If someone else wants to have a swing at this, they're more than welcome.
,
Mar 14 2017
Re: comment#2: Just click on any run on build.chromium.org.
,
Mar 23 2017
Issue 704582 has been merged into this issue.
,
Mar 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/215c90a39859b1dc3c5326a4042b45718a6cb976 commit 215c90a39859b1dc3c5326a4042b45718a6cb976 Author: Dan Jacques <dnj@chromium.org> Date: Sat Mar 25 01:00:47 2017 Apply LogDog-only rendering to all views. This is a reland of: https://chromium-review.googlesource.com/459123 Currently, LogDog-only rendering is implemented only for the "build" view. This makes clicks on the waterfall and console dysfunctional, since they will link to the useless LogDog-only notice messages instead of the real logs. Rather than painfully updating every site and template, this introduces a generic projection function that transforms a BuildStep's log and URL entries into LogDog-only compatible entries when appropriate. All applicable build status sites have been updated to use the transformation funciton. This is not expected to introduce any rendering performance degradation, since all of the functions that it uses are already called as part of rendering. This supercedes the functionality introduced in: https://chromium-review.googlesource.com/450019 That CL can be safely reverted after this one lands. TBR=hinoka@chromium.org BUG= chromium:701218 TEST=local - Visited all views w/ a local BuildBot instance, verified that everything seems to be in order. Change-Id: Ib1f7d1727e42ba1129cdb8b5dc8edd686919a89e Reviewed-on: https://chromium-review.googlesource.com/458986 Reviewed-by: Daniel Jacques <dnj@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org> [modify] https://crrev.com/215c90a39859b1dc3c5326a4042b45718a6cb976/third_party/buildbot_8_4p1/buildbot/status/web/base.py [modify] https://crrev.com/215c90a39859b1dc3c5326a4042b45718a6cb976/third_party/buildbot_8_4p1/buildbot/status/web/console.py [modify] https://crrev.com/215c90a39859b1dc3c5326a4042b45718a6cb976/third_party/buildbot_8_4p1/buildbot/status/web/build.py [modify] https://crrev.com/215c90a39859b1dc3c5326a4042b45718a6cb976/third_party/buildbot_8_4p1/buildbot/status/web/waterfall.py [modify] https://crrev.com/215c90a39859b1dc3c5326a4042b45718a6cb976/third_party/buildbot_8_4p1/buildbot/status/web/step.py
,
Mar 25 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/d0a4cb23abb6c10dcb39aff18eea3d92d5aa62fc commit d0a4cb23abb6c10dcb39aff18eea3d92d5aa62fc Author: Dan Jacques <dnj@google.com> Date: Sat Mar 25 01:05:25 2017
,
Mar 25 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/d0a4cb23abb6c10dcb39aff18eea3d92d5aa62fc commit d0a4cb23abb6c10dcb39aff18eea3d92d5aa62fc Author: Dan Jacques <dnj@google.com> Date: Sat Mar 25 01:05:25 2017
,
Mar 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/aba72f93fd23613ba80a8129ae5ec1eb5b954e1f commit aba72f93fd23613ba80a8129ae5ec1eb5b954e1f Author: Daniel Jacques <dnj@chromium.org> Date: Sat Mar 25 01:25:22 2017 Revert "Apply LogDog-only rendering to all views." This reverts commit 215c90a39859b1dc3c5326a4042b45718a6cb976. Reason for revert: global name 'logname' is not defined Original change's description: > Apply LogDog-only rendering to all views. > > This is a reland of: https://chromium-review.googlesource.com/459123 > > Currently, LogDog-only rendering is implemented only for the "build" > view. This makes clicks on the waterfall and console dysfunctional, > since they will link to the useless LogDog-only notice messages instead > of the real logs. > > Rather than painfully updating every site and template, this introduces > a generic projection function that transforms a BuildStep's log and URL > entries into LogDog-only compatible entries when appropriate. All > applicable build status sites have been updated to use the > transformation funciton. > > This is not expected to introduce any rendering performance degradation, > since all of the functions that it uses are already called as part of > rendering. > > This supercedes the functionality introduced in: > https://chromium-review.googlesource.com/450019 > > That CL can be safely reverted after this one lands. > > TBR=hinoka@chromium.org > BUG= chromium:701218 > TEST=local > - Visited all views w/ a local BuildBot instance, verified that > everything seems to be in order. > > Change-Id: Ib1f7d1727e42ba1129cdb8b5dc8edd686919a89e > Reviewed-on: https://chromium-review.googlesource.com/458986 > Reviewed-by: Daniel Jacques <dnj@chromium.org> > Commit-Queue: Daniel Jacques <dnj@chromium.org> > TBR=dnj@chromium.org,chromium-reviews@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= chromium:701218 Change-Id: Id3a482ec16bef419ad3ecadb1f536502eb091cc2 Reviewed-on: https://chromium-review.googlesource.com/459087 Reviewed-by: Daniel Jacques <dnj@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org> [modify] https://crrev.com/aba72f93fd23613ba80a8129ae5ec1eb5b954e1f/third_party/buildbot_8_4p1/buildbot/status/web/base.py [modify] https://crrev.com/aba72f93fd23613ba80a8129ae5ec1eb5b954e1f/third_party/buildbot_8_4p1/buildbot/status/web/console.py [modify] https://crrev.com/aba72f93fd23613ba80a8129ae5ec1eb5b954e1f/third_party/buildbot_8_4p1/buildbot/status/web/build.py [modify] https://crrev.com/aba72f93fd23613ba80a8129ae5ec1eb5b954e1f/third_party/buildbot_8_4p1/buildbot/status/web/waterfall.py [modify] https://crrev.com/aba72f93fd23613ba80a8129ae5ec1eb5b954e1f/third_party/buildbot_8_4p1/buildbot/status/web/step.py
,
Mar 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/0c217f774a5ae7c7ed1149df89ee9a03deee21a6 commit 0c217f774a5ae7c7ed1149df89ee9a03deee21a6 Author: Dan Jacques <dnj@chromium.org> Date: Sat Mar 25 01:33:32 2017 Apply LogDog-only rendering to all views (#3). This is a reland of: https://chromium-review.googlesource.com/c/458986/ Currently, LogDog-only rendering is implemented only for the "build" view. This makes clicks on the waterfall and console dysfunctional, since they will link to the useless LogDog-only notice messages instead of the real logs. Rather than painfully updating every site and template, this introduces a generic projection function that transforms a BuildStep's log and URL entries into LogDog-only compatible entries when appropriate. All applicable build status sites have been updated to use the transformation funciton. This is not expected to introduce any rendering performance degradation, since all of the functions that it uses are already called as part of rendering. This supercedes the functionality introduced in: https://chromium-review.googlesource.com/450019 That CL can be safely reverted after this one lands. TBR=hinoka@chromium.org BUG= chromium:701218 TEST=local - Visited all views w/ a local BuildBot instance, verified that everything seems to be in order. Change-Id: I24b57feb4ac32dc04c9a95be6bdc96d515ebba56 Reviewed-on: https://chromium-review.googlesource.com/459445 Reviewed-by: Daniel Jacques <dnj@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org> [modify] https://crrev.com/0c217f774a5ae7c7ed1149df89ee9a03deee21a6/third_party/buildbot_8_4p1/buildbot/status/web/base.py [modify] https://crrev.com/0c217f774a5ae7c7ed1149df89ee9a03deee21a6/third_party/buildbot_8_4p1/buildbot/status/web/console.py [modify] https://crrev.com/0c217f774a5ae7c7ed1149df89ee9a03deee21a6/third_party/buildbot_8_4p1/buildbot/status/web/build.py [modify] https://crrev.com/0c217f774a5ae7c7ed1149df89ee9a03deee21a6/third_party/buildbot_8_4p1/buildbot/status/web/waterfall.py [modify] https://crrev.com/0c217f774a5ae7c7ed1149df89ee9a03deee21a6/third_party/buildbot_8_4p1/buildbot/status/web/step.py
,
Mar 25 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/6c544773d6e4eb25f3924b0b8741de1f1599cb91 commit 6c544773d6e4eb25f3924b0b8741de1f1599cb91 Author: Dan Jacques <dnj@google.com> Date: Sat Mar 25 01:35:25 2017
,
Mar 25 2017
,
Mar 25 2017
The latest land seems to be working. I'm filing a bug (https://bugs.chromium.org/p/chromium/issues/detail?id=705184) to restart all masters to pick up the change. After that, this should be good to go.
,
Mar 28 2017
,
Mar 28 2017
Issue 705825 has been merged into this issue. |
|||
►
Sign in to add a comment |
|||
Comment 1 by dpranke@chromium.org
, Mar 14 2017