Update the log links to point to logdog in the build failure emails |
|||
Issue descriptionIf you run a try job and get a build failure, the `stdio` link in the email still points to the buildbot stub, rather than the new logdog log. See https://groups.google.com/a/chromium.org/d/topic/infra-dev/RVL-xzvbf2g/discussion for an example. Please fix this soon.
,
Mar 27 2017
hinoka says dnj has a CL out to fix this once and for all, stay tuned.
,
Mar 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/cb672ae7ae5be63e439de79cb0761299e888d00a commit cb672ae7ae5be63e439de79cb0761299e888d00a Author: dnj <dnj@chromium.org> Date: Mon Mar 27 22:31:50 2017 Include LogDog viewer links in message. In LogDog-only mode, the actual text emitted to the base stream is just a placeholder referencing LogDog-only mode. Add text to that placeholder that points to the LogDog links, just in case a user is directed to the stream. BUG= chromium:701201 TEST=None R=hinoka@chromium.org Review-Url: https://codereview.chromium.org/2780673002 [modify] https://crrev.com/cb672ae7ae5be63e439de79cb0761299e888d00a/logdog/client/annotee/processor.go
,
Mar 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/bd7c09a3a39523473f59ceb432b4f1dbc283c5c7 commit bd7c09a3a39523473f59ceb432b4f1dbc283c5c7 Author: dnj <dnj@chromium.org> Date: Mon Mar 27 22:31:56 2017 Promote LogDog aliases for BuildBot JSON data. Generalize the LogDog alias-to-link promotion logic and apply it to the BuildBot JSON endpoints. This will cause LogDog-only builds to omit junk BuildBot log links in favor of the LogDog link aliases, bringing the JSON in line with the rendered build. Because Gatekeeper uses Milo for BuildBot step information, this will incidentally cause Gatekeeper to include LogDog links in its failure e-mails instead of the junk BuildBot links. BUG= chromium:701201 TEST=expectations - Expectations, which already expressed this logic, didn't change. R=hinoka@chromium.org Review-Url: https://codereview.chromium.org/2774343003 [modify] https://crrev.com/bd7c09a3a39523473f59ceb432b4f1dbc283c5c7/milo/appengine/buildbot/build.go [modify] https://crrev.com/bd7c09a3a39523473f59ceb432b4f1dbc283c5c7/milo/appengine/buildbot/grpc.go
,
Mar 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/61c57a82c980656476d196b36263b145834d93b4 commit 61c57a82c980656476d196b36263b145834d93b4 Author: dnj <dnj@chromium.org> Date: Mon Mar 27 23:55:11 2017 Milo: Use LogDog URLs in top-level "Logs" field. The previous CL successfully updated log URLs in "steps", but left the top-level "Logs" links in-tact. While the "Logs" field is debatably useful and can probably be deleted, it should be correct for as long as it's there. BUG= chromium:701201 TEST=local Review-Url: https://codereview.chromium.org/2778693005 [modify] https://crrev.com/61c57a82c980656476d196b36263b145834d93b4/milo/appengine/buildbot/build.go
,
Nov 30 2017
I think this is done. |
|||
►
Sign in to add a comment |
|||
Comment 1 by martiniss@chromium.org
, Mar 14 2017