New issue
Advanced search Search tips

Issue 701193 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 713380

Blocking:
issue 648964



Sign in to add a comment

mash: Fix mapping of SessionState to LoginStatus

Project Member Reported by jamescook@chromium.org, Mar 14 2017

Issue description

There's not a perfect mapping right now.  See SessionController::GetLoginStatus().

We need to handle owner vs. non-owner users and the "adding secondary user" state.

xiyuan, do you want to own this, or should I keep it?

 

Comment 1 by xiy...@chromium.org, Mar 27 2017

Cc: -xiy...@chromium.org jamescook@chromium.org
Owner: xiy...@chromium.org

Comment 2 by xiy...@chromium.org, Mar 29 2017

I will take the chance to consolidate the LoginStatus code path:
- Make cash/mash use the same code path for LoginStatus update;
- Migrate ash code to use only SessionController::GetLoginStatus;
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/233f4e71bd49e79e477ef3ba814d53e8036e3c50

commit 233f4e71bd49e79e477ef3ba814d53e8036e3c50
Author: xiyuan <xiyuan@chromium.org>
Date: Thu Apr 06 06:59:56 2017

ash: Merge LoginStatus update code path

- Add LoginStatusChanged to SessionStateObserver;
- Make SessionController fire LoginStatusChanged;
- Shell call UpdateAfterLoginStatusChange on LoginStatusChanged;
- Remove Shell::OnLoginStateChanged and notify ShellObserver in
  Shell::LoginStatusChanged;
- Remove UpdateAfterLoginStatusChange calls from SystemTrayDelegateChromeOS
  and TestSessionControllerClient;
- Remove Shell::OnLoginStateChanged calls from LoginLockStateNotifier
  since LoginStatusChanged should cover that;
- Fix ash_shell_with_content that SessionController is not bound
  to its client;

BUG=701193, 679450 

Review-Url: https://codereview.chromium.org/2797743002
Cr-Commit-Position: refs/heads/master@{#462378}

[modify] https://crrev.com/233f4e71bd49e79e477ef3ba814d53e8036e3c50/ash/common/session/session_controller.cc
[modify] https://crrev.com/233f4e71bd49e79e477ef3ba814d53e8036e3c50/ash/common/session/session_controller.h
[modify] https://crrev.com/233f4e71bd49e79e477ef3ba814d53e8036e3c50/ash/common/session/session_controller_unittest.cc
[modify] https://crrev.com/233f4e71bd49e79e477ef3ba814d53e8036e3c50/ash/common/session/session_state_observer.h
[modify] https://crrev.com/233f4e71bd49e79e477ef3ba814d53e8036e3c50/ash/common/system/user/tray_user.cc
[modify] https://crrev.com/233f4e71bd49e79e477ef3ba814d53e8036e3c50/ash/common/test/test_session_controller_client.cc
[modify] https://crrev.com/233f4e71bd49e79e477ef3ba814d53e8036e3c50/ash/mus/system_tray_delegate_mus.cc
[modify] https://crrev.com/233f4e71bd49e79e477ef3ba814d53e8036e3c50/ash/shell.cc
[modify] https://crrev.com/233f4e71bd49e79e477ef3ba814d53e8036e3c50/ash/shell.h
[modify] https://crrev.com/233f4e71bd49e79e477ef3ba814d53e8036e3c50/ash/shell/content/client/shell_browser_main_parts.cc
[modify] https://crrev.com/233f4e71bd49e79e477ef3ba814d53e8036e3c50/ash/shell/example_session_controller_client.cc
[modify] https://crrev.com/233f4e71bd49e79e477ef3ba814d53e8036e3c50/ash/wm/lock_state_controller.cc
[modify] https://crrev.com/233f4e71bd49e79e477ef3ba814d53e8036e3c50/ash/wm/lock_state_controller.h
[modify] https://crrev.com/233f4e71bd49e79e477ef3ba814d53e8036e3c50/chrome/browser/chromeos/power/login_lock_state_notifier.cc
[modify] https://crrev.com/233f4e71bd49e79e477ef3ba814d53e8036e3c50/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
[modify] https://crrev.com/233f4e71bd49e79e477ef3ba814d53e8036e3c50/chrome/browser/ui/ash/session_controller_client.cc
[modify] https://crrev.com/233f4e71bd49e79e477ef3ba814d53e8036e3c50/chrome/browser/ui/ash/session_controller_client.h
[modify] https://crrev.com/233f4e71bd49e79e477ef3ba814d53e8036e3c50/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/233f4e71bd49e79e477ef3ba814d53e8036e3c50/chrome/browser/ui/ash/system_tray_delegate_chromeos.h

Comment 4 by xiy...@chromium.org, Apr 19 2017

Blockedon: 713380

Comment 5 by xiy...@chromium.org, Apr 19 2017

Labels: Hotlist-GoodFirstBug
Components: -Internals>MUS Internals>Services>WindowService
Components: -Internals>Services>WindowService Internals>Services>Ash
Labels: -Proj-Mustash-Mash

Sign in to add a comment