New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 701171 link

Starred by 1 user
Status: Fixed
Owner:
michae...@chromium.org
Closed: Mar 2017
Cc:
█ dschuyler@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

spurious presubmit warnings in chrome/browser/resources

Project Member Reported by michae...@chromium.org, Mar 13 2017 
When changing chrome/browser/resources/settings/about_page/compiled_resources2.gyp, I get this new PRESUBMIT warning:

Found lines longer than 80 characters (first 5 shown).
  chrome/browser/resources/settings/about_page/compiled_resources2.gyp, line 34, 110 chars


Suspect commit 3ae1581e: https://codereview.chromium.org/2729403003
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20e1ab9bfba1edcd809ff19894b91cf9cb7fab5c

commit 20e1ab9bfba1edcd809ff19894b91cf9cb7fab5c
Author: michaelpg <michaelpg@chromium.org>
Date: Mon Mar 13 23:52:12 2017

PRESUBMIT should only check line length for .html files in c/b/resources

After crrev.com/2729403003, chrome/browser/resources/PRESUBMIT.py
checks the line length of files. It was intended to only check
.html files, but instead checks *all* files *iff* at least one
.html file is present.

BUG= 701171 
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2747953002
Cr-Commit-Position: refs/heads/master@{#456553}

[modify] https://crrev.com/20e1ab9bfba1edcd809ff19894b91cf9cb7fab5c/chrome/browser/resources/PRESUBMIT.py

Comment 2 by michae...@chromium.org, Mar 13 2017

Status: Fixed (was: Started)
►

Sign in to add a comment