New issue
Advanced search Search tips

Issue 701156 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

mash: Crash in DesktopWindowTreeHost when opening <select> menu

Project Member Reported by jamescook@chromium.org, Mar 13 2017

Issue description

Chrome r456403

* Navigate to a page with a <select> element
* Click on the element

[26681:26681:0313/155024.888739:FATAL:desktop_window_tree_host_chromeos.cc(15)] Check failed: false. 
#0 0x7fb2ac616cb7 base::debug::StackTrace::StackTrace()
#1 0x7fb2ac63877a logging::LogMessage::~LogMessage()
#2 0x7fb2a80e4eb2 views::DesktopWindowTreeHost::Create()
#3 0x7fb2a80f2a30 views::DesktopNativeWidgetAura::InitNativeWidget()
#4 0x7fb2a80d9a3d views::Widget::Init()
#5 0x7fb2a80f4ed7 views::(anonymous namespace)::DesktopNativeWidgetAuraWindowParentingClient::GetDefaultParent()
#6 0x7fb2a7b142c4 aura::client::ParentWindowWithContext()
#7 0x7fb2aa187b19 content::RenderWidgetHostViewAura::InitAsPopup()
#8 0x7fb2aa284f34 content::WebContentsImpl::ShowCreatedWidget()
#9 0x7fb2aa173150 content::RenderViewHostImpl::OnShowWidget()
#10 0x7fb2aa17301f _ZN3IPC8MessageTI27ViewHostMsg_ShowWidget_MetaSt5tupleIJiN3gfx4RectEEEvE8DispatchIN7content18RenderViewHostImplES9_vMS9_FviRKS4_EEEbPKNS_7MessageEPT_PT0_PT1_T2_
#11 0x7fb2aa1725fd content::RenderViewHostImpl::OnMessageReceived()
#12 0x7fb2aa1779c2 content::RenderWidgetHostImpl::OnMessageReceived()
#13 0x7fb2aa166104 content::RenderProcessHostImpl::OnMessageReceived()
#14 0x7fb2aca4da55 IPC::ChannelProxy::Context::OnDispatchMessage()
#15 0x7fb2aca5053b _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12ChannelProxy7ContextEFvRKNS3_7MessageEEJ13scoped_refptrIS5_ES6_EEEFvvEE3RunEPNS0_13BindStateBaseE
#16 0x7fb2ac617779 base::debug::TaskAnnotator::RunTask()
#17 0x7fb2ac64555d base::MessageLoop::RunTask()
#18 0x7fb2ac645c25 base::MessageLoop::DoWork()
#19 0x7fb2ac648269 base::MessagePumpLibevent::Run()
#20 0x7fb2ac6452da base::MessageLoop::RunHandler()
#21 0x7fb2ac677edf base::RunLoop::Run()
#22 0x7fb2adb81f09 ChromeBrowserMainParts::MainMessageLoopRun()
#23 0x7fb2a9e70459 content::BrowserMainLoop::RunMainMessageLoopParts()
#24 0x7fb2a9e73a2e content::BrowserMainRunnerImpl::Run()
#25 0x7fb2a9e6b7ee content::BrowserMain()
#26 0x7fb2aa6264dc content::ContentMainRunnerImpl::Run()
#27 0x7fb2aa624c90 content::ContentMain()
#28 0x7fb2ad231fa0 ChromeMain
#29 0x7fb2a36b1f45 __libc_start_main
#30 0x7fb2ad231dfd <unknown>

To sky@ for triage.

 

Comment 1 by sky@chromium.org, Mar 14 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6eb9203f08cb87cdbaa93f7f6ea4b6b5a9dd41b

commit b6eb9203f08cb87cdbaa93f7f6ea4b6b5a9dd41b
Author: sky <sky@chromium.org>
Date: Tue Mar 14 18:30:10 2017

Adds a factory function to ViewsDelegate for DesktopWindowTreeHost

There is at least one code path (html selects) that creates a
DesktopNativeWidgetAura directly, and relies on
DesktopWindowTreeHost::Create() being called. Problem is we can't wire
up DesktopWindowTreeHost::Create() for ChromeOS (as mus is in a
different compilation unit), so instead this adds another factory
function to ViewsDelegate that if valid DesktopNativeWidgetAura uses
to create the DesktopWindowTreeHost.

BUG= 701156 
TEST=none
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2746763007
Cr-Commit-Position: refs/heads/master@{#456768}

[modify] https://crrev.com/b6eb9203f08cb87cdbaa93f7f6ea4b6b5a9dd41b/ui/views/mus/mus_client.cc
[modify] https://crrev.com/b6eb9203f08cb87cdbaa93f7f6ea4b6b5a9dd41b/ui/views/mus/mus_client.h
[modify] https://crrev.com/b6eb9203f08cb87cdbaa93f7f6ea4b6b5a9dd41b/ui/views/views_delegate.h
[modify] https://crrev.com/b6eb9203f08cb87cdbaa93f7f6ea4b6b5a9dd41b/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
[modify] https://crrev.com/b6eb9203f08cb87cdbaa93f7f6ea4b6b5a9dd41b/ui/views/widget/desktop_aura/desktop_window_tree_host_chromeos.cc

Comment 3 Deleted

Comment 4 by sky@chromium.org, Mar 14 2017

Status: Fixed (was: Fix)

Comment 5 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment