New issue
Advanced search Search tips

Issue 701152 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Crash on double controller activation from app launcher

Project Member Reported by khmel@chromium.org, Mar 13 2017

Issue description

Click on Play Store in App Launcher.
Wait OptIn window pop-up
Click on Play Store in App Launcher again.

Expected OptIn window gets focus.
Actually: Crash.

Repro in 58, 59

Sample crash report: 7606a5b300000000





 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1a39b125d0cc6b6994b92089ebc877b693a6ddd

commit b1a39b125d0cc6b6994b92089ebc877b693a6ddd
Author: khmel <khmel@chromium.org>
Date: Tue Mar 14 21:13:13 2017

arc: Fix crash on deferred app launch.

This fixes regression due recent shelf refactoring when meaning
of TYPE_APP AND TYPE_SHORTCUT_APP was changed. ARC defered
launcher is allowed only over shortcuts.

TEST=Manually
BUG= 701152 

Review-Url: https://codereview.chromium.org/2747983002
Cr-Commit-Position: refs/heads/master@{#456830}

[modify] https://crrev.com/b1a39b125d0cc6b6994b92089ebc877b693a6ddd/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc
[modify] https://crrev.com/b1a39b125d0cc6b6994b92089ebc877b693a6ddd/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Comment 2 by khmel@chromium.org, Mar 14 2017

Labels: Merge-Request-58 M-58
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 15 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 17 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92716b1689b94ce7c3edf5facdf858c35fa50766

commit 92716b1689b94ce7c3edf5facdf858c35fa50766
Author: khmel <khmel@chromium.org>
Date: Fri Mar 17 18:34:23 2017

[Merge M58] arc: Fix crash on deferred app launch.

This fixes regression due recent shelf refactoring when meaning
of TYPE_APP AND TYPE_SHORTCUT_APP was changed. ARC defered
launcher is allowed only over shortcuts.

TEST=Manually
BUG= 701152 
TBR=msw@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2747983002
Cr-Commit-Position: refs/heads/master@{#456830}
(cherry picked from commit b1a39b125d0cc6b6994b92089ebc877b693a6ddd)

Review-Url: https://codereview.chromium.org/2758873002
Cr-Commit-Position: refs/branch-heads/3029@{#272}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/92716b1689b94ce7c3edf5facdf858c35fa50766/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc
[modify] https://crrev.com/92716b1689b94ce7c3edf5facdf858c35fa50766/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Comment 5 by khmel@chromium.org, Mar 17 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
9334.23.0 / 58.0.3029.39

Sign in to add a comment