New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701148 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue 701222



Sign in to add a comment

Update M58 preload list binary changes

Project Member Reported by lgar...@chromium.org, Mar 13 2017

Issue description

Split from  Issue 670139 
 
Turns out this requires a unit test update – will take a bit longer.
Blockedon: 701222
> Turns out this requires a unit test update – will take a bit longer.

Never mind, false positive due to  Issue 701222 . Landing now.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f676ea4689dec8df2f636d7d768ea752eac8113

commit 2f676ea4689dec8df2f636d7d768ea752eac8113
Author: Lucas Garron <lgarron@chromium.org>
Date: Wed Mar 15 00:03:04 2017

Update transport_security_state_static.h to be in sync with the JSON.

BUG= 701148 
TBR=palmer@chromium.org

Review-Url: https://codereview.chromium.org/2749683002 .
Cr-Commit-Position: refs/heads/master@{#456902}

[modify] https://crrev.com/2f676ea4689dec8df2f636d7d768ea752eac8113/net/http/transport_security_state_static.h

Labels: Merge-Request-58
Requesting a merge of 2f676ea4689dec8df2f636d7d768ea752eac8113 to M58 (as soon as it has baked on Canary).
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 16 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 16 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17792cbdcb0f2beefd97a84a0ab8c15b5ebdd198

commit 17792cbdcb0f2beefd97a84a0ab8c15b5ebdd198
Author: Lucas Garron <lgarron@chromium.org>
Date: Thu Mar 16 01:21:38 2017

Update transport_security_state_static.h to be in sync with the JSON.

BUG= 701148 
TBR=palmer@chromium.org

Review-Url: https://codereview.chromium.org/2749683002 .
Cr-Commit-Position: refs/heads/master@{#456902}
(cherry picked from commit 2f676ea4689dec8df2f636d7d768ea752eac8113)

Review-Url: https://codereview.chromium.org/2753543007 .
Cr-Commit-Position: refs/branch-heads/3029@{#223}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/17792cbdcb0f2beefd97a84a0ab8c15b5ebdd198/net/http/transport_security_state_static.h

Status: Fixed (was: Started)

Sign in to add a comment