New issue
Advanced search Search tips

Issue 701146 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

AutocompleteInput's Constructor Has 10+ Parameters

Project Member Reported by mpear...@chromium.org, Mar 13 2017

Issue description


Most of these can have reasonable default values.  We should change them to default arguments.

 
Description: Show this description
Labels: OS-All
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d

commit bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d
Author: Kevin Bailey <krb@chromium.org>
Date: Sun Oct 01 21:53:02 2017

[omnibox] Reduced number of parameters to ACInput constructor

Most of AutocompleteInput's constructor's parameters are not needed in
the constructor. This CL removes all but the necessary ones and
provides setters for the remainder. It also changes all the call sites.

Bug:  701146 
Change-Id: I99911d47bec8b3286f9bf9bd2b822aeb315f4005
Reviewed-on: https://chromium-review.googlesource.com/667396
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505524}
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/chrome/browser/android/omnibox/autocomplete_controller_android.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/chrome/browser/autocomplete/autocomplete_browsertest.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/chrome/browser/autocomplete/search_provider_unittest.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/chrome/browser/extensions/api/omnibox/omnibox_api_browsertest.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/chrome/browser/ui/app_list/search/omnibox_provider.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/chrome/browser/ui/webui/omnibox/omnibox_page_handler.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/components/omnibox/browser/autocomplete_classifier.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/components/omnibox/browser/autocomplete_input.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/components/omnibox/browser/autocomplete_input.h
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/components/omnibox/browser/autocomplete_input_unittest.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/components/omnibox/browser/autocomplete_match_unittest.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/components/omnibox/browser/autocomplete_provider_unittest.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/components/omnibox/browser/autocomplete_result_unittest.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/components/omnibox/browser/base_search_provider_unittest.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/components/omnibox/browser/bookmark_provider_unittest.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/components/omnibox/browser/builtin_provider_unittest.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/components/omnibox/browser/clipboard_url_provider_unittest.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/components/omnibox/browser/history_quick_provider_performance_unittest.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/components/omnibox/browser/history_quick_provider_unittest.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/components/omnibox/browser/history_url_provider_unittest.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/components/omnibox/browser/keyword_provider_unittest.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/components/omnibox/browser/omnibox_edit_model.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/components/omnibox/browser/physical_web_provider_unittest.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/components/omnibox/browser/shortcuts_provider_test_util.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/components/omnibox/browser/shortcuts_provider_unittest.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/components/omnibox/browser/titled_url_match_utils_unittest.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/components/omnibox/browser/zero_suggest_provider.cc
[modify] https://crrev.com/bcc319e88f81b1dcc8f9d63d1c5aa1de56f3763d/components/omnibox/browser/zero_suggest_provider_unittest.cc

Owner: k...@chromium.org
Status: Fixed (was: Available)
Fixed by krb@!

Sign in to add a comment