Add a flag to allow easy selection of tablet mode. |
||||
Issue descriptionWe should add an option on chrome://flags to force touchview vs clamshell vs auto. When set, it should enable all the right things for the selected UI type, such as keyboard, ash debug shortcut, accelerometer, etc. auto should decide the mode based on the existence of keyboard/mouse and availability of touch.
,
Mar 13 2017
Thanks zork! Suggestion: instead of an enable/disable flag, perhaps make it a dropdown with 3 options: - TouchView - Clamshell - Auto (default)
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d583776463091d93eae768d76389c87dd39e5ca5 commit d583776463091d93eae768d76389c87dd39e5ca5 Author: sammiequon <sammiequon@chromium.org> Date: Thu Mar 16 21:14:59 2017 CrOS: Add a flag to allow easy selection of tablet mode. Adds a flag so users can force certain modes. https://screenshot.googleplex.com/1Ny5PpP6MA6 TEST=unit_tests --gtest_filter="AboutFlagsHistogramTest.*" BUG= 701135 Review-Url: https://codereview.chromium.org/2749633006 Cr-Commit-Position: refs/heads/master@{#457555} [modify] https://crrev.com/d583776463091d93eae768d76389c87dd39e5ca5/chrome/app/generated_resources.grd [modify] https://crrev.com/d583776463091d93eae768d76389c87dd39e5ca5/chrome/browser/about_flags.cc [modify] https://crrev.com/d583776463091d93eae768d76389c87dd39e5ca5/chrome/common/chrome_switches.cc [modify] https://crrev.com/d583776463091d93eae768d76389c87dd39e5ca5/chrome/common/chrome_switches.h [modify] https://crrev.com/d583776463091d93eae768d76389c87dd39e5ca5/tools/metrics/histograms/histograms.xml
,
Mar 23 2017
,
Mar 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df9bf7c32b4361a7b66a241317ca3571f58c28b3 commit df9bf7c32b4361a7b66a241317ca3571f58c28b3 Author: sammiequon <sammiequon@chromium.org> Date: Wed Mar 29 15:17:03 2017 CrOS: Move force UI mode switch from switches to ash switches. We will need this switch in ash switches to use with ash. See dependent patchset for usage. TEST=unit_tests --gtest_filter="AboutFlagsHistogramTest.*" BUG= 701135 Review-Url: https://codereview.chromium.org/2765373002 Cr-Commit-Position: refs/heads/master@{#460391} [modify] https://crrev.com/df9bf7c32b4361a7b66a241317ca3571f58c28b3/ash/common/ash_switches.cc [modify] https://crrev.com/df9bf7c32b4361a7b66a241317ca3571f58c28b3/ash/common/ash_switches.h [modify] https://crrev.com/df9bf7c32b4361a7b66a241317ca3571f58c28b3/chrome/browser/about_flags.cc [modify] https://crrev.com/df9bf7c32b4361a7b66a241317ca3571f58c28b3/chrome/common/chrome_switches.cc [modify] https://crrev.com/df9bf7c32b4361a7b66a241317ca3571f58c28b3/chrome/common/chrome_switches.h
,
Mar 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d6e7115c66667ae3f401de68bf7cfbc7e694f79 commit 1d6e7115c66667ae3f401de68bf7cfbc7e694f79 Author: sammiequon <sammiequon@chromium.org> Date: Wed Mar 29 17:09:30 2017 CrOS: Apply flag which enables us to force maximize mode. There is a flag which lets user choose if they want to force clamshell/touchView mode regardless of device orientation(s). This CL applys the functionality of that flag. TEST=ash_unittests --gtest_filter="MaximizeModeControllerTest.Force*" BUG= 701135 Review-Url: https://codereview.chromium.org/2775683002 Cr-Commit-Position: refs/heads/master@{#460429} [modify] https://crrev.com/1d6e7115c66667ae3f401de68bf7cfbc7e694f79/ash/common/wm/maximize_mode/maximize_mode_controller.cc [modify] https://crrev.com/1d6e7115c66667ae3f401de68bf7cfbc7e694f79/ash/common/wm/maximize_mode/maximize_mode_controller.h [modify] https://crrev.com/1d6e7115c66667ae3f401de68bf7cfbc7e694f79/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc
,
Mar 29 2017
,
May 9 2017
9532.0.0, 60.0.3092.0 |
||||
►
Sign in to add a comment |
||||
Comment 1 by zork@chromium.org
, Mar 13 2017Status: Assigned (was: Untriaged)