New issue
Advanced search Search tips

Issue 701115 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug


Sign in to add a comment

Create TabHelper utility class for WebStateObserver + WebStateUserData multiple inheritance.

Project Member Reported by kkhorimoto@chromium.org, Mar 13 2017

Issue description

Multiple inheritance is prohibited by the style guide unless only one superclass has an implementation.  All other superclasses must be pure interfaces with an "Interface" suffix: https://google.github.io/styleguide/cppguide.html#Multiple_Inheritance

Several of the offending classes (see blocked bug for details) are built using multiple inheritance with WebStateObserver and WebStateUserData as the superclasses.  These classes can be combined to eliminate multiple inheritance violations for these classes.
 
Blocking: 701116
Blocking: 701119
Blocking: 701123
Blocking: 701127
Components: Internals
Owner: kkhorimoto@chromium.org
Status: Assigned (was: Untriaged)
Status: WontFix (was: Assigned)

Sign in to add a comment