New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701113 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make ResourceTimingInfo RefCounted.

Project Member Reported by sunjian@chromium.org, Mar 13 2017

Issue description

Make ResourceTimingInfo RefCounted.

Currently, ResourceTimingInfo's creation only returns a std::unique_ptr.
However, a ref-counted ResourceTimingInfo instance is needed so that a
single instance can be shared by multiple owners. The reason that this
new feature is requested is because now we expose PerformanceNavigationTiming
in a timely manner, which entails dynamically updating PerformanceNavigationTiming
instance as more information gets collected. One ResourceTimingInfo instance will
be held by a ResourceFether and a PerformanceNavigationTiming instance at the same
time. ResourceFether will keep updating ResourceTimingInfo while
PerformanceNavigationTiming consumes it. Therefore, making ResourceTimingInfo'
ref-counted is needed.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e016fcf6b3eae31983727f7f768d7a9b841ecf2

commit 2e016fcf6b3eae31983727f7f768d7a9b841ecf2
Author: sunjian <sunjian@chromium.org>
Date: Tue Mar 14 22:25:18 2017

Make ResourceTimingInfo RefCounted.

Currently, ResourceTimingInfo's creation only returns a std::unique_ptr.
However, a ref-counted ResourceTimingInfo instance is needed so that a
single instance can be shared by multiple owners. The reason that this
new feature is requested is because now we expose PerformanceNavigationTiming
in a timely manner, which entails dynamically updating PerformanceNavigationTiming
instance as more information gets collected. One ResourceTimingInfo instance will
be held by a ResourceFether and a PerformanceNavigationTiming instance at the same
time. ResourceFether will keep updating ResourceTimingInfo while
PerformanceNavigationTiming consumes it. Therefore, making ResourceTimingInfo
ref-counted is needed.

BUG= 701113 

Review-Url: https://codereview.chromium.org/2747933002
Cr-Commit-Position: refs/heads/master@{#456865}

[modify] https://crrev.com/2e016fcf6b3eae31983727f7f768d7a9b841ecf2/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp
[modify] https://crrev.com/2e016fcf6b3eae31983727f7f768d7a9b841ecf2/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/2e016fcf6b3eae31983727f7f768d7a9b841ecf2/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h
[modify] https://crrev.com/2e016fcf6b3eae31983727f7f768d7a9b841ecf2/third_party/WebKit/Source/platform/network/ResourceTimingInfo.cpp
[modify] https://crrev.com/2e016fcf6b3eae31983727f7f768d7a9b841ecf2/third_party/WebKit/Source/platform/network/ResourceTimingInfo.h

Status: Fixed (was: Started)

Sign in to add a comment