New issue
Advanced search Search tips

Issue 701107 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

MojoDecryptorService should just take a Decryptor (and not a CDM)

Project Member Reported by jrumm...@chromium.org, Mar 13 2017

Issue description

Currently MojoDecryptorService takes a reference to ContentDecryptionModule [1] even though it really only needs the Decryptor. Since the owner of the MojoDecryptorService already owns the ContentDecryptionModule and can manage the lifetimes appropriately, update MojoDecryptorService to only get a Decryptor.

[1] https://cs.chromium.org/chromium/src/media/mojo/services/mojo_decryptor_service.h?l=38
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34a31a9a833423694d567a9de9d0214d0c25aaa1

commit 34a31a9a833423694d567a9de9d0214d0c25aaa1
Author: jrummell <jrummell@chromium.org>
Date: Wed Mar 15 01:18:52 2017

Change MojoDecryptorService to take a Decryptor

There is no need for MojoDecryptorService to take a reference to a
ContentDecryptionModule as the creator of the service already owns the CDM
and can control the lifetime of both objects. It cleans up the interface as
now the service simply implements the mojo interface on top of the actual
Decryptor.

BUG= 701107 
TEST=mojo_decryptor tests pass

Review-Url: https://codereview.chromium.org/2752653002
Cr-Commit-Position: refs/heads/master@{#456935}

[modify] https://crrev.com/34a31a9a833423694d567a9de9d0214d0c25aaa1/media/mojo/clients/mojo_decryptor_unittest.cc
[modify] https://crrev.com/34a31a9a833423694d567a9de9d0214d0c25aaa1/media/mojo/services/mojo_cdm_service.cc
[modify] https://crrev.com/34a31a9a833423694d567a9de9d0214d0c25aaa1/media/mojo/services/mojo_cdm_service.h
[modify] https://crrev.com/34a31a9a833423694d567a9de9d0214d0c25aaa1/media/mojo/services/mojo_decryptor_service.cc
[modify] https://crrev.com/34a31a9a833423694d567a9de9d0214d0c25aaa1/media/mojo/services/mojo_decryptor_service.h

Status: Fixed (was: Assigned)

Sign in to add a comment