Issue 701093 link

Starred by 2 users

Issue metadata

Status:	Archived
Owner:	xiy...@chromium.org
Closed:	Mar 2017
Cc:	mustash-bugs@google.com
Components:	Internals>Services>WindowService
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
mustash-1 Proj-Mustash-Chrome VerifyIn-60 VerifyIn-61

mash: User avatar appears in top-left of browser windows

Project Member Reported by jamescook@chromium.org, Mar 13 2017

Issue description

Chrome r456403

* Login (only to a single account)
* Top-left of browser window shows avatar icon, like it would for a "teleported" window in a multi-user session

Probably some part of the multi-user window manager / session state isn't hooked up correctly.

Comment 1 by xiy...@chromium.org, Mar 13 2017

Cc: -xiy...@chromium.org
Owner: xiy...@chromium.org
Status: Assigned (was: Untriaged)

Yep, will revist this after the SessionController replacement CL lands.

Comment 2 by xiy...@chromium.org, Mar 24 2017

It turns out the session state is not involved. It is because BrowserNonClientFrameViewMus::UpdateProfileIcons always show profile indicator icon when FRAME_AVATAR_BUTTON is not defined. And cros does not use FRAME_AVATAR_BUTTON.

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f57f071dcdc75056365050f11a5e5673cb51d10

commit 8f57f071dcdc75056365050f11a5e5673cb51d10
Author: xiyuan <xiyuan@chromium.org>
Date: Fri Mar 24 16:16:34 2017

mash: Do not show avatar on browser frame

No avatar on browser frame for regular/guest user and
non-tabbed non-app browser.

BUG= 701093 

Review-Url: https://codereview.chromium.org/2777533003
Cr-Commit-Position: refs/heads/master@{#459445}

[modify] https://crrev.com/8f57f071dcdc75056365050f11a5e5673cb51d10/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc