[Butterfly] 3.5mm headset audio is not working after booting the device with 3.5mm headset. |
|||||||||||||
Issue descriptionChrome Version:9334.9.0 OS: chrome What steps will reproduce the problem? (1) Plug in 3.5mm headset into the device. (2) Power on and sign in to the device. (3) Play any youtube video. What is the expected result? 3.5mm headset should work. What happens instead? 3.5mm headset audio is missing. Note: unplugging and re-plugging the 3.5mm headset fixes this issue. Please use labels and text to provide additional information. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Mar 31 2017
Did you try this on any other devices?
,
Apr 12 2017
Jimmy, could you take a look at this? This is marked as a stable blocker, and we are nearing stable promotion for 58.
,
Apr 13 2017
,
Apr 13 2017
This is tricky. I found there is a bug in cras_alsa_mixer_set_mute: https://cs.corp.google.com/chromeos_public/src/third_party/adhd/cras/src/server/cras_alsa_mixer.c?type=cs&q=cras_alsa_mixer_set_mute+package:%5Echromeos_public$&l=1041 On butterfly, there are two simple mixer control: "Master" and "Headphone". After boot, after headphone is selected, init_device_setting tries to unmute Headphone by calling cras_alsa_mixer_set_mute with mixer output passed to it. However, crasl_alsa_mixer_set_mute only unmute playback switch (Master) and then ignores "Headphone" switch. The logic is different for "mute" and "unmute". When we want to mute, we can mute one or both of Master and Headphone. However, when we want to unmute, we should unmute both of them. As for why unplug/plug can bring it back, this is because switching between headphone/speaker cause alsa_iodev_set_active_node to run alsa_iodev_unmute_node, which set Headphone switch directly, as in https://cs.corp.google.com/chromeos_public/src/third_party/adhd/cras/src/server/cras_alsa_io.c?type=cs&l=2209 In sum, we should fix cras_alsa_mixer_set_mute.
,
Apr 13 2017
https://chromium-review.googlesource.com/476393 posted. Thanks!
,
Apr 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/f96bf8e9ca7a3b8d12de5ebf6cbfca3935e01b04 commit f96bf8e9ca7a3b8d12de5ebf6cbfca3935e01b04 Author: Cheng-Yi Chiang <cychiang@chromium.org> Date: Mon Apr 17 05:39:03 2017 CRAS: alsa_mixer - Fix cras_alsa_mixer_set_mute Consider both master switch and output specific switch for mute and unmute. To unmute, we need to unmute both master switch and output specific switch. To mute, we can only mute one of them, but mute both of them is simpler. BUG= chromium:701079 TEST=Plug headphone on butterfly and boot. Check it has function. Change-Id: I03e8737fdf98b1504bebe91082fc0e0e9d3fc9af Reviewed-on: https://chromium-review.googlesource.com/476393 Commit-Ready: Cheng-Yi Chiang <cychiang@chromium.org> Tested-by: Cheng-Yi Chiang <cychiang@chromium.org> Reviewed-by: Chinyue Chen <chinyue@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org> [modify] https://crrev.com/f96bf8e9ca7a3b8d12de5ebf6cbfca3935e01b04/cras/src/tests/alsa_mixer_unittest.cc [modify] https://crrev.com/f96bf8e9ca7a3b8d12de5ebf6cbfca3935e01b04/cras/src/server/cras_alsa_mixer.c [modify] https://crrev.com/f96bf8e9ca7a3b8d12de5ebf6cbfca3935e01b04/cras/src/server/cras_alsa_mixer.h
,
Apr 18 2017
Verified on 9471.0.0. Add merge request to R58. Thanks!
,
Apr 18 2017
This bug requires manual review: Only 6 days from stable, we might already have a stable candidate build Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 19 2017
,
Apr 19 2017
You may also need to put this into 59.
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/452f0ee0cf98867c9a4cb5f3575e0537346bf5f5 commit 452f0ee0cf98867c9a4cb5f3575e0537346bf5f5 Author: Cheng-Yi Chiang <cychiang@chromium.org> Date: Wed Apr 19 03:55:53 2017 CRAS: alsa_mixer - Fix cras_alsa_mixer_set_mute Consider both master switch and output specific switch for mute and unmute. To unmute, we need to unmute both master switch and output specific switch. To mute, we can only mute one of them, but mute both of them is simpler. BUG= chromium:701079 TEST=Plug headphone on butterfly and boot. Check it has function. Change-Id: I03e8737fdf98b1504bebe91082fc0e0e9d3fc9af Previous-Reviewed-on: https://chromium-review.googlesource.com/476393 (cherry picked from commit 4c650e4859c8b3bd94d33a5ae8c17899e7d36cf7) Reviewed-on: https://chromium-review.googlesource.com/481460 Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org> Tested-by: Cheng-Yi Chiang <cychiang@chromium.org> [modify] https://crrev.com/452f0ee0cf98867c9a4cb5f3575e0537346bf5f5/cras/src/tests/alsa_mixer_unittest.cc [modify] https://crrev.com/452f0ee0cf98867c9a4cb5f3575e0537346bf5f5/cras/src/server/cras_alsa_mixer.c [modify] https://crrev.com/452f0ee0cf98867c9a4cb5f3575e0537346bf5f5/cras/src/server/cras_alsa_mixer.h
,
Apr 19 2017
Thanks Bernie. The fix is merged to R58. Added merge request for R59.
,
Apr 19 2017
,
Apr 20 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/908b07eabe719247db0aba7c5bcd7509187d39c1 commit 908b07eabe719247db0aba7c5bcd7509187d39c1 Author: Cheng-Yi Chiang <cychiang@chromium.org> Date: Thu Apr 20 04:19:06 2017 CRAS: alsa_mixer - Fix cras_alsa_mixer_set_mute Consider both master switch and output specific switch for mute and unmute. To unmute, we need to unmute both master switch and output specific switch. To mute, we can only mute one of them, but mute both of them is simpler. BUG= chromium:701079 TEST=Plug headphone on butterfly and boot. Check it has function. Change-Id: I03e8737fdf98b1504bebe91082fc0e0e9d3fc9af Previous-Reviewed-on: https://chromium-review.googlesource.com/476393 (cherry picked from commit 6679566b988416a803edfcd1c2440e7f81e8b666) Reviewed-on: https://chromium-review.googlesource.com/481499 Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> Tested-by: Cheng-Yi Chiang <cychiang@chromium.org> Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org> [modify] https://crrev.com/908b07eabe719247db0aba7c5bcd7509187d39c1/cras/src/tests/alsa_mixer_unittest.cc [modify] https://crrev.com/908b07eabe719247db0aba7c5bcd7509187d39c1/cras/src/server/cras_alsa_mixer.c [modify] https://crrev.com/908b07eabe719247db0aba7c5bcd7509187d39c1/cras/src/server/cras_alsa_mixer.h
,
Apr 20 2017
,
Apr 27 2017
Verified with version 58.0.3029.89/9334.58.0 beta |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by son...@google.com
, Mar 13 2017