Mouse sensitivity is off by a constant-ish amount then?

The InputController instance in the Chrome process is stubbed out. So any changes in the Mouse settings don't actually do anything. I'd assume the mouse sensitivity gets loaded during startup for cash? This wouldn't work with mash.  crbug.com/642863  has a bit more information.

There could also be pixel vs DIP differences between cash and mash.

I just filed ssue 701089 for trackpad not appearing in settings, which could be related.

Yes, sensitivity seems off by a constant amount.

I'm not sure where sensitivity is loaded. achuith, do you know?

I believe this is where mouse sensitivity gets sent to the low level device from chrome:
https://cs.chromium.org/chromium/src/ui/events/ozone/evdev/input_device_factory_evdev.cc?l=307-308

The interface to settings is here:
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/system/input_device_settings.cc?l=45

Maybe this is where you want to add some translation for mash? 

Andrew probably has an opinion on this.

This is due to  crbug.com/642863 . We need a mojo interface for InputController so that trackpad settings are propagated from chrome to mus-ws.

We can look for an owner when the blocker bug is fixed.

I wired through the InputDeviceSettings/InputController (642863), but the speed still doesn't seems to mash. I'm not quite sure what else is needed here. Will keep poking.

The touchpad settings work now by the looks of things and you can adjust the speed. The bug is that for the same "touchpad speed" setting the speed isn't consistent between cash and mus/mash right?

I wonder if we're not computing the new mouse position in the same way? It seems like mus/mash is slower than cash, so I wonder if cash compute mouse movement in DIP and mus/mash in DDP?

I think ozone takes care of deciding the actual position of the mouse cursor? In which case, we would be using the same code + config in both cash and mus?

Kyle, that's right. With the same touchpad setting the distance I move my finger results in a smaller distance in pixels in mus/mash than cash (on a pixel device). Maybe we're off by the scale factor, I'm not sure.

I did verify that InputDeviceFactoryEvdev::ApplyInputDeviceSettings is setting the same values in both cases, so it has to be some other setting.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a657075be4b6d4a0915de79294a96ab8bb8696d0

commit a657075be4b6d4a0915de79294a96ab8bb8696d0
Author: Scott Violet <sky@chromium.org>
Date: Mon Jul 17 18:22:16 2017

chromeos: makes cursor configuration apply in mus/mash

The cursor config controls the scale (additional factor influencing
how fast the cursor moves) and rotation of the cursor in ozone. Ash
was applying this, but in mus/mash we need the window-server to apply
it. This patch makes mus automatically apply the scale.

BUG= 701068 
TEST=covered by test

Change-Id: Ibb4fb3d4584bc23bd17e9f1b527857e27f0b6564
Reviewed-on: https://chromium-review.googlesource.com/572326
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487164}
[modify] https://crrev.com/a657075be4b6d4a0915de79294a96ab8bb8696d0/ash/DEPS
[modify] https://crrev.com/a657075be4b6d4a0915de79294a96ab8bb8696d0/ash/display/window_tree_host_manager.cc
[modify] https://crrev.com/a657075be4b6d4a0915de79294a96ab8bb8696d0/ash/host/DEPS
[modify] https://crrev.com/a657075be4b6d4a0915de79294a96ab8bb8696d0/ash/host/ash_window_tree_host.h
[modify] https://crrev.com/a657075be4b6d4a0915de79294a96ab8bb8696d0/ash/host/ash_window_tree_host_platform.cc
[modify] https://crrev.com/a657075be4b6d4a0915de79294a96ab8bb8696d0/ash/host/ash_window_tree_host_platform.h
[modify] https://crrev.com/a657075be4b6d4a0915de79294a96ab8bb8696d0/ash/mus/ash_window_tree_host_mus.cc
[modify] https://crrev.com/a657075be4b6d4a0915de79294a96ab8bb8696d0/ash/mus/ash_window_tree_host_mus.h
[modify] https://crrev.com/a657075be4b6d4a0915de79294a96ab8bb8696d0/services/ui/public/interfaces/window_manager_constants.mojom
[modify] https://crrev.com/a657075be4b6d4a0915de79294a96ab8bb8696d0/services/ui/ws/BUILD.gn
[modify] https://crrev.com/a657075be4b6d4a0915de79294a96ab8bb8696d0/services/ui/ws/display.cc
[modify] https://crrev.com/a657075be4b6d4a0915de79294a96ab8bb8696d0/services/ui/ws/display.h
[modify] https://crrev.com/a657075be4b6d4a0915de79294a96ab8bb8696d0/services/ui/ws/platform_display.h
[modify] https://crrev.com/a657075be4b6d4a0915de79294a96ab8bb8696d0/services/ui/ws/platform_display_default.cc
[modify] https://crrev.com/a657075be4b6d4a0915de79294a96ab8bb8696d0/services/ui/ws/platform_display_default.h
[modify] https://crrev.com/a657075be4b6d4a0915de79294a96ab8bb8696d0/services/ui/ws/test_utils.cc
[modify] https://crrev.com/a657075be4b6d4a0915de79294a96ab8bb8696d0/services/ui/ws/test_utils.h
[modify] https://crrev.com/a657075be4b6d4a0915de79294a96ab8bb8696d0/services/ui/ws/window_tree_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9594b160e68289be12a6f8cf280fc14afb456818

commit 9594b160e68289be12a6f8cf280fc14afb456818
Author: Scott Violet <sky@chromium.org>
Date: Tue Jul 18 18:18:34 2017

chromeos: fix ifdefs

Apparently there is still an x11 chromeos bot. This should fix the
build for it.

TBR as this is trivial change to add ifdefs and should fix bot.

BUG= 701068 
TEST=none
TBR=erg@chromium.org

Change-Id: I55aad4f264ece847338e98eac635262c1583ac26
Reviewed-on: https://chromium-review.googlesource.com/576280
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487529}
[modify] https://crrev.com/9594b160e68289be12a6f8cf280fc14afb456818/ash/mus/ash_window_tree_host_mus.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ac836ba7825daf1e0defb02e130aa831b0af449

commit 6ac836ba7825daf1e0defb02e130aa831b0af449
Author: Scott Violet <sky@chromium.org>
Date: Thu Jul 20 21:30:28 2017

chromeos: plumbs internal display id through from window manager

Mus and client code may need to know the id of the internal
display. At a minimum mus uses this when setting the speed of the
mouse. This patch plumbs the internal display id from the window
manager to mus.

BUG= 701068 
TEST=covered by test

Change-Id: Ia93ddf4917fc0008f767cca60caabd0546c985c1
Reviewed-on: https://chromium-review.googlesource.com/580393
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488413}
[modify] https://crrev.com/6ac836ba7825daf1e0defb02e130aa831b0af449/ash/mus/display_synchronizer_unittest.cc
[modify] https://crrev.com/6ac836ba7825daf1e0defb02e130aa831b0af449/services/ui/public/interfaces/window_manager.mojom
[modify] https://crrev.com/6ac836ba7825daf1e0defb02e130aa831b0af449/services/ui/ws/display.cc
[modify] https://crrev.com/6ac836ba7825daf1e0defb02e130aa831b0af449/services/ui/ws/display_manager.cc
[modify] https://crrev.com/6ac836ba7825daf1e0defb02e130aa831b0af449/services/ui/ws/display_manager.h
[modify] https://crrev.com/6ac836ba7825daf1e0defb02e130aa831b0af449/services/ui/ws/test_utils.cc
[modify] https://crrev.com/6ac836ba7825daf1e0defb02e130aa831b0af449/services/ui/ws/user_display_manager.cc
[modify] https://crrev.com/6ac836ba7825daf1e0defb02e130aa831b0af449/services/ui/ws/user_display_manager_delegate.h
[modify] https://crrev.com/6ac836ba7825daf1e0defb02e130aa831b0af449/services/ui/ws/user_display_manager_unittest.cc
[modify] https://crrev.com/6ac836ba7825daf1e0defb02e130aa831b0af449/services/ui/ws/window_server.cc
[modify] https://crrev.com/6ac836ba7825daf1e0defb02e130aa831b0af449/services/ui/ws/window_server.h
[modify] https://crrev.com/6ac836ba7825daf1e0defb02e130aa831b0af449/services/ui/ws/window_tree.cc
[modify] https://crrev.com/6ac836ba7825daf1e0defb02e130aa831b0af449/services/ui/ws/window_tree.h
[modify] https://crrev.com/6ac836ba7825daf1e0defb02e130aa831b0af449/services/ui/ws/window_tree_unittest.cc
[modify] https://crrev.com/6ac836ba7825daf1e0defb02e130aa831b0af449/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/6ac836ba7825daf1e0defb02e130aa831b0af449/ui/aura/test/mus/test_window_manager_client.cc
[modify] https://crrev.com/6ac836ba7825daf1e0defb02e130aa831b0af449/ui/aura/test/mus/test_window_manager_client.h