ImageControllerTest.QueueImageDecodeChangeControllerWithTaskQueued is flaky |
||
Issue description[ RUN ] ImageControllerTest.QueueImageDecodeChangeControllerWithTaskQueued ../../cc/tiles/image_controller_unittest.cc:193: Failure Value of: thread_checker_.CalledOnValidThread() Actual: true Expected: false [ FAILED ] ImageControllerTest.QueueImageDecodeChangeControllerWithTaskQueued (4 ms)
,
Mar 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9eff7fc87045e048e489824abc6c1be9403ef7bc commit 9eff7fc87045e048e489824abc6c1be9403ef7bc Author: vmpstr <vmpstr@chromium.org> Date: Wed Mar 15 17:57:20 2017 cc: Fix a flake in ImageControllerTest.QueueImageDecodeChangeControllerWithTaskQueued ThreadChecker can't be used to check for "false", since debug implementations always return true. This patch fixes that by using ThreadCheckerImpl instead. The reason it is a flake and not a consistent repro is that the function may or may not have run (this is expected by tests). BUG= 701065 R=ericrk@chromium.org, danakj@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2749933002 Cr-Commit-Position: refs/heads/master@{#457135} [modify] https://crrev.com/9eff7fc87045e048e489824abc6c1be9403ef7bc/cc/tiles/image_controller_unittest.cc
,
Mar 15 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by ericrk@chromium.org
, Mar 13 2017Owner: vmp...@chromium.org