New issue
Advanced search Search tips

Issue 701058 link

Starred by 0 users
Status: Fixed
Owner:
nzolghadr@chromium.org
Closed: Mar 2017
Cc:
dtapu...@chromium.org
mustaq@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make SliderThumbElement use pointercapture APIs instead of setCapturingMouseEventsNode

Project Member Reported by nzolghadr@chromium.org, Mar 13 2017 
Before pointer capture APIs are introduced we were using an internal API setCapturingMouseEventsNode (https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/input/EventHandler.h?l=113) in EventHandler. Now that we have the pointer capture functionalities we should be using that instead and clean up the old capturing behavior.

Comment 1 by mustaq@chromium.org, Mar 13 2017 

Yes I agree, and considering going further in the same direction: may be we should just get rid of setCapturingMouseEventsNode etc in favor of setPointerCapture.

Not certain in this particular case but we may need to change the default handler of SliderThumbElement. I have seen some "capturing elements" assuming that only mouse-events are ever received by them.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4f29e883a0d68017e912d930b0070c3d76e8506

commit f4f29e883a0d68017e912d930b0070c3d76e8506
Author: nzolghadr <nzolghadr@chromium.org>
Date: Fri Mar 17 19:18:46 2017

Move slider implemention to use pointer capture

Previously slider input implementation was using
a hack in EventHandler to capture all the incoming
inputs. Now that pointer capture APIs are
introduced we can remove that hack.

BUG= 701058 

Review-Url: https://codereview.chromium.org/2749313002
Cr-Commit-Position: refs/heads/master@{#457846}

[modify] https://crrev.com/f4f29e883a0d68017e912d930b0070c3d76e8506/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp

Comment 3 by nzolghadr@chromium.org, Mar 17 2017

Status: Fixed (was: Started)
►

Sign in to add a comment