New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 701057 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Print previewer loads blank

Project Member Reported by jainabhi...@chromium.org, Mar 13 2017

Issue description

Chrome Version: M56+
OS: Windows, MAC

What steps will reproduce the problem?
(1) Visit a pdf URL
(2) After PDF loads, click on print button
(3) Print previewer loads

Sample URL (I was able to repro) : http://storage.googleapis.com/kinvey_production_2af5ca610609441c9f94807ac45dd53d/48838e81-dbad-46b3-a3f1-dc08f989cceb/MB-07549%20-%2015.03B-RST-PPM%23446%20-%20PCU%20Waste%20and%20Water%20Connections%20(Response).pdf

What is the expected result?
Preview should load with text that would print.

What happens instead?
Print Preview loads blank
Storing this file locally and then trying to preview does not fix the issue
 
Another Report
URL : http://www.pdf995.com/samples/pdf.pdf
Product Version 56.0.2924.87 | linux x86_64 | pt-BR
User is printing on a local printer
I wonder if this is related to  bug 697574  in some way.
In this bug PDFs load without any issues however print preview is blank.
Components: UI>Browser>PrintPreview
Yes, but the preview in the print preview dialog is another PDF viewer. So if we are experiencing PDF viewer wonkiness, there's a possibility.
Any logs that I can share ?
I was able to repro this issue for link in description.
I can also repro with the initial link, but not with http://www.pdf995.com/samples/pdf.pdf from comment 1. Comment 1 may be a separate bug with the same symptom.
Something about page 14 in the PDF messes up the preview. Previewing any page range without it seems to work. I should note this is not a regression. Older version of Chrome can't preview the PDF in the original bug report either.
Labels: Needs-Milestone

Comment 9 by npm@chromium.org, Mar 14 2017

Status: Available (was: Untriaged)

Comment 10 by ajha@chromium.org, Mar 27 2017

Labels: -Needs-Milestone M-59
Removing the Needs-Milestone as per C#7 and adding M-59. Please adjust the milestone as appropriate.
Interestingly, manually adding "/Resources<<>>" to page 14 (object 234) fixes the problem, at least on Linux. Could be something is happening if there is no "resources" field.
ExportPage fails and returns false as the check here fails for page 14:
https://cs.chromium.org/chromium/src/third_party/pdfium/fpdfsdk/fpdfppo.cpp?l=232

Page 14 does not have a Resources field and neither do its ancestors.
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/d5d8f606d98d9df959bf2fc308979471bddda8c1

commit d5d8f606d98d9df959bf2fc308979471bddda8c1
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Mar 29 23:50:58 2017

Quick fix for blank preview

BUG= chromium:701057 
Change-Id: I601b9763b2fddec953f769ec012cd7920806265a
Reviewed-on: https://pdfium-review.googlesource.com/3330
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/d5d8f606d98d9df959bf2fc308979471bddda8c1/fpdfsdk/fpdfppo.cpp

Project Member

Comment 14 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/d5d8f606d98d9df959bf2fc308979471bddda8c1

commit d5d8f606d98d9df959bf2fc308979471bddda8c1
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Mar 29 23:50:58 2017

Quick fix for blank preview

BUG= chromium:701057 
Change-Id: I601b9763b2fddec953f769ec012cd7920806265a
Reviewed-on: https://pdfium-review.googlesource.com/3330
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/d5d8f606d98d9df959bf2fc308979471bddda8c1/fpdfsdk/fpdfppo.cpp

Project Member

Comment 15 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b443952729c145d91777734b31a4e83ca2ba8ef7

commit b443952729c145d91777734b31a4e83ca2ba8ef7
Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org>
Date: Thu Mar 30 05:07:50 2017

Roll src/third_party/pdfium/ 9ad342b60..75b11e43c (12 commits)

https://pdfium.googlesource.com/pdfium.git/+log/9ad342b60490..75b11e43c284

$ git log 9ad342b60..75b11e43c --date=short --no-merges --format='%ad %ae %s'
2017-03-29 thestig Erase unused freetype files.
2017-03-29 tsepez Account for character size in last CFX_WideString patch.
2017-03-29 rbpotter Quick fix for blank preview
2017-03-29 tsepez Avoid guessing vsnprintf() buffer length.
2017-03-29 dsinclair Move xfa/fxbarcode fxbarcode/
2017-03-29 dsinclair Remove fgas/localization directory
2017-03-29 npm Fix undefined shift in JBig2_SddProc
2017-03-29 dsinclair Rename fgas/localization files to match contents
2017-03-29 tsepez Fix MSAN uninitialized value report.
2017-03-29 dsinclair Rename CFX_Unitime to CFX_DateTime
2017-03-29 dsinclair Split xfa_object.h apart.
2017-03-29 npm Do more checks before big allocs in TIFFReadDirEntryArray

Created with:
  roll-dep src/third_party/pdfium
BUG= 701057 , 705912 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2786863002
Cr-Commit-Position: refs/heads/master@{#460668}

[modify] https://crrev.com/b443952729c145d91777734b31a4e83ca2ba8ef7/DEPS

Status: Fixed (was: Available)
Verified this appears to be resolved in current Canary so marking fixed.

Note that comment 1 is likely a different bug, as that PDF does not have the
same defect that the PDF in the original bug report has. I also cannot reproduce the issue with that PDF.
Owner: rbpotter@chromium.org

Sign in to add a comment